Render publication names separately

Author: lmrodriguezr

app/controllers/publications_controller.rb

@@ -1,7 +1,7 @@
 class PublicationsController < ApplicationController
   before_action(
     :set_publication,
-    only: %i[show edit update destroy]
+    only: %i[show edit update destroy names]
   )
   before_action(
     :authenticate_contributor!, only: %i[new edit create update destroy]
@@ -34,6 +34,11 @@ def show
     @crumbs = [['Publications', publications_path], @publication.short_citation]
   end
 
+  # GET /publications/1/names
+  def names
+    render(layout: !params[:content].present?)
+  end
+
   # GET /publications/new
   def new
     @publication = Publication.new

app/views/publications/_names.html.erb

@@ -0,0 +1,12 @@
+<% publication.publication_names.each do |publication_name| %>
+  <% name = publication_name.name %>
+  <%= link_to(
+        name.abbr_name, name, class: 'badge badge-pill badge-primary') %>
+  <% if current_contributor? %>
+    <%= link_to(
+          publication_name, method: :delete,
+          class: 'badge badge-pill badge-info', title: 'unlink name',
+          data: { confirm: 'Are you sure?' }
+        ) { %><%= fa_icon('trash-alt') %><% } %>
+  <% end %>
+<% end %>

app/views/publications/_publication.html.erb

@@ -4,19 +4,19 @@
   <% end %>
 
   <%= adaptable_value(entry, 'Names') do %>
-    <% if publication.names.any? %>
-      <% publication.publication_names.each do |publication_name| %>
-        <% name = publication_name.name %>
-        <%= link_to(
-              name.abbr_name, name, class: 'badge badge-pill badge-primary') %>
-        <% if current_contributor? %>
-          <%= link_to(
-                publication_name, method: :delete,
-                class: 'badge badge-pill badge-info', title: 'unlink name',
-                data: { confirm: 'Are you sure?' }
-              ) { %><%= fa_icon('trash-alt') %><% } %>
-        <% end %>
-      <% end %>
+    <% if publication.names.count > 10 %>
+      <% id = modal(
+            'Publication names',
+            async: names_publication_url(publication, content: true)
+          ) %>
+       <%= modal_button(id, class: 'badge badge-secondary') do %>
+         <%= fa_icon('ellipsis-h') %>
+         <%= pluralize(publication.names.count, 'Name') %>
+       <% end %>
+    <% else %>
+      <%= render(
+            partial: 'publications/names',
+            locals: { publication: publication }) %>
     <% end %>
     <% if current_contributor? %>
       <%= link_to(
@@ -53,7 +53,7 @@
       </li>
       <li class="list-inline-item m-0">
         <%= link_to(publication, title: 'See more') do %>
-          <%= fa_icon('arrow-circle-right') %>
+          <%= fa_icon('arrow-circle-right') %> Text
         <% end %>
       </li>
     </ul>

app/views/publications/names.html.erb

@@ -0,0 +1 @@
+<%= render(partial: 'names', locals: { publication: @publication }) %>

config/routes.rb

@@ -194,6 +194,9 @@
   # Publications
   resources(:publications, concerns: :autocompletable) do
     resources(:contacts, only: %i[new create show index])
+    member do
+      get  :names
+    end
   end
   get  'doi/:doi' => 'publications#show', as: :doi, doi: /.+/
   resources(:contacts, only: []) do