Refactor user handling in NamesController

Author: lmrodriguezr

app/controllers/names_controller.rb

@@ -54,6 +54,7 @@ def autocomplete
   # GET /names.json
   def index(opts = {})
     return user if params[:user].present? && opts == {}
+    @user      ||= nil
     @submitted ||= false
     @endorsed  ||= false
     @draft     ||= false
@@ -117,13 +118,13 @@ def type_genomes
   # GET /names/user
   # GET /names/user?user=abc
   def user
-    user = current_user
+    @user = current_user
     if params[:user] && current_user&.admin?
-      user = User.find_by(username: params[:user])
+      @user = User.find_by(username: params[:user])
     end
-    @title  = "Names by #{user&.username}"
+    @title  = "Names by #{@user&.username}"
     @status = 'all'
-    index(where: { created_by: user })
+    index(where: { created_by: @user })
     render(:index)
   end
 

app/views/names/index.html.erb

@@ -39,7 +39,7 @@
         <span class="text-muted">•</span>
         <%=
           status == @status ?
-            status : link_to(status, names_path(npar.merge(status: status))
+            status : link_to(status, names_path(npar.merge(status: status)))
         %>
       <% end %>
     </div>