Skip to content

Commit 88eb0c1

Browse files
committed
Update status.rb
1 parent 2410cf8 commit 88eb0c1

1 file changed

Lines changed: 10 additions & 13 deletions

File tree

app/models/register/status.rb

Lines changed: 10 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -303,23 +303,20 @@ def check_pdf_files
303303

304304
if has_acc
305305
add_note('The effective publication includes the SeqCode accession')
306-
else
307-
names.each do |n|
308-
Check.find_or_create_by(
309-
name: n, kind: :effective_publication_missing_accession, pass: false
310-
)
311-
end
306+
end
307+
names.each do |n|
308+
Check.find_or_create_by(
309+
name: n, kind: :effective_publication_missing_accession, pass: has_acc
310+
)
312311
end
313312

314313
if inames.values.all?
315314
add_note('The effective publication mentions all names in the list')
316-
else
317-
inames.each do |n, v|
318-
next if v
319-
Check.find_or_create_by(
320-
name: n, kind: :name_missing_in_effective_publication, pass: false
321-
)
322-
end
315+
end
316+
inames.each do |n, v|
317+
Check.find_or_create_by(
318+
name: n, kind: :name_missing_in_effective_publication, pass: v
319+
)
323320
end
324321

325322
has_acc && inames.values.all?

0 commit comments

Comments
 (0)