Clean style for optional flags

Author: lmrodriguezr

app/helpers/names_helper.rb

@@ -61,9 +61,9 @@ def name_lineage(name, links: true, last: true, register: nil, visited: [])
 
     # Display the current name
     if links && !last
-      out << link_to(name.name_html(nil, assume_valid), name)
+      out << link_to(name.name_html(assume_valid: assume_valid), name)
     else
-      out << name.name_html(nil, assume_valid)
+      out << name.name_html(assume_valid: assume_valid)
     end
 
     out.inject(:+)

app/models/name.rb

@@ -496,7 +496,7 @@ def abbr_name_raw(name = nil, assume_valid = false)
     end
   end
 
-  def name_html(name = nil, assume_valid = false, check_correctness = false)
+  def name_html(name: nil, assume_valid: false, check_correctness: false)
     name = sanitize(name || self.name)
     if candidatus?
       name.gsub(/^Candidatus /, '<i>Candidatus</i> ').html_safe
@@ -517,19 +517,19 @@ def name_html(name = nil, assume_valid = false, check_correctness = false)
   end
 
   def name_html_correctness
-    name_html(nil, false, true)
+    name_html(assume_valid: false, check_correctness: true)
   end
 
   def abbr_corr_name
     abbr_name(corrigendum_from)
   end
 
   def corr_name_html
-    name_html(corrigendum_from)
+    name_html(name: corrigendum_from)
   end
 
-  def formal_html(check_correctness = false)
-    y = name_html(nil, false, check_correctness)
+  def formal_html(assume_valid: false, check_correctness: false)
+    y = name_html(assume_valid: assume_valid, check_correctness: check_correctness)
     y = "&#8220;#{y}&#8221;" if candidatus?
     y += ' <i>corrig.</i>'.html_safe if corrigendum_from?
     if not_validly_proposed_in.any?

app/views/names/_name_pdf.html.erb

@@ -3,9 +3,9 @@
   <div class="avoid-page-break">
     <h2 class="no-sticky">
       <%= name.inferred_rank.capitalize %>
-      <%= name.name_html(nil, true) %>
+      <%= name.name_html(assume_valid: true) %>
     </h2>
-    <%= name.formal_html %>
+    <%= name.formal_html(assume_valid: true) %>
   </div>
   <% name.only_display = true %>
   <dl>
@@ -24,7 +24,7 @@
         <% if name.type_is_name? %>
           <%= name.type_name.rank.capitalize %>
           <% if @register&.names&.include?(name.type_name) %>
-            <%= name.type_name.name_html(nil, true) %>
+            <%= name.type_name.name_html(assume_valid: true) %>
           <% else %>
             <%= name.type_name.name_html %>
           <% end %>

app/views/registers/table.html.erb

@@ -26,7 +26,7 @@
       <tr>
         <td>
           <%= name.inferred_rank.capitalize %>
-          <%= name.name_html(nil, true) %>
+          <%= name.name_html(assume_valid: true) %>
         </td>
         <td>
           <% if name.syllabication? %>
@@ -42,15 +42,15 @@
           <% elsif !name.parent %>
             <u>Unknown</u>
           <% elsif @register.names.include? name %>
-            <%= name.parent.name_html(nil, true) %>
+            <%= name.parent.name_html(assume_valid: true) %>
           <% else %>
             <%= name.parent.name_html %>
           <% end %>
         </td>
         <td>
           <% if name.type_is_name? %>
             <% if @register.names.include? name.type_name %>
-              <%= name.type_name.name_html(nil, true) %>
+              <%= name.type_name.name_html(assume_valid: true) %>
             <% else %>
               <%= name.type_name.name_html %>
             <% end %>