From e18dd07237f863332b0fa4f8243f45a7ad1c9c36 Mon Sep 17 00:00:00 2001 From: Jared Wallace Date: Sat, 5 Nov 2016 18:52:46 -0500 Subject: [PATCH 1/7] Clarified ambiguous instructions --- 02-functions/practice.js | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/02-functions/practice.js b/02-functions/practice.js index 907728c..63b87a2 100644 --- a/02-functions/practice.js +++ b/02-functions/practice.js @@ -1,5 +1,4 @@ -// (example) Write a function that accepts two number arguments and adds them -// together. +// Write a function that accepts two number arguments and returns their sum var add = function () { }; From 93a7acff7c6399740b2def9be1ed7af0e819fae0 Mon Sep 17 00:00:00 2001 From: Jared Wallace Date: Sat, 5 Nov 2016 19:27:13 -0500 Subject: [PATCH 2/7] Clarified the instructions for totalCost --- 02-functions/practice.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/02-functions/practice.js b/02-functions/practice.js index 63b87a2..50e4025 100644 --- a/02-functions/practice.js +++ b/02-functions/practice.js @@ -3,7 +3,7 @@ var add = function () { }; -// Create a function that takes in a cost and a quantity and outputs the total +// Create a function that takes in a cost and a quantity and returns the total // pre-tax cost for that quantity of items at the given price. For example // // var preTaxTotal = totalCost(5, 5.99); // 5 items at 5.99 From e9655b0a10c739c1b5ca48721a9f9d5e13d89f0a Mon Sep 17 00:00:00 2001 From: Jared Wallace Date: Sun, 6 Nov 2016 21:21:12 -0600 Subject: [PATCH 3/7] Corrected instructions for isPrime based on what is being tested --- 05-loops/practice.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/05-loops/practice.js b/05-loops/practice.js index 41ad44f..f9c5a0a 100644 --- a/05-loops/practice.js +++ b/05-loops/practice.js @@ -154,7 +154,7 @@ var isPrime = function () { // Using the `isPrime` function, write a function that accepts a number as -// input sums all the primes smaller than that number. +// input sums all the primes smaller or equal to that number. // // sumPrimesUpTo(100); // //=> 1060 From 477cb852bd9d794e45e701d904549a53bd609d2c Mon Sep 17 00:00:00 2001 From: Jared Wallace Date: Sun, 6 Nov 2016 21:23:36 -0600 Subject: [PATCH 4/7] Corrected instructions for sumOfFirstNPrimes --- 05-loops/practice.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/05-loops/practice.js b/05-loops/practice.js index f9c5a0a..e3e3834 100644 --- a/05-loops/practice.js +++ b/05-loops/practice.js @@ -176,7 +176,7 @@ var sumPrimesUpTo = function () { // Using the `isPrime` function, write a function that takes in a -// positive integer, n, and returns the first n numbers. +// positive integer, n, and returns the sum of the first n prime numbers. // // sumOfFirstNPrimes(10); // //=> 129 From 0b9800b305a8f7421c1b6d9dc61217bd172367b4 Mon Sep 17 00:00:00 2001 From: Jared Wallace Date: Sun, 6 Nov 2016 21:43:55 -0600 Subject: [PATCH 5/7] Made directions for removeNonLetters more explicit in how it should handle bad input --- 05-loops/practice.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/05-loops/practice.js b/05-loops/practice.js index e3e3834..e26255b 100644 --- a/05-loops/practice.js +++ b/05-loops/practice.js @@ -214,7 +214,7 @@ var sumOfFirstNPrimes = function () { // //=> false // // Let's start by writing a function to remove all non-letter characters -// from the input. +// from the input. If the input is not a string, throw an error. // // removeNonLetters("A man, a plan, a canal, Panama"); // //=> AmanaplanacanalPanama From d681b4c12a45a2ef139427324e43c473f07320f8 Mon Sep 17 00:00:00 2001 From: Jared Wallace Date: Mon, 7 Nov 2016 13:40:57 -0600 Subject: [PATCH 6/7] Function description said number when it actually should be type agnostic --- 06-arrays/practice.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/06-arrays/practice.js b/06-arrays/practice.js index d376825..ffd247b 100644 --- a/06-arrays/practice.js +++ b/06-arrays/practice.js @@ -1,5 +1,5 @@ -// Write a function called `containsTwice` that accepts a number and an array, -// and returns `true` if that number appears in the array twice, and `false` +// Write a function called `containsTwice` that accepts an element and an array, +// and returns `true` if that element appears in the array twice, and `false` // otherwise. // // containsTwice(5, [1, 2, 3, 4, 5]); From f022aef10445c5836f4d95bedb2c177648e176a9 Mon Sep 17 00:00:00 2001 From: Jared Wallace Date: Mon, 7 Nov 2016 13:48:21 -0600 Subject: [PATCH 7/7] Changed the language of valuesContainedTwice to not lead people to think two arrays would be needed --- 06-arrays/practice.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/06-arrays/practice.js b/06-arrays/practice.js index ffd247b..40e720d 100644 --- a/06-arrays/practice.js +++ b/06-arrays/practice.js @@ -103,7 +103,8 @@ var containsAnyTwice = function () { // In the previous problem, we determined whether or not an array contains any // of a list of values exactly twice. In this problem, we'll actually return // those values appearing twice. Create a new function that returns an array of -// only the values from the first array that appear twice in the second array. +// only the values that appear twice in the array. +// // // For this problem, you'll create a new array, and you'll use its `push` // function to add elements to the end. You'll most likely want to use the