From 98304031c00123f91753948e2bcb5e4a973060d8 Mon Sep 17 00:00:00 2001
From: selkamand <73202525+selkamand@users.noreply.github.com>
Date: Mon, 9 Feb 2026 22:14:32 +1100
Subject: [PATCH] Refine matrix element type message

---
 NEWS.md                           |  2 ++
 R/assert_type.R                   |  3 +--
 R/is_functions.R                  | 16 +++++++++++++---
 tests/testthat/test-assert_type.R |  2 +-
 4 files changed, 17 insertions(+), 6 deletions(-)

diff --git a/NEWS.md b/NEWS.md
index 05ee3af..8014dd8 100644
--- a/NEWS.md
+++ b/NEWS.md
@@ -32,6 +32,8 @@
 
 * Improved error messages when `assert_create()` arguments are inappropriate
 
+* Improved `assert_numeric()` error messaging for non-numeric matrices/arrays
+
 # assertions 0.1.0
 
 * Added a `NEWS.md` file to track changes to the package.
diff --git a/R/assert_type.R b/R/assert_type.R
index fcff512..8d02a13 100644
--- a/R/assert_type.R
+++ b/R/assert_type.R
@@ -170,7 +170,7 @@ assert_factor_vector <- assert_create(is.factor, default_error_msg = msg_helper_
 #'
 #' @concept assert_type
 #' @export
-assert_numeric <- assert_create(is.numeric, default_error_msg = msg_helper_assert_type("numeric", a = FALSE))
+assert_numeric <- assert_create(is_numeric_with_matrix_message, default_error_msg = msg_helper_assert_type("numeric", a = FALSE))
 
 ## numeric vector -----------------------------------------------------------
 #' Assert input is a numeric vector
@@ -597,4 +597,3 @@ assert_connection <- assert_create(
   func = is_connection,
   default_error_msg = msg_helper_assert_type("database connection")
 )
-
diff --git a/R/is_functions.R b/R/is_functions.R
index b5a56d3..c0fa8db 100644
--- a/R/is_functions.R
+++ b/R/is_functions.R
@@ -35,6 +35,19 @@ is_numeric_vector <- function(x){
   is.numeric(x) && is_vector(x)
 }
 
+is_numeric_with_matrix_message <- function(x){
+  if(is.numeric(x))
+    return(TRUE)
+
+  if(is.matrix(x) || is.array(x)){
+    structure_type <- if (is.matrix(x)) "matrix" else "array"
+    element_type <- typeof(x)
+    return(paste0("'{.strong {arg_name}}' must be numeric, not a {.strong ", element_type, "} ", structure_type))
+  }
+
+  return(FALSE)
+}
+
 
 #' Check if an object is a single number
 #'
@@ -258,6 +271,3 @@ is_non_empty_string_advanced <- function(x){
 
   return(invisible(TRUE))
 }
-
-
-
diff --git a/tests/testthat/test-assert_type.R b/tests/testthat/test-assert_type.R
index b616f5e..0015300 100644
--- a/tests/testthat/test-assert_type.R
+++ b/tests/testthat/test-assert_type.R
@@ -120,6 +120,7 @@ cli::test_that_cli("assert_numeric() works", configs = "plain", {
   expect_identical(assert_numeric(matrix(1:9, 3)), TRUE)
 
   # Aborts for non-numeric objects
+  expect_error(assert_numeric(matrix(LETTERS[1:5])), "'matrix(LETTERS[1:5])' must be numeric, not a character matrix", fixed = TRUE)
   expect_error(assert_numeric(c("a", "b", "c")), "'c(\"a\", \"b\", \"c\")' must be numeric, not a character", fixed = TRUE)
   expect_error(assert_numeric(factor(c(1, 2, 3))), "'factor(c(1, 2, 3))' must be numeric, not a factor", fixed = TRUE)
   expect_error(assert_numeric(data.frame(a = 1, b = 2)), "'data.frame(a = 1, b = 2)' must be numeric, not a data.frame", fixed = TRUE)
@@ -550,4 +551,3 @@ cli::test_that_cli("assert_connection() works", configs = "plain", {
 })
 
 
-