Skip to content

Commit b1af18d

Browse files
committed
fix: copy all cmake modules in Dockerfiles, quote GITHUB_STEP_SUMMARY, add workflow permissions
1 parent 88d71ee commit b1af18d

4 files changed

Lines changed: 10 additions & 7 deletions

File tree

.github/workflows/ci.yml

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,9 @@ on:
88
repository_dispatch:
99
types: [ros2_medkit_updated]
1010

11+
permissions:
12+
contents: read
13+
1114
jobs:
1215
lint:
1316
runs-on: ubuntu-24.04
@@ -40,12 +43,12 @@ jobs:
4043
run: |
4144
SHA="${{ github.event.client_payload.sha }}"
4245
RUN_URL="${{ github.event.client_payload.run_url }}"
43-
echo "## Triggered by ros2_medkit" >> $GITHUB_STEP_SUMMARY
44-
echo "- Commit: \`${SHA:-unknown}\`" >> $GITHUB_STEP_SUMMARY
46+
echo "## Triggered by ros2_medkit" >> "$GITHUB_STEP_SUMMARY"
47+
echo "- Commit: \`${SHA:-unknown}\`" >> "$GITHUB_STEP_SUMMARY"
4548
if [ -n "$RUN_URL" ]; then
46-
echo "- Run: [View triggering run]($RUN_URL)" >> $GITHUB_STEP_SUMMARY
49+
echo "- Run: [View triggering run]($RUN_URL)" >> "$GITHUB_STEP_SUMMARY"
4750
else
48-
echo "- Run: (URL not provided)" >> $GITHUB_STEP_SUMMARY
51+
echo "- Run: (URL not provided)" >> "$GITHUB_STEP_SUMMARY"
4952
fi
5053
5154
- name: Checkout repository

demos/moveit_pick_place/Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ RUN git clone --depth 1 --branch ${ROS2_MEDKIT_REF} https://github.com/selfpatch
4747
ros2_medkit/src/ros2_medkit_fault_manager \
4848
ros2_medkit/src/ros2_medkit_fault_reporter \
4949
ros2_medkit/src/ros2_medkit_diagnostic_bridge . && \
50-
mkdir -p ${COLCON_WS}/cmake && mv ros2_medkit/cmake/ROS2MedkitCompat.cmake ${COLCON_WS}/cmake/ && \
50+
cp -r ros2_medkit/cmake ${COLCON_WS}/ && \
5151
rm -rf ros2_medkit
5252

5353
# Copy demo package from local context

demos/sensor_diagnostics/Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ RUN git clone --depth 1 https://github.com/selfpatch/ros2_medkit.git && \
3232
mv ros2_medkit/src/ros2_medkit_fault_manager . && \
3333
mv ros2_medkit/src/ros2_medkit_fault_reporter . && \
3434
mv ros2_medkit/src/ros2_medkit_diagnostic_bridge . && \
35-
mkdir -p ${COLCON_WS}/cmake && mv ros2_medkit/cmake/ROS2MedkitCompat.cmake ${COLCON_WS}/cmake/ && \
35+
cp -r ros2_medkit/cmake ${COLCON_WS}/ && \
3636
rm -rf ros2_medkit
3737

3838
# Copy demo package

demos/turtlebot3_integration/Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ RUN git clone --depth 1 https://github.com/selfpatch/ros2_medkit.git && \
5252
mv ros2_medkit/src/ros2_medkit_fault_manager . && \
5353
mv ros2_medkit/src/ros2_medkit_fault_reporter . && \
5454
mv ros2_medkit/src/ros2_medkit_diagnostic_bridge . && \
55-
mkdir -p ${COLCON_WS}/cmake && mv ros2_medkit/cmake/ROS2MedkitCompat.cmake ${COLCON_WS}/cmake/ && \
55+
cp -r ros2_medkit/cmake ${COLCON_WS}/ && \
5656
rm -rf ros2_medkit
5757

5858
# Copy demo package from local context (this repo)

0 commit comments

Comments
 (0)