Skip to content

Commit 6837a3a

Browse files
committed
refactor: Remove volume mapping for rosbag storage
Volume mapping could cause issues when user has old faults in the fresh demo environment. Removing it to avoid confusion and potential issues with rosbag storage. Users can still access rosbag files through the container if needed.
1 parent b56b7ed commit 6837a3a

3 files changed

Lines changed: 3 additions & 16 deletions

File tree

demos/sensor_diagnostics/docker-compose.yml

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,6 @@ services:
77
container_name: sensor_diagnostics_demo
88
environment:
99
- ROS_DOMAIN_ID=40
10-
volumes:
11-
- medkit_data:/var/lib/ros2_medkit # Persistent storage for faults and rosbags
1210
ports:
1311
- "8080:8080"
1412
stdin_open: true
@@ -50,7 +48,3 @@ services:
5048
curl -sf http://localhost:8080/api/v1/health &&
5149
curl -sf http://localhost:8080/api/v1/apps | jq '.items[] | .id' &&
5250
echo 'CI validation passed!'"
53-
54-
volumes:
55-
medkit_data:
56-
name: sensor_diagnostics_medkit_data

demos/turtlebot3_integration/README.md

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -75,13 +75,12 @@ ros2 topic echo /odom
7575
### Stopping the Demo
7676

7777
```bash
78-
./stop-demo.sh # Stop containers (preserves rosbag data)
79-
./stop-demo.sh --volumes # Stop and remove volumes (deletes rosbag data)
78+
./stop-demo.sh # Stop containers
8079
./stop-demo.sh --images # Stop and remove images
8180
```
8281

83-
**Note:** Rosbag recordings are stored in a Docker volume (`turtlebot3_medkit_data`).
84-
Use `--volumes` to delete this data when stopping.
82+
**Note:** Fault data and rosbag recordings are ephemeral — they are stored
83+
inside the container and cleared on restart.
8584

8685
### 2. Access the Web UI
8786

demos/turtlebot3_integration/docker-compose.yml

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@ services:
1414
- HEADLESS=${HEADLESS:-false}
1515
volumes:
1616
- /tmp/.X11-unix:/tmp/.X11-unix:rw
17-
- medkit_data:/var/lib/ros2_medkit # Persistent storage for faults and rosbags
1817
ports:
1918
- "8080:8080"
2019
stdin_open: true
@@ -46,7 +45,6 @@ services:
4645
- NVIDIA_DRIVER_CAPABILITIES=all
4746
volumes:
4847
- /tmp/.X11-unix:/tmp/.X11-unix:rw
49-
- medkit_data:/var/lib/ros2_medkit # Persistent storage for faults and rosbags
5048
ports:
5149
- "8080:8080"
5250
deploy:
@@ -70,7 +68,3 @@ services:
7068
container_name: sovd_web_ui
7169
ports:
7270
- "3000:80"
73-
74-
volumes:
75-
medkit_data:
76-
name: turtlebot3_medkit_data

0 commit comments

Comments
 (0)