fix: abort run-demo.sh on Docker build failure

set -e does not catch failures inside && lists, so a failed docker
build would silently continue and print the success banner. Split
build and up into separate steps with an explicit exit on build
failure, tearing down any partial containers.

Author: bburda

demos/moveit_pick_place/run-demo.sh

@@ -137,15 +137,23 @@ if [[ "$DETACH_MODE" == "true" ]]; then
 fi
 
 if docker compose version &> /dev/null; then
-    # shellcheck disable=SC2086
-    docker compose ${COMPOSE_ARGS} build ${BUILD_ARGS} && \
-    docker compose ${COMPOSE_ARGS} up ${DETACH_FLAG}
+    COMPOSE_CMD="docker compose"
 else
+    COMPOSE_CMD="docker-compose"
+fi
+
+# shellcheck disable=SC2086
+if ! ${COMPOSE_CMD} ${COMPOSE_ARGS} build ${BUILD_ARGS}; then
+    echo ""
+    echo "❌ Docker build failed! Stopping any partially created containers..."
     # shellcheck disable=SC2086
-    docker-compose ${COMPOSE_ARGS} build ${BUILD_ARGS} && \
-    docker-compose ${COMPOSE_ARGS} up ${DETACH_FLAG}
+    ${COMPOSE_CMD} ${COMPOSE_ARGS} down 2>/dev/null || true
+    exit 1
 fi
 
+# shellcheck disable=SC2086
+${COMPOSE_CMD} ${COMPOSE_ARGS} up ${DETACH_FLAG}
+
 if [[ "$DETACH_MODE" == "true" ]]; then
     echo ""
     echo "✅ Demo started in background!"

demos/sensor_diagnostics/run-demo.sh

@@ -93,13 +93,22 @@ if [[ "$DETACH_MODE" == "true" ]]; then
 fi
 
 if docker compose version &> /dev/null; then
-    # shellcheck disable=SC2086
-    docker compose build ${BUILD_ARGS} && docker compose up ${DETACH_FLAG}
+    COMPOSE_CMD="docker compose"
 else
-    # shellcheck disable=SC2086
-    docker-compose build ${BUILD_ARGS} && docker-compose up ${DETACH_FLAG}
+    COMPOSE_CMD="docker-compose"
 fi
 
+# shellcheck disable=SC2086
+if ! ${COMPOSE_CMD} build ${BUILD_ARGS}; then
+    echo ""
+    echo "❌ Docker build failed! Stopping any partially created containers..."
+    ${COMPOSE_CMD} down 2>/dev/null || true
+    exit 1
+fi
+
+# shellcheck disable=SC2086
+${COMPOSE_CMD} up ${DETACH_FLAG}
+
 if [[ "$DETACH_MODE" == "true" ]]; then
     echo ""
     echo "✅ Demo started in background!"

demos/turtlebot3_integration/run-demo.sh

@@ -144,15 +144,23 @@ if [[ "$DETACH_MODE" == "true" ]]; then
 fi
 
 if docker compose version &> /dev/null; then
-    # shellcheck disable=SC2086
-    docker compose ${COMPOSE_ARGS} build ${BUILD_ARGS} && \
-    docker compose ${COMPOSE_ARGS} up ${DETACH_FLAG}
+    COMPOSE_CMD="docker compose"
 else
+    COMPOSE_CMD="docker-compose"
+fi
+
+# shellcheck disable=SC2086
+if ! ${COMPOSE_CMD} ${COMPOSE_ARGS} build ${BUILD_ARGS}; then
+    echo ""
+    echo "❌ Docker build failed! Stopping any partially created containers..."
     # shellcheck disable=SC2086
-    docker-compose ${COMPOSE_ARGS} build ${BUILD_ARGS} && \
-    docker-compose ${COMPOSE_ARGS} up ${DETACH_FLAG}
+    ${COMPOSE_CMD} ${COMPOSE_ARGS} down 2>/dev/null || true
+    exit 1
 fi
 
+# shellcheck disable=SC2086
+${COMPOSE_CMD} ${COMPOSE_ARGS} up ${DETACH_FLAG}
+
 if [[ "$DETACH_MODE" == "true" ]]; then
     echo ""
     echo "✅ Demo started in background!"