Skip to content

Commit 1cd83dc

Browse files
bburdamfaferek93
authored andcommitted
fix(sensor-demo): use consistent dash-based naming in comments
Apply review suggestions from @mfaferek93: - Change anomaly_detector → anomaly-detector in inject-nan.sh, inject-failure.sh - Change diagnostic_bridge → diagnostic-bridge in inject-drift.sh, inject-noise.sh Maintains consistency with dash-based entity IDs used in API calls.
1 parent dd0d481 commit 1cd83dc

4 files changed

Lines changed: 9 additions & 9 deletions

File tree

demos/sensor_diagnostics/inject-drift.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
#!/bin/bash
22
# Inject sensor drift fault - demonstrates LEGACY fault reporting path
3-
# LiDAR drift → DiagnosticArray → /diagnostics → diagnostic_bridge → FaultManager
3+
# LiDAR drift → DiagnosticArray → /diagnostics → diagnostic-bridge → FaultManager
44

55
GATEWAY_URL="${GATEWAY_URL:-http://localhost:8080}"
66
API_BASE="${GATEWAY_URL}/api/v1"
77

8-
echo "Injecting DRIFT fault (Legacy path: LiDAR → diagnostic_bridge)..."
8+
echo "Injecting DRIFT fault (Legacy path: LiDAR → diagnostic-bridge)..."
99
echo ""
1010

1111
# LiDAR drift: uses legacy diagnostics path

demos/sensor_diagnostics/inject-failure.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
#!/bin/bash
22
# Inject sensor failure (timeout) fault - demonstrates MODERN fault reporting path
3-
# IMU sensor → anomaly_detector → FaultManager (via ReportFault service)
3+
# IMU sensor → anomaly-detector → FaultManager (via ReportFault service)
44

55
GATEWAY_URL="${GATEWAY_URL:-http://localhost:8080}"
66
API_BASE="${GATEWAY_URL}/api/v1"
77

8-
echo "Injecting SENSOR FAILURE fault (Modern path: IMU → anomaly_detector)..."
8+
echo "Injecting SENSOR FAILURE fault (Modern path: IMU → anomaly-detector)..."
99

1010
# Set high failure probability - IMU will stop publishing
1111
echo "Setting IMU failure_probability to 1.0 (complete failure)..."

demos/sensor_diagnostics/inject-nan.sh

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,16 +15,16 @@ curl -s -X PUT "${API_BASE}/apps/lidar-sim/configurations/inject_nan" \
1515
-d '{"value": true}'
1616
echo ""
1717

18-
# MODERN PATH: IMU/GPS → anomaly_detector → FaultManager (direct service call)
18+
# MODERN PATH: IMU/GPS → anomaly-detector → FaultManager (direct service call)
1919
echo "[MODERN PATH] Enabling IMU inject_nan..."
20-
echo " Fault path: imu-sim → anomaly_detector → /fault_manager/report_fault"
20+
echo " Fault path: imu-sim → anomaly-detector → /fault_manager/report_fault"
2121
curl -s -X PUT "${API_BASE}/apps/imu-sim/configurations/inject_nan" \
2222
-H "Content-Type: application/json" \
2323
-d '{"value": true}'
2424
echo ""
2525

2626
echo "[MODERN PATH] Enabling GPS inject_nan..."
27-
echo " Fault path: gps-sim → anomaly_detector → /fault_manager/report_fault"
27+
echo " Fault path: gps-sim → anomaly-detector → /fault_manager/report_fault"
2828
curl -s -X PUT "${API_BASE}/apps/gps-sim/configurations/inject_nan" \
2929
-H "Content-Type: application/json" \
3030
-d '{"value": true}'

demos/sensor_diagnostics/inject-noise.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
#!/bin/bash
22
# Inject high noise fault - demonstrates LEGACY fault reporting path
3-
# LiDAR/Camera → DiagnosticArray → /diagnostics → diagnostic_bridge → FaultManager
3+
# LiDAR/Camera → DiagnosticArray → /diagnostics → diagnostic-bridge → FaultManager
44

55
GATEWAY_URL="${GATEWAY_URL:-http://localhost:8080}"
66
API_BASE="${GATEWAY_URL}/api/v1"
77

8-
echo "Injecting HIGH NOISE fault (Legacy path: LiDAR/Camera → diagnostic_bridge)..."
8+
echo "Injecting HIGH NOISE fault (Legacy path: LiDAR/Camera → diagnostic-bridge)..."
99
echo ""
1010

1111
# LiDAR: increase noise stddev (uses legacy diagnostics path)

0 commit comments

Comments
 (0)