Bug: Wrong URL copied in panel

[ericvicenti]

When copying a comment link with the copy link button, it should always copy the "focused" URL of the comment, not the panel.

Repro: Open this URL:

https://gabo.es/bitcoin?v=bafy2bzacebgvdhl752qdhdqpbh2nnv354xkbwceagteitqvlh2vssh6yqubxs&panel=comments/zDnaewGjqQdi8qqNFu1fP4PPHuUniTwv8Nq78ezEHzpETDu8o/z6BLS5TCSUD1Y1

And click the "copy comment URL" button from the panel.

Expected, it should copy this URL:

https://gabo.es/bitcoin/:comment/zDnaewGjqQdi8qqNFu1fP4PPHuUniTwv8Nq78ezEHzpETDu8o/z6BLS5TCSUD1Y1

Actual: it copies the URL with the ?panel=

This should apply to all comments that appear in the panel.

[horacioh]

I don't think this expectation is correct. Or at least that's what I believe because this is encoded in the system:

• if you click the copy link in the panel, will encode the link in the panel
• if you click the copy link in the main panel, then it will copy the link in the main panel

We can change that but I believe the way it is right now is how it should be.

wdyt @GaboHBeaumont @burdiyan @juligasa @iskaktoltay

[ericvicenti]

But the user wants a URL to the comment. And the url that gets copied is addressing the doc 😅

[horacioh]

But the user wants a URL to the comment. And the url that gets copied is addressing the doc 😅

yeah you are right. I don't have strong opinions about this. I thought that it would be correct to copy the comment where it is rendered but what you are saying makes sense. I will fix this.

[ericvicenti]

It's definitely tricky and there are other improvements we could make to help things be less confusing.

For example allow the user to select the comment URL from the dropdown when they paste a doc link with ?panel=comments/...