Methods to make trades (not just get information)

[manesioz]

Hey! Awesome work so far man,

I was wondering if you planned on supporting placing orders?

If not I wouldn't mind making some contributions to include that, but lmk either way.

[seansullivan44]

Hey! I was planning on adding those features, but have been busy with other projects. It would be great if you wanted to add those features in!

[JonathanCauchon]

@manesioz I am also very interested in that!
Let me know if you would like to collaborate on this.

[manesioz]

@JonathanCauchon Awesome! I've been pretty busy lately as well so if you want to get started on that feel free :)

[alik604]

@manesioz @JonathanCauchon

Do you guys have any ideas on how to get the security_id

From dev tools -> JS fetch

let sellTwo = await fetch("https://trade-service.wealthsimple.com/orders", {
  "headers": {
    "accept": "application/json",
    "accept-language": "en-US,en;q=0.9",
    "authorization": "Bearer 1CkcahYFOOvwfBdHJDXzONgSDn1C-BARGE-J3IAm420",
    "content-type": "application/json",
    "sec-ch-ua": "\"Google Chrome\";v=\"87\", \" Not;A Brand\";v=\"99\", \"Chromium\";v=\"87\"",
    "sec-ch-ua-mobile": "?0",
    "sec-fetch-dest": "empty",
    "sec-fetch-mode": "cors",
    "sec-fetch-site": "same-site",
    "x-app-instance-id": "6277686b-420d-47f9-a836-00fd35462e49",
    "x-platform-os": "web",
    "x-websocket-id": "websocket-4905089f-foob-4d1a-a5ad-b57072e0d6fa"
  },
  "referrer": "https://my.wealthsimple.com/",
  "referrerPolicy": "strict-origin-when-cross-origin",
  "body": "{\"account_id\":\"non-registered-FOOBAR\",\"quantity\":1,\"security_id\":\"sec-s-e90effe2699b47acbd69e96ffd0fea97\",\"order_type\":\"sell_quantity\",\"order_sub_type\":\"limit\",\"time_in_force\":\"day\",\"market_value\":1000,\"limit_price\":1000}",
  "method": "POST",
  "mode": "cors",
  "credentials": "include"
});

next issue I'm facing,

input

{'account_id': 'non-registered-FOOBAR',
 'quantity': 1,
 'security_id': 'sec-s-e90effe2699b47acbd69e96ffd0fea97',
 'order_type': 'sell_quantity',
 'order_sub_type': 'limit',
 'market_value': '123',
 'limit_price': '123',
 'time_in_force': 'day'}

output
{"error":"quantity is invalid."}

I think I'll be able to write the core code, but I sure as hell won't pass a code review haha.. also its a jupyter notebook

edit: curl code - minimal

curl 'https://trade-service.wealthsimple.com/orders' \
  -H 'authorization: Bearer kxLnCFnM3huAg1ZKNUGfuckDaSECuOS4EtsO4KlxXnA' \
  -H 'content-type: application/json' \
  --data-binary '{"account_id":"non-registered-t19bfooe","quantity":2,"security_id":"sec-s-271b88fdc6a8484692950f329c2733c6","order_type":"buy_quantity","order_sub_type":"limit","time_in_force":"day","market_value":4,"limit_price":1}' \
  --compressed

[manesioz]

@alik604 Seems like the error is regarding quantity. Try:

{'account_id': 'non-registered-FOOBAR',
 'quantity': '1',
 'security_id': 'sec-s-e90effe2699b47acbd69e96ffd0fea97',
 'order_type': 'sell_quantity',
 'order_sub_type': 'limit',
 'market_value': '123',
 'limit_price': '123',
 'time_in_force': 'day'}

[alik604]

@manesioz I'll try that again. However, do I recall trying '1', 1 and for the sake of my sanity, one and 0x1 .

[notAmine]

@alik604 @manesioz I also got that error with quantity. Any hints on how to solve it?

[alik604]

@notAmine Sorry I don't have any, if you figure it out please post it

[Zechtitus]

Also stuck on same issue... I've looked at the network trace and I don't see it missing anything. Any updates?

[Zechtitus]

added comment to PR - #11

issue was the internal requests wasn't sending the data properly.

[ahmedsakr]

https://github.com/ahmedsakr/wstrade-api/blob/main/src/orders/submit.js#L39

I've had all orders types supported for quite some time. You can use that as a reference for supporting it with this library :)

[alik604]

See this for fix. I haven't tested, I ended this adventure after my last comment.