-
Notifications
You must be signed in to change notification settings - Fork 0
Open
Description
Kudos! Well done! 👏
I know you haven't implemented it in "production ready" coding mode, but here's a few notes to acknowledge:
- When applying
margin,padding(any spacing basically), it should be done on the higher-level container/wrapper rather than the first/last child inside this container. for instance have a10pxspacing on the.main-rightrather than the.menu-textlabel element would make more sense and support possible future changes - the idea of dividing the higher-level layout (header or body) by percentages could be problematic when changing screen size/layout shifts and will most probably make some areas non-responsive.
this could be solved by lettingflexdo it's magic, for example the main container could be separated into:
left side (nav) -250px; middle (feed) - fill; right side (contacts) -250px
so it will stretch according to screen size, you could do that by giving the middle container{flex-grow: 1}. same applies for the header of course - some of the rules/attributes aren't applied at all or being overridden by other rules, consider removing them
- separating the styles into different sections is a step in the right direction, however separating into multiple files can make the code even more organized and easy to navigate in
- let the content of an element determine the dimensions, and avoid using
height,widthunless necessary. if you want to expand/shrink a specific element, prefer usingpadding/margin(again, if possible of course)
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels