Health smoke sync & further simplified Ping using Mirror's rtt

Author: scscgit

Assets/Game/Scripts/Network/GameNetworkPlayer.cs

@@ -24,7 +24,7 @@ public class GameNetworkPlayer : NetworkBehaviour
 
         [Header("Synced vars")] [SyncVar] public string playerName;
         [SyncVar] public int score;
-        [SyncVar] public float health;
+        [SyncVar(hook = nameof(OnSyncHealth))] public float health;
 
         private NetworkIdentity _identity;
         private ArenaUi _arenaUi;
@@ -229,6 +229,15 @@ public void SetHealth(float setHealth)
             RpcDisplayHealth(setHealth);
         }
 
+        private void OnSyncHealth(float oldHealth, float newHealth)
+        {
+            //  Hook gets invoked before Start configures _vehiclePhysics
+            if (!ReferenceEquals(_vehiclePhysics, null))
+            {
+                _vehiclePhysics.health = newHealth;
+            }
+        }
+
         [ClientRpc]
         public void RpcDisplayScore(int displayScore)
         {

Assets/Game/Scripts/UI/Ping.cs

@@ -1,14 +1,10 @@
-using System;
 using UnityEngine;
 using Mirror;
 using UnityEngine.UI;
 
 public class Ping : NetworkBehaviour
 {
     public Text pingText;
-    [Range(0, 10)] public float intervalByServer = 0.5f;
-    public float ping;
-    private float _lastSync;
 
     private void Start()
     {
@@ -17,17 +13,6 @@ private void Start()
 
     void Update()
     {
-        if (isServer && Time.time - _lastSync > intervalByServer)
-        {
-            _lastSync = Time.time;
-            RpcReceivePacket(DateTimeOffset.UtcNow.ToUnixTimeMilliseconds());
-        }
-    }
-
-    [ClientRpc]
-    public void RpcReceivePacket(long unixTimeMillis)
-    {
-        ping = DateTimeOffset.UtcNow.ToUnixTimeMilliseconds() - unixTimeMillis;
-        pingText.text = $"Ping : {ping}ms";
+        pingText.text = $"Ping : {(int) (NetworkTime.rtt * 1000 / 2)}ms";
     }
 }