Skip to content
This repository was archived by the owner on Jun 19, 2024. It is now read-only.

Latest commit

 

History

History
68 lines (48 loc) · 2.62 KB

File metadata and controls

68 lines (48 loc) · 2.62 KB

Bugs

The following bugs are fixed in this fork of nicstat.

Bug #1 - Utilization with 10GbE nics on RHEL is incorrect

This fixes http://sourceforge.net/p/nicstat/bugs/1/ by applying the patch provided by Darren in that that bug report.

This bug occurs due to an integer overflow for 10Gb interfaces and is not specific to RHEL.

Bug #3 - -S option ignored if SIOCETHTOOL succeeds

This fixes http://sourceforge.net/p/nicstat/bugs/3/ by applying the patch I provided in that that bug report.

This patch may not be ideal, and should be revisited for completeness, but does resolve the issue for me.

Bug #4 - Utilization always computed as half duplex

This fixes http://sourceforge.net/p/nicstat/bugs/4/ by applying the patch I provided in that that bug report.

When utilization is calculated, nicp->duplex checks for the value of "2" for a full duplex link, but on Linux this value is "1" (see /usr/include/linux/ethtool.h). Fix is to use DUPLEX_FULL #define.

Bug #5 - Remove unnecessary #ifdef block

This fixes http://sourceforge.net/p/nicstat/bugs/5/ by applying the patch I provided in that that bug report.

An #ifdef for linux vs solaris is not needed as the DUPLEX_ #defines can be used consistently instead.

Bug #6 - UDP stats scanf has too many arguments

This fixes http://sourceforge.net/p/nicstat/bugs/6/ by applying the patch I provided in that that bug report.

There were too many arguments to fscanf(), resulting in the following warning when compiling with -Wall:

nicstat.c: In function ‘load_snmp’: nicstat.c:1569:8: warning: too many arguments for format [-Wformat-extra-args]

Bug #7 - Remove unused variables

This fixes http://sourceforge.net/p/nicstat/bugs/7/ by applying the patch I provided in that that bug report.

There are two unused variables in Linux (one is used only for solaris, the other used nowhere), found when compiling with -Wall.