Skip to content

Push.js not found if not configured and logged in as admin + another issue #128

@valeriansaliou

Description

@valeriansaliou

Hello there!

Thanks for Schnack, using it for my own Ghost blog. If it didn't exist I would have built it the same way, super happy you did it!

Just a quick issue report to let you know that, in my case I didn't configure web-push, and when I'm logged in as an admin there's a 404 to push.js which is still requested. Not happening for anonymous sessions AFAIK.

As well, another quick bug, I'm using the sendmail notifier, and the direct link to the comment in the email notifications is dangling, eg: Permalink: https://journal.valeriansaliou.name/announcing-sonic-a-super-light-alternative-to-elasticsearch/#comment-undefined (it's not passing the comment ID, but rather undefined).

Thanks for all!

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions