CMA phpbrew installation

[aleksandrsm]

Describe the bug

If CMA, when being installed for the first time, is interrupted during phpbrew setup(for any reason), it will result in non-working phpbrew + it will not recover on startup.

Environment

Ubuntu

Steps to reproduce

1. Fresh npm run installation on a system on no phpbrew
2. Pressing ctrl+c in the middle of brew install will do it. This leaves the system with half-installed brew; e.g. no specific php version installed.
3. After that, on re-run npm will not attempt to install specific phpbrew versions despite them not being present.

Not confirmed - but this might happen if some Y prompt are not triggered during the install (e.g. for bashrc?).

Manually removing phphbrew from the system entirely resolves the issue.

Expected behavior

Hard to say what is expected in this case, if CMA could somehow detect non-functional brew and re-install it, that would help.
If not, then perhaps just a text message to consider reinstalling phpbrew, if there's issues with it during startup?

[ejnshtein]

I have no idea how to verify phpbrew installation when it's broken and I don't see an error message here.

Also, why would you cancel installation in the middle of the process?

[aleksandrsm]

Yeah, hard to figure out. I guess checking if desired version of PHP is installed, might work?

As for why...well, two juniors did in last month that I know of, so I assume that's their intuitive response to the long compilation time.

[ejnshtein]

CMA already checks phpbrew version when it starts up. All I can offer is to change task title to tell user that installation is still working and that they should not terminate it.

[aleksandrsm]

That'd help, let's see how that goes. Thanks!

[ejnshtein]

I guess this will be obsolete when #107 will be released