diff --git a/Github test.xcodeproj/project.pbxproj b/Github test.xcodeproj/project.pbxproj
index b838600..796c568 100644
--- a/Github test.xcodeproj/project.pbxproj
+++ b/Github test.xcodeproj/project.pbxproj
@@ -411,7 +411,7 @@
buildSettings = {
ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon;
CODE_SIGN_STYLE = Automatic;
- DEVELOPMENT_TEAM = 8N949X2SJZ;
+ DEVELOPMENT_TEAM = L967JD2LSG;
INFOPLIST_FILE = "Github test/Info.plist";
LD_RUNPATH_SEARCH_PATHS = (
"$(inherited)",
@@ -429,7 +429,7 @@
buildSettings = {
ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon;
CODE_SIGN_STYLE = Automatic;
- DEVELOPMENT_TEAM = 8N949X2SJZ;
+ DEVELOPMENT_TEAM = L967JD2LSG;
INFOPLIST_FILE = "Github test/Info.plist";
LD_RUNPATH_SEARCH_PATHS = (
"$(inherited)",
diff --git a/Github test.xcodeproj/project.xcworkspace/xcuserdata/maximt.xcuserdatad/UserInterfaceState.xcuserstate b/Github test.xcodeproj/project.xcworkspace/xcuserdata/maximt.xcuserdatad/UserInterfaceState.xcuserstate
new file mode 100644
index 0000000..83a9077
Binary files /dev/null and b/Github test.xcodeproj/project.xcworkspace/xcuserdata/maximt.xcuserdatad/UserInterfaceState.xcuserstate differ
diff --git a/Github test.xcodeproj/xcuserdata/maximt.xcuserdatad/xcdebugger/Breakpoints_v2.xcbkptlist b/Github test.xcodeproj/xcuserdata/maximt.xcuserdatad/xcdebugger/Breakpoints_v2.xcbkptlist
new file mode 100644
index 0000000..51da659
--- /dev/null
+++ b/Github test.xcodeproj/xcuserdata/maximt.xcuserdatad/xcdebugger/Breakpoints_v2.xcbkptlist
@@ -0,0 +1,55 @@
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
diff --git a/Github test/Base.lproj/Main.storyboard b/Github test/Base.lproj/Main.storyboard
index 9f9c49d..120741b 100644
--- a/Github test/Base.lproj/Main.storyboard
+++ b/Github test/Base.lproj/Main.storyboard
@@ -1,10 +1,10 @@
-
+
-
+
@@ -100,11 +100,11 @@
-
+
-
+
@@ -119,8 +119,8 @@
-
-
+
+
@@ -131,12 +131,12 @@
-
-
+
@@ -355,11 +355,11 @@
-
+
-
+
@@ -491,7 +491,7 @@
-
+
@@ -579,11 +579,12 @@
+
-
+
@@ -605,4 +606,7 @@
+
+
+
diff --git a/Github test/Controllers/AuthenticationViewController.swift b/Github test/Controllers/AuthenticationViewController.swift
index 8b51e3f..d482196 100644
--- a/Github test/Controllers/AuthenticationViewController.swift
+++ b/Github test/Controllers/AuthenticationViewController.swift
@@ -66,6 +66,9 @@ class AuthenticationViewController: UIViewController {
}
override func prepare(for segue: UIStoryboardSegue, sender: Any?) {
+
+
+ // MARK: - Remark. I'm not sure about 'fatalError'. Maybe there is can be better way than fatalError
guard let token = sender as? String,
let profileVC = segue.destination as? ProfileViewController else { fatalError() }
profileVC.token = token
diff --git a/Github test/Controllers/ProfileViewController.swift b/Github test/Controllers/ProfileViewController.swift
index 291d232..a08c5a2 100644
--- a/Github test/Controllers/ProfileViewController.swift
+++ b/Github test/Controllers/ProfileViewController.swift
@@ -61,6 +61,9 @@ class ProfileViewController: UIViewController {
startAnimatingIndicators()
githubAPIService.getUser { [weak self] user, error in
+
+ // error valueNotFound --> Issue #1
+
if let error = error as? HTTPClient.NetworkError {
if error == .badStatusCode {
(self?.navigationController as? NavigationController)?.showAuth()
diff --git a/Github test/Networking/HTTPClient.swift b/Github test/Networking/HTTPClient.swift
index 95e8a56..2125281 100644
--- a/Github test/Networking/HTTPClient.swift
+++ b/Github test/Networking/HTTPClient.swift
@@ -46,6 +46,9 @@ class HTTPClient {
queryItems: [URLQueryItem]?,
headers: [String: String]?,
completionHandler: @escaping CompletionHandler) {
+
+
+
var urlComponnents = URLComponents(url: baseURL, resolvingAgainstBaseURL: false)
urlComponnents?.path = path
urlComponnents?.queryItems = queryItems
diff --git a/Issues/1.mov b/Issues/1.mov
new file mode 100644
index 0000000..159220c
Binary files /dev/null and b/Issues/1.mov differ
diff --git a/Issues/2.png b/Issues/2.png
new file mode 100644
index 0000000..4c862a2
Binary files /dev/null and b/Issues/2.png differ
diff --git a/Issues/3.MP4 b/Issues/3.MP4
new file mode 100644
index 0000000..f6837b5
Binary files /dev/null and b/Issues/3.MP4 differ
diff --git a/Issues/README.md b/Issues/README.md
new file mode 100755
index 0000000..79bb688
--- /dev/null
+++ b/Issues/README.md
@@ -0,0 +1,8 @@
+# Issues
+1. Autologin stuck in inifine loading. (1.mov)
+2. Progress hud didn't prevent changing tabs. (1.mov)
+3. App crashing when user select "edit" button while progress hud display (1.mov)
+4. Broken UI on iPhone X (2.png)
+
+NOTE: Issues 1 - 3 approved on real device(iPhone 6).
+ Please see 3.mp4