Skip to content

Mandatory exiftools #13

@olegykz

Description

@olegykz

Project README states that exiftools is required for the functionality of changing PDF metadata, but turned out that it's always required if source HTML contains title tag:

meta(extract_metadata_from_body(compiler.body))

it might be inconvenient for the cases when consumer don't care about the metadata, and, additionaly might require additional setup for the environments like Heroku (additional buildpack, etc)

What if we make metadata extraction optional, something like

      def html index, extract_metadata: true
        compiler = Compiler.new(index)

        meta(extract_metadata_from_body(compiler.body)) if extract_metadata

        files << multipart_file(compiler.body, 'index.html', 'text/html')

        assets *compiler.assets

        @endpoint = '/forms/chromium/convert/html'

        self
      end

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions