-
Notifications
You must be signed in to change notification settings - Fork 8
Description
User story
As a PSD developer (@yoldas), I would like the submission status card to show the submission (template) name after workflow selection (automatic submission by button click) so that users can see the submission status by name and which branch is activated. Currently, the list shows the submission status and concatanated submission ID and study name(s),
Who are the primary contacts for this story
@yoldas
@KatyTaylor
Scott G
Who is the nominated tester for UAT
Scott G
Acceptance criteria
Consider if these features can be featured flagged to decouple testing and deployment.
To be considered successful the solution must allow:
- submission (template) names are included in status card after workflow selections in Limber
- Integration suite tests are updated where submission statuses are checked if necessary
Dependencies
This story is blocked by the following dependencies:
- #<issue_no.>
- sanger/#<issue_no.>
References
This story has a non-blocking relationship with:
- Y24-268 - Create a presenter for automated submission for WGS branch on Adp Lig plate sequencescape#4290
- Y26-004 - LCM Triomics - choose workflow (EMSeq & RNASeq) #2665
Additional context
Example (current) screenshots from LCM Triomics EMSeq+WGS branch on LCMT DNA Adp Lig page.
Workflow selection:
Pending submission:
Ready submission:
currently shown submission ID and study name(s)
Currently, submission name used by Limber is returned as concat of ID and study names from API end point.
See the following code:
Limber ERB partials
- app/views/application/_submission_item.html.erb which is included by
- app/views/plates/_pending_submissions.html.erb
- app/views/tubes/_pending_submissions.html.erb
Presenter call on labware.direct_submissions on Sequencescape side
- name method in app/models/submission.rb
- direct_submissions association on app/models/labware.rb
- app/resources/api/v2/submission_resource.rb
Example integration test breakpoint
Before click_on 'WGS Branch - Automated Submission' in spec/limber/lcm_triomics_spec.rb
Options to implement the change
One way to extract the submission template name can be extracting from orders. For example
submission.orders[0].template_name
"Limber-Htp - LCM Triomics WGS"
- Modify the name returned by the endpoint to include the submission template name or
- Add a new field submission template name to be added to the endpoint response (which isolates the change)
Update Limber partial app/views/application/_submission_item.html.erb to use the name.
Deployment notes
Add any details that should be noted when deploying this feature. For example, is a database migration needed, a specifc rake task or other script that needs to be run, a dependency on another application or service that needs to be released first etc?
These notes are intended to ensure the developers releasing the feature know what needs to be done.
Add any other context or screenshots about the feature request here.