Skip to content
This repository was archived by the owner on Jun 18, 2025. It is now read-only.
This repository was archived by the owner on Jun 18, 2025. It is now read-only.

DPL-nnn Possible redundant fact creation in actions.rb #183

@JamesGlover

Description

@JamesGlover

Describe the Housekeeping

When running some of the rubocop auto-fixes, I noticed this:
https://github.com/sanger/samples_extraction/blob/f2d8d3ebc9658bbcb64128402014dd5db7b08193/app/models/action.rb#L86-L90

The yielded asset is unused, and instead assets gets passed into `each_connected_asset. This will need to be evaluated to make sure we aren't creating asset*asset facts unnecessarily. It can then either be fixed, or annotated with a clear explanation.

Blocking issues
Describe any other issues or tickets that may be blocking this change.

Additional context
Add any other context about the problem here.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions