From 8b40c7b6467e62eceab321f4c6f80e5386bf2c3b Mon Sep 17 00:00:00 2001 From: Brandon Harvey Date: Tue, 24 Feb 2026 10:50:56 -0800 Subject: [PATCH] plan: add task for --since validation Add an ergo task to close the future --since validation gap. Why: remote --since rejection and missing pool errors are currently skipped. How: task calls for validating target and constraints before early exit. Acceptance criteria cover remote/local follow/duplex behavior. Preserves existing success exit for future --since on valid local pools. Validation gates: cargo fmt --all, cargo clippy --all-targets, just ci-fast. Constraints: keep CLI error messaging/hints aligned with existing helpers. Risks/tests: verify remote --since rejection still fires after refactor. --- .ergo/events.jsonl | 1 + 1 file changed, 1 insertion(+) diff --git a/.ergo/events.jsonl b/.ergo/events.jsonl index 1f41627..5ac8077 100644 --- a/.ergo/events.jsonl +++ b/.ergo/events.jsonl @@ -3365,3 +3365,4 @@ {"type":"state","ts":"2026-02-18T23:39:32.045309Z","data":{"id":"MUVZDJ","state":"done","ts":"2026-02-18T23:39:32.045309Z"}} {"type":"state","ts":"2026-02-18T23:39:32.081186Z","data":{"id":"43GKYB","state":"done","ts":"2026-02-18T23:39:32.081186Z"}} {"type":"new_task","ts":"2026-02-24T00:40:18.745182Z","data":{"id":"M5AALK","uuid":"3f43f787-64b2-40ec-8d60-385ffdd61f8a","epic_id":"","state":"todo","title":"docs/spec: note remote duplex --since rejection","body":"## Goal\n- Update the duplex spec to reflect that remote `POOLREF` rejects `--since`, matching CLI behavior and help text.\n- Ensure readers understand that `--since` only applies to local duplex refs.\n\n## Background/Rationale\n- `plasmite duplex` now returns a usage error for remote `--since`, but `spec/v0/SPEC.md` only documents remote `--create` rejection. This is a doc/behavior mismatch.\n\n## Acceptance Criteria\n- `spec/v0/SPEC.md` explicitly states that remote duplex refs reject `--since` (with guidance to use `--tail` or local refs).\n- The options section and/or remote-ref behavior notes are updated to avoid implying `--since` works remotely.\n- No other CLI semantics are changed.\n\n## Validation Gates\n- `just ci-fast`\n","created_at":"2026-02-24T00:40:18.745182Z"}} +{"type":"new_task","ts":"2026-02-24T18:50:23.03308Z","data":{"id":"MYWYFH","uuid":"7fb14155-7f20-4b95-b2e0-02af65d9d052","epic_id":"","state":"todo","title":"cli: validate targets before --since future exit","body":"## Goal\n- Ensure --since future checks do not bypass pool validation or remote restrictions.\n\n## Background\n- command_dispatch.rs returns early when since \u003e now before resolving the pool target.\n- This means remote refs with --since can exit 0 without the required usage error, and missing local pools are not reported.\n\n## Acceptance Criteria\n- `plasmite follow http://host/pool --since \u003cfuture\u003e` returns the same usage error as any remote --since.\n- `plasmite duplex http://host/pool --since \u003cfuture\u003e` returns the same usage error as any remote --since.\n- `plasmite follow missing --since \u003cfuture\u003e` reports NotFound with the usual missing-pool hint.\n- `plasmite duplex missing --since \u003cfuture\u003e` reports NotFound with the usual missing-pool hint.\n- For existing local pools, `--since` in the future still exits 0 with no output.\n\n## Validation Gates\n- cargo fmt --all\n- cargo clippy --all-targets -- -D warnings\n- just ci-fast\n","created_at":"2026-02-24T18:50:23.03308Z"}}