From 55cb1a90612fd7485da6e9e5764bb28f76f36ee1 Mon Sep 17 00:00:00 2001 From: Brandon Harvey Date: Thu, 26 Feb 2026 11:15:45 -0800 Subject: [PATCH] plan(cli): add --since validation task on plans log Recreate the stale planning PR on top of current main after the .ergo events-to-plans log migration. Record task A5UGZS in .ergo/plans.jsonl instead of .ergo/events.jsonl. Preserve the same goal, acceptance criteria, and validation gates for future --since behavior across local and remote target resolution. No runtime code changes are included in this commit. This keeps planning state mergeable with the current repository layout. --- .ergo/plans.jsonl | 1 + 1 file changed, 1 insertion(+) diff --git a/.ergo/plans.jsonl b/.ergo/plans.jsonl index add3499..d89a3de 100644 --- a/.ergo/plans.jsonl +++ b/.ergo/plans.jsonl @@ -3501,3 +3501,4 @@ {"type":"result","ts":"2026-02-25T22:52:33.245514Z","data":{"task_id":"UMCU3R","summary":"Backfill actionable hints for hint-less Internal CLI errors","path":"src/main.rs","sha256_at_attach":"8eb075b555bf21e1c89fb32769c372444b039e6c1fd07ff0fdfb178e4620959d","mtime_at_attach":"2026-02-25T22:50:43.149382621Z","git_commit_at_attach":"3f34847dfa4e12c81c1885e43768df676f559830","ts":"2026-02-25T22:52:33.245514Z"}} {"type":"body","ts":"2026-02-25T22:52:33.275686Z","data":{"id":"UMCU3R","body":"## Evidence\n- `src/command_dispatch.rs:117-123` constructs `ErrorKind::Internal` for runtime startup failure without `.with_hint(...)`.\n- `src/main.rs:125-127` only auto-applies hint enrichers for Corrupt/Io/Permission/Busy (`add_corrupt_hint` + `add_io_hint`).\n- `src/main.rs:2327-2362` renders a hint only if one already exists on the error.\n\n## Violated property\n- `docs/record/vision.md` operational clarity expectation (CLI errors should provide actionable remediation guidance).\n\n## Suggested fix\n- Add a final CLI-side hint enrichment pass for `ErrorKind::Internal` (and any remaining no-hint public kinds), or require all public constructors to supply a hint/doc reference.\n- Keep existing explicit hints as highest-priority and only backfill when missing.\n\n\n\n## Completion Note\n- Added a final CLI error enrichment pass (`add_internal_hint`) in `src/main.rs` run pipeline.\n- Internal errors without explicit hints now receive actionable remediation guidance while preserving existing explicit hints as higher priority.\n- This ensures JSON and human stderr surfaces consistently include hints for previously uncovered internal failure paths.\n","ts":"2026-02-25T22:52:33.275686Z"}} {"type":"state","ts":"2026-02-25T22:52:33.275686Z","data":{"id":"UMCU3R","state":"done","ts":"2026-02-25T22:52:33.275686Z"}} +{"type":"new_task","ts":"2026-02-26T19:15:26.681695Z","data":{"id":"A5UGZS","uuid":"82fd4f33-2b7d-4e5e-acd1-9c2ed06a604d","epic_id":"","state":"todo","title":"cli: validate targets before --since future exit","body":"## Goal\n- Ensure --since future checks do not bypass pool validation or remote restrictions.\n\n## Background/Rationale\n- `command_dispatch.rs` can return early when `--since` is in the future before resolving the pool target.\n- This can let remote refs with `--since` exit 0 without the required usage error, and missing local pools are not reported.\n\n## Acceptance Criteria\n- `plasmite follow http://host/pool --since \u003cfuture\u003e` returns the same usage error as any remote `--since`.\n- `plasmite duplex http://host/pool --since \u003cfuture\u003e` returns the same usage error as any remote `--since`.\n- `plasmite follow missing --since \u003cfuture\u003e` reports NotFound with the usual missing-pool hint.\n- `plasmite duplex missing --since \u003cfuture\u003e` reports NotFound with the usual missing-pool hint.\n- For existing local pools, `--since` in the future still exits 0 with no output.\n\n## Validation Gates\n- `cargo fmt --all`\n- `cargo clippy --all-targets -- -D warnings`\n- `just ci-fast`\n","created_at":"2026-02-26T19:15:26.681695Z"}}