Skip to content

Switch kwargs to function parameters #42

@jmgate

Description

@jmgate

INSERT DETAILS HERE.

In extending ShellLogger into the more powerful version of itself, **kwargs were used in a number of places to allow for ease of extensibility. As we get closer to open-sourcing, we should re-evaluate each of these usages to see if there are any keyword arguments that should be spelled out explicitly as function parameters. Past experience indicates spelling out everything explicitly hugely improves maintainability, but we definitely didn't take time initially to think through what exactly we wanted all the interfaces to look like. Yay for agile development 😁

  • What needs to be cleaned up?
  • How would the refactored implementation differ from what we have now?
  • What are the potential downsides to not dealing with the technical debt now and leaving it for later?

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type: RefactorRefactoring existing code to improve long-term sustainability.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions