diff --git a/plugin/jslint/fulljslint.js b/plugin/jslint/fulljslint.js index d62a962..a96a459 100644 --- a/plugin/jslint/fulljslint.js +++ b/plugin/jslint/fulljslint.js @@ -1,6 +1,5 @@ // jslint.js -// 2008-12-11 - +// 2011-01-06 /* Copyright (c) 2002 Douglas Crockford (www.JSLint.com) @@ -34,11 +33,14 @@ SOFTWARE. The first parameter is either a string or an array of strings. If it is a string, it will be split on '\n' or '\r'. If it is an array of strings, it is assumed that each string represents one line. The source can be a - JavaScript text, or HTML text, or a Konfabulator text. + JavaScript text, or HTML text, or a JSON text, or a CSS text. The second parameter is an optional object of options which control the - operation of JSLINT. Most of the options are booleans: They are all are - optional and have a default value of false. + operation of JSLINT. Most of the options are booleans: They are all + optional and have a default value of false. One of the options, predef, + can be an array of names, which will be used to declare global variables, + or an object whose keys are used as global names, with a boolean value + that determines if they are assignable. If it checks out, JSLINT returns true. Otherwise, it returns false. @@ -68,146 +70,247 @@ SOFTWARE. var myReport = JSLINT.report(limited); If limited is true, then the report will be limited to only errors. + + You can request a data structure which contains JSLint's results. + + var myData = JSLINT.data(); + + It returns a structure with this form: + + { + errors: [ + { + line: NUMBER, + character: NUMBER, + reason: STRING, + evidence: STRING + } + ], + functions: [ + name: STRING, + line: NUMBER, + last: NUMBER, + param: [ + STRING + ], + closure: [ + STRING + ], + var: [ + STRING + ], + exception: [ + STRING + ], + outer: [ + STRING + ], + unused: [ + STRING + ], + global: [ + STRING + ], + label: [ + STRING + ] + ], + globals: [ + STRING + ], + member: { + STRING: NUMBER + }, + unuseds: [ + { + name: STRING, + line: NUMBER + } + ], + implieds: [ + { + name: STRING, + line: NUMBER + } + ], + urls: [ + STRING + ], + json: BOOLEAN + } + + Empty arrays will not be included. + + You can obtain the parse tree that JSLint constructed while parsing. The + latest tree is kept in JSLINT.tree. A nice stringication can be produced + with + + JSON.stringify(JSON.tree, [ + 'value', 'arity', 'name', 'first', + 'second', 'third', 'block', 'else' + ], 4)); + +*/ + +/*jslint + evil: true, nomen: false, onevar: false, regexp: false, strict: true */ -/*jslint evil: true, nomen: false, onevar: false */ - -/*global JSLINT*/ - -/*members "\b", "\t", "\n", "\f", "\r", "\"", "%", "(begin)", - "(breakage)", "(context)", "(global)", "(identifier)", "(line)", - "(loopage)", "(name)", "(onevar)", "(params)", "(scope)", "(verb)", ")", - "++", "--", "\/", ADSAFE, Array, Boolean, COM, Canvas, CustomAnimation, - Date, Debug, E, Error, EvalError, FadeAnimation, FormField, Frame, - Function, HotKey, Image, JSON, LN10, LN2, LOG10E, LOG2E, MAX_VALUE, - MIN_VALUE, Math, MenuItem, MoveAnimation, NEGATIVE_INFINITY, Number, - Object, Option, PI, POSITIVE_INFINITY, Point, RangeError, - ReferenceError, RegExp, ResizeAnimation, RotateAnimation, SQRT1_2, - SQRT2, ScrollBar, String, SyntaxError, System, Text, TextArea, Timer, - TypeError, URIError, URL, Window, XMLDOM, XMLHttpRequest, "\\", "]", a, - abbr, acronym, active, address, adsafe, after, alert, aliceblue, - animator, antiquewhite, appleScript, applet, apply, approved, aqua, - aquamarine, area, arguments, arity, autocomplete, azure, b, background, - "background-attachment", "background-color", "background-image", - "background-position", "background-repeat", base, bdo, beep, before, - beige, big, bisque, bitwise, black, blanchedalmond, block, blockquote, - blue, blueviolet, blur, body, border, "border-bottom", +/*members "\b", "\t", "\n", "\f", "\r", "!=", "!==", "\"", "'", "%", + "(begin)", "(breakage)", "(context)", "(end)", "(error)", "(global)", + "(identifier)", "(last)", "(line)", "(loopage)", "(name)", "(onevar)", + "(params)", "(scope)", "(statement)", "(token)", "(verb)", "*", "+", "++", "-", + "--", "\/", "<", "<=", "", "==", "===", ">", ">=", + ADSAFE, ActiveXObject, Array, Boolean, COM, CScript, Canvas, + CustomAnimation, Date, Debug, E, Enumerator, Error, EvalError, + FadeAnimation, Flash, FormField, Frame, Function, HotKey, Image, JSON, + LN10, LN2, LOG10E, LOG2E, MAX_VALUE, MIN_VALUE, Math, MenuItem, + MoveAnimation, NEGATIVE_INFINITY, Number, Object, Option, PI, + POSITIVE_INFINITY, Point, RangeError, Rectangle, ReferenceError, RegExp, + ResizeAnimation, RotateAnimation, SQRT1_2, SQRT2, ScrollBar, String, + Style, SyntaxError, System, Text, TextArea, Timer, TypeError, URIError, + URL, VBArray, WScript, Web, Window, XMLDOM, XMLHttpRequest, "\\", a, + abbr, acronym, activeborder, activecaption, addEventListener, address, + adsafe, alert, aliceblue, all, animator, antiquewhite, appleScript, + applet, apply, approved, appworkspace, aqua, aquamarine, area, + arguments, arity, article, aside, assign, audio, autocomplete, azure, b, + background, "background-attachment", "background-color", + "background-image", "background-position", "background-repeat", base, + bdo, beep, beige, big, bisque, bitwise, black, blanchedalmond, block, + blockquote, blue, blueviolet, blur, body, border, "border-bottom", "border-bottom-color", "border-bottom-style", "border-bottom-width", "border-collapse", "border-color", "border-left", "border-left-color", "border-left-style", "border-left-width", "border-right", "border-right-color", "border-right-style", "border-right-width", "border-spacing", "border-style", "border-top", "border-top-color", "border-top-style", "border-top-width", "border-width", bottom, br, - brown, browser, burlywood, button, bytesToUIString, c, cadetblue, call, - callee, caller, canvas, cap, caption, "caption-side", cases, center, - charAt, charCodeAt, character, chartreuse, chocolate, chooseColor, - chooseFile, chooseFolder, cite, clear, clearInterval, clearTimeout, - clip, close, closeWidget, closed, cm, code, col, colgroup, color, - comment, condition, confirm, console, constructor, content, - convertPathToHFS, convertPathToPlatform, coral, cornflowerblue, + braille, brown, browser, burlywood, button, buttonface, buttonhighlight, + buttonshadow, buttontext, bytesToUIString, c, cadetblue, call, callee, + caller, canvas, cap, caption, "caption-side", captiontext, case, catch, + center, charAt, charCodeAt, character, chartreuse, chocolate, + chooseColor, chooseFile, chooseFolder, cite, clear, clearInterval, + clearTimeout, clip, close, closeWidget, closed, closure, cm, code, col, + colgroup, color, command, comment, confirm, console, constructor, + content, convertPathToHFS, convertPathToPlatform, coral, cornflowerblue, cornsilk, "counter-increment", "counter-reset", create, crimson, css, cursor, cyan, d, darkblue, darkcyan, darkgoldenrod, darkgray, darkgreen, darkkhaki, darkmagenta, darkolivegreen, darkorange, darkorchid, darkred, darksalmon, darkseagreen, darkslateblue, darkslategray, darkturquoise, - darkviolet, dd, debug, decodeURI, decodeURIComponent, deeppink, - deepskyblue, defaultStatus, defineClass, del, deserialize, dfn, dimgray, - dir, direction, display, div, dl, document, dodgerblue, dt, else, em, - embed, empty, "empty-cells", encodeURI, encodeURIComponent, entityify, - eqeqeq, errors, escape, eval, event, evidence, evil, ex, exec, exps, - fieldset, filesystem, firebrick, first, "first-child", "first-letter", - "first-line", float, floor, floralwhite, focus, focusWidget, font, - "font-face", "font-family", "font-size", "font-size-adjust", - "font-stretch", "font-style", "font-variant", "font-weight", - forestgreen, forin, form, fragment, frame, frames, frameset, from, - fromCharCode, fuchsia, fud, function, g, gainsboro, gc, - getComputedStyle, ghostwhite, gold, goldenrod, gray, green, greenyellow, - h1, h2, h3, h4, h5, h6, hasOwnProperty, head, height, help, history, - honeydew, hotpink, hover, hr, html, i, iTunes, id, identifier, iframe, - img, import, in, include, indent, indexOf, indianred, indigo, init, - input, ins, isAlpha, isApplicationRunning, isDigit, isFinite, isNaN, - ivory, join, kbd, khaki, konfabulatorVersion, label, labelled, lang, - lavender, lavenderblush, lawngreen, laxbreak, lbp, led, left, legend, - lemonchiffon, length, "letter-spacing", li, lightblue, lightcoral, - lightcyan, lightgoldenrodyellow, lightgreen, lightpink, lightsalmon, - lightseagreen, lightskyblue, lightslategray, lightsteelblue, - lightyellow, lime, limegreen, line, "line-height", linen, link, - "list-style", "list-style-image", "list-style-position", - "list-style-type", load, loadClass, location, log, m, magenta, map, - margin, "margin-bottom", "margin-left", "margin-right", "margin-top", - "marker-offset", maroon, match, "max-height", "max-width", media, + darkviolet, data, datalist, dd, debug, decodeURI, decodeURIComponent, + deeppink, deepskyblue, default, defaultStatus, defineClass, del, + deserialize, details, devel, dfn, dialog, dimgray, dir, direction, + display, disrupt, div, dl, do, document, dodgerblue, + dt, edition, else, em, embed, embossed, empty, "empty-cells", encodeURI, + encodeURIComponent, entityify, errors, es5, escape, eval, event, + evidence, evil, ex, exception, exec, fieldset, figure, filesystem, + finally, firebrick, first, float, floor, floralwhite, focus, + focusWidget, font, "font-family", "font-size", "font-size-adjust", + "font-stretch", "font-style", "font-variant", "font-weight", footer, + for, forestgreen, forin, form, fragment, frame, frames, frameset, from, + fromCharCode, fuchsia, fud, funct, function, functions, g, gainsboro, + gc, getComputedStyle, ghostwhite, global, globals, gold, goldenrod, + gray, graytext, green, greenyellow, h1, h2, h3, h4, h5, h6, handheld, + hasOwnProperty, head, header, height, help, hgroup, highlight, + highlighttext, history, honeydew, hotpink, hr, "hta:application", html, + i, iTunes, id, identifier, iframe, img, immed, implieds, in, + inactiveborder, inactivecaption, inactivecaptiontext, include, indent, + indexOf, indianred, indigo, infobackground, infotext, init, initial, + input, ins, isAlpha, isApplicationRunning, isArray, isDigit, isFinite, + isNaN, ivory, join, jslint, json, kbd, keygen, keys, khaki, + konfabulatorVersion, label, lang, last, lavender, lavenderblush, + lawngreen, lbp, led, left, legend, lemonchiffon, length, + "letter-spacing", li, lib, lightblue, lightcoral, lightcyan, + lightgoldenrodyellow, lightgreen, lightpink, lightsalmon, lightseagreen, + lightskyblue, lightslategray, lightsteelblue, lightyellow, lime, + limegreen, line, "line-height", linen, link, "list-style", + "list-style-image", "list-style-position", "list-style-type", load, + loadClass, location, log, m, magenta, map, margin, "margin-bottom", + "margin-left", "margin-right", "margin-top", mark, "marker-offset", + maroon, match, "max-height", "max-width", maxerr, maxlen, md5, mediumaquamarine, mediumblue, mediumorchid, mediumpurple, mediumseagreen, mediumslateblue, mediumspringgreen, mediumturquoise, - mediumvioletred, menu, message, meta, midnightblue, "min-height", - "min-width", mintcream, mistyrose, mm, moccasin, moveBy, moveTo, name, - navajowhite, navigator, navy, new, newcap, noframes, nomen, noscript, - nud, object, ol, oldlace, olive, olivedrab, on, onblur, onerror, onevar, - onfocus, onload, onresize, onunload, opacity, open, openURL, opener, - opera, optgroup, option, orange, orangered, orchid, outer, outline, - "outline-color", "outline-style", "outline-width", overflow, p, padding, - "padding-bottom", "padding-left", "padding-right", "padding-top", page, + mediumvioletred, member, menu, menutext, message, meta, meter, + midnightblue, "min-height", "min-width", mintcream, mistyrose, mm, + moccasin, moveBy, moveTo, name, nav, navajowhite, navigator, navy, new, + newcap, noframes, nomen, noscript, nud, object, ol, oldlace, olive, + olivedrab, on, onbeforeunload, onblur, onerror, onevar, onfocus, onload, + onresize, onunload, opacity, open, openURL, opener, opera, optgroup, + option, orange, orangered, orchid, outer, outline, "outline-color", + "outline-style", "outline-width", output, overflow, "overflow-x", + "overflow-y", p, padding, "padding-bottom", "padding-left", + "padding-right", "padding-top", "page-break-after", "page-break-before", palegoldenrod, palegreen, paleturquoise, palevioletred, papayawhip, param, parent, parseFloat, parseInt, passfail, pc, peachpuff, peru, pink, play, plum, plusplus, pop, popupMenu, position, powderblue, pre, - predef, preferenceGroups, preferences, print, prompt, prototype, pt, - purple, push, px, q, quit, quotes, random, range, raw, reach, readFile, - readUrl, reason, red, regexp, reloadWidget, replace, report, reserved, - resizeBy, resizeTo, resolvePath, resumeUpdates, rhino, right, rosybrown, - royalblue, runCommand, runCommandInBg, saddlebrown, safe, salmon, samp, + predef, preferenceGroups, preferences, print, progress, projection, + prompt, prototype, pt, purple, push, px, q, quit, quotes, random, range, + raw, readFile, readUrl, reason, red, regexp, reloadWidget, + removeEventListener, replace, report, reserved, resizeBy, resizeTo, + resolvePath, resumeUpdates, rhino, right, rosybrown, royalblue, rp, rt, + ruby, runCommand, runCommandInBg, saddlebrown, safe, salmon, samp, sandybrown, saveAs, savePreferences, screen, script, scroll, scrollBy, - scrollTo, seagreen, seal, search, seashell, select, self, serialize, - setInterval, setTimeout, shift, showWidgetPreferences, sidebar, sienna, - silver, skyblue, slateblue, slategray, sleep, slice, small, snow, sort, - span, spawn, speak, split, springgreen, src, status, steelblue, strict, - strong, style, styleproperty, sub, substr, sup, supplant, - suppressUpdates, sync, system, table, "table-layout", tan, tbody, td, - teal, tellWidget, test, "text-align", "text-decoration", "text-indent", - "text-shadow", "text-transform", textarea, tfoot, th, thead, thistle, - title, toLowerCase, toString, toUpperCase, toint32, token, tomato, top, - tr, tt, turquoise, type, u, ul, undef, unescape, "unicode-bidi", union, - unwatch, updateNow, value, valueOf, var, version, "vertical-align", - violet, visibility, visited, watch, wheat, white, "white-space", - whitesmoke, widget, width, window, "word-spacing", yahooCheckLogin, - yahooLogin, yahooLogout, yellow, yellowgreen, "z-index" + scrollTo, scrollbar, seagreen, seal, search, seashell, second, section, + select, serialize, setInterval, setTimeout, shift, + showWidgetPreferences, sienna, silver, skyblue, slateblue, slategray, + sleep, slice, small, snow, sort, source, span, spawn, speak, speech, + split, springgreen, src, stack, status, steelblue, strict, strong, + style, styleproperty, sub, substr, sup, supplant, suppressUpdates, + switch, sync, system, table, "table-layout", tan, tbody, td, teal, + tellWidget, test, "text-align", "text-decoration", "text-indent", + "text-shadow", "text-transform", textarea, tfoot, th, thead, third, + thistle, threeddarkshadow, threedface, threedhighlight, + threedlightshadow, threedshadow, thru, time, title, toLowerCase, toString, + toUpperCase, toint32, token, tomato, top, tr, tree, tt, tty, turquoise, tv, + type, u, ul, undef, unescape, "unicode-bidi", unused, unwatch, + updateNow, urls, value, valueOf, var, version, "vertical-align", video, + violet, visibility, watch, wheat, while, white, "white-space", + whitesmoke, widget, width, window, windowframe, windows, windowtext, + "word-spacing", "word-wrap", yahooCheckLogin, yahooLogin, yahooLogout, + yellow, yellowgreen, "z-index", "}" */ // We build the application inside a function so that we produce only a single -// global variable. The function will be invoked, its return value is the JSLINT -// application itself. +// global variable. That function will be invoked immediately, and its return +// value is the JSLINT function itself. That function is also an object that +// can contain data and other functions. -"use strict"; +var JSLINT = (function () { + "use strict"; -JSLINT = function () { var adsafe_id, // The widget's ADsafe id. adsafe_may, // The widget may load approved scripts. adsafe_went, // ADSAFE.go has been called. anonname, // The guessed name for anonymous functions. approved, // ADsafe approved urls. - atrule = { - 'import' : true, - media : true, - 'font-face': true, - page : true - }, - - badbreak = { - ')': true, - ']': true, - '++': true, - '--': true +// These are operators that should not be used with the ! operator. + + bang = { + '<': true, + '<=': true, + '==': true, + '===': true, + '!==': true, + '!=': true, + '>': true, + '>=': true, + '+': true, + '-': true, + '*': true, + '/': true, + '%': true }, -// These are members that should not be permitted in third party ads. +// These are property names that should not be permitted in the safe subset. banned = { // the member names that ADsafe prohibits. - apply : true, 'arguments' : true, - call : true, callee : true, caller : true, constructor : true, 'eval' : true, prototype : true, + stack : true, unwatch : true, valueOf : true, watch : true @@ -223,11 +326,11 @@ JSLINT = function () { cap : true, // if upper case HTML should be allowed css : true, // if CSS workarounds should be tolerated debug : true, // if debugger statements should be allowed - eqeqeq : true, // if === should be required + devel : true, // if logging should be allowed (console, alert, etc.) + es5 : true, // if ES5 syntax should be allowed evil : true, // if eval should be allowed forin : true, // if for in statements must filter fragment : true, // if HTML fragments should be allowed - laxbreak : true, // if line breaks should not be checked newcap : true, // if constructor names must be capitalized nomen : true, // if names should be checked on : true, // if HTML event handlers should be allowed @@ -238,7 +341,7 @@ JSLINT = function () { rhino : true, // if the Rhino environment globals should be predefined undef : true, // if variables should be declared before used safe : true, // if use of some browser features should be restricted - sidebar : true, // if the System object should be predefined + windows : true, // if MS Windows-specigic globals should be predefined strict : true, // require the "use strict"; pragma sub : true, // if all forms of subscript notation are tolerated white : true, // if strict whitespace rules apply @@ -249,203 +352,228 @@ JSLINT = function () { // web browser environment. browser = { - alert : true, - blur : true, - clearInterval : true, - clearTimeout : true, - close : true, - closed : true, - confirm : true, - console : true, - Debug : true, - defaultStatus : true, - document : true, - event : true, - focus : true, - frames : true, - getComputedStyle: true, - history : true, - Image : true, - length : true, - location : true, - moveBy : true, - moveTo : true, - name : true, - navigator : true, + addEventListener: false, + blur : false, + clearInterval : false, + clearTimeout : false, + close : false, + closed : false, + defaultStatus : false, + document : false, + event : false, + focus : false, + frames : false, + getComputedStyle: false, + history : false, + Image : false, + length : false, + location : false, + moveBy : false, + moveTo : false, + name : false, + navigator : false, + onbeforeunload : true, onblur : true, onerror : true, onfocus : true, onload : true, onresize : true, onunload : true, - open : true, - opener : true, - opera : true, - Option : true, - parent : true, - print : true, - prompt : true, - resizeBy : true, - resizeTo : true, - screen : true, - scroll : true, - scrollBy : true, - scrollTo : true, - self : true, - setInterval : true, - setTimeout : true, - status : true, - top : true, - window : true, - XMLHttpRequest : true + open : false, + opener : false, + Option : false, + parent : false, + print : false, + removeEventListener: false, + resizeBy : false, + resizeTo : false, + screen : false, + scroll : false, + scrollBy : false, + scrollTo : false, + setInterval : false, + setTimeout : false, + status : false, + top : false, + XMLHttpRequest : false }, cssAttributeData, cssAny, cssColorData = { - "aliceblue": true, - "antiquewhite": true, - "aqua": true, - "aquamarine": true, - "azure": true, - "beige": true, - "bisque": true, - "black": true, - "blanchedalmond": true, - "blue": true, - "blueviolet": true, - "brown": true, - "burlywood": true, - "cadetblue": true, - "chartreuse": true, - "chocolate": true, - "coral": true, - "cornflowerblue": true, - "cornsilk": true, - "crimson": true, - "cyan": true, - "darkblue": true, - "darkcyan": true, - "darkgoldenrod": true, - "darkgray": true, - "darkgreen": true, - "darkkhaki": true, - "darkmagenta": true, - "darkolivegreen": true, - "darkorange": true, - "darkorchid": true, - "darkred": true, - "darksalmon": true, - "darkseagreen": true, - "darkslateblue": true, - "darkslategray": true, - "darkturquoise": true, - "darkviolet": true, - "deeppink": true, - "deepskyblue": true, - "dimgray": true, - "dodgerblue": true, - "firebrick": true, - "floralwhite": true, - "forestgreen": true, - "fuchsia": true, - "gainsboro": true, - "ghostwhite": true, - "gold": true, - "goldenrod": true, - "gray": true, - "green": true, - "greenyellow": true, - "honeydew": true, - "hotpink": true, - "indianred": true, - "indigo": true, - "ivory": true, - "khaki": true, - "lavender": true, - "lavenderblush": true, - "lawngreen": true, - "lemonchiffon": true, - "lightblue": true, - "lightcoral": true, - "lightcyan": true, - "lightgoldenrodyellow": true, - "lightgreen": true, - "lightpink": true, - "lightsalmon": true, - "lightseagreen": true, - "lightskyblue": true, - "lightslategray": true, - "lightsteelblue": true, - "lightyellow": true, - "lime": true, - "limegreen": true, - "linen": true, - "magenta": true, - "maroon": true, - "mediumaquamarine": true, - "mediumblue": true, - "mediumorchid": true, - "mediumpurple": true, - "mediumseagreen": true, - "mediumslateblue": true, - "mediumspringgreen": true, - "mediumturquoise": true, - "mediumvioletred": true, - "midnightblue": true, - "mintcream": true, - "mistyrose": true, - "moccasin": true, - "navajowhite": true, - "navy": true, - "oldlace": true, - "olive": true, - "olivedrab": true, - "orange": true, - "orangered": true, - "orchid": true, - "palegoldenrod": true, - "palegreen": true, - "paleturquoise": true, - "palevioletred": true, - "papayawhip": true, - "peachpuff": true, - "peru": true, - "pink": true, - "plum": true, - "powderblue": true, - "purple": true, - "red": true, - "rosybrown": true, - "royalblue": true, - "saddlebrown": true, - "salmon": true, - "sandybrown": true, - "seagreen": true, - "seashell": true, - "sienna": true, - "silver": true, - "skyblue": true, - "slateblue": true, - "slategray": true, - "snow": true, - "springgreen": true, - "steelblue": true, - "tan": true, - "teal": true, - "thistle": true, - "tomato": true, - "turquoise": true, - "violet": true, - "wheat": true, - "white": true, - "whitesmoke": true, - "yellow": true, - "yellowgreen": true + "aliceblue" : true, + "antiquewhite" : true, + "aqua" : true, + "aquamarine" : true, + "azure" : true, + "beige" : true, + "bisque" : true, + "black" : true, + "blanchedalmond" : true, + "blue" : true, + "blueviolet" : true, + "brown" : true, + "burlywood" : true, + "cadetblue" : true, + "chartreuse" : true, + "chocolate" : true, + "coral" : true, + "cornflowerblue" : true, + "cornsilk" : true, + "crimson" : true, + "cyan" : true, + "darkblue" : true, + "darkcyan" : true, + "darkgoldenrod" : true, + "darkgray" : true, + "darkgreen" : true, + "darkkhaki" : true, + "darkmagenta" : true, + "darkolivegreen" : true, + "darkorange" : true, + "darkorchid" : true, + "darkred" : true, + "darksalmon" : true, + "darkseagreen" : true, + "darkslateblue" : true, + "darkslategray" : true, + "darkturquoise" : true, + "darkviolet" : true, + "deeppink" : true, + "deepskyblue" : true, + "dimgray" : true, + "dodgerblue" : true, + "firebrick" : true, + "floralwhite" : true, + "forestgreen" : true, + "fuchsia" : true, + "gainsboro" : true, + "ghostwhite" : true, + "gold" : true, + "goldenrod" : true, + "gray" : true, + "green" : true, + "greenyellow" : true, + "honeydew" : true, + "hotpink" : true, + "indianred" : true, + "indigo" : true, + "ivory" : true, + "khaki" : true, + "lavender" : true, + "lavenderblush" : true, + "lawngreen" : true, + "lemonchiffon" : true, + "lightblue" : true, + "lightcoral" : true, + "lightcyan" : true, + "lightgoldenrodyellow" : true, + "lightgreen" : true, + "lightpink" : true, + "lightsalmon" : true, + "lightseagreen" : true, + "lightskyblue" : true, + "lightslategray" : true, + "lightsteelblue" : true, + "lightyellow" : true, + "lime" : true, + "limegreen" : true, + "linen" : true, + "magenta" : true, + "maroon" : true, + "mediumaquamarine" : true, + "mediumblue" : true, + "mediumorchid" : true, + "mediumpurple" : true, + "mediumseagreen" : true, + "mediumslateblue" : true, + "mediumspringgreen" : true, + "mediumturquoise" : true, + "mediumvioletred" : true, + "midnightblue" : true, + "mintcream" : true, + "mistyrose" : true, + "moccasin" : true, + "navajowhite" : true, + "navy" : true, + "oldlace" : true, + "olive" : true, + "olivedrab" : true, + "orange" : true, + "orangered" : true, + "orchid" : true, + "palegoldenrod" : true, + "palegreen" : true, + "paleturquoise" : true, + "palevioletred" : true, + "papayawhip" : true, + "peachpuff" : true, + "peru" : true, + "pink" : true, + "plum" : true, + "powderblue" : true, + "purple" : true, + "red" : true, + "rosybrown" : true, + "royalblue" : true, + "saddlebrown" : true, + "salmon" : true, + "sandybrown" : true, + "seagreen" : true, + "seashell" : true, + "sienna" : true, + "silver" : true, + "skyblue" : true, + "slateblue" : true, + "slategray" : true, + "snow" : true, + "springgreen" : true, + "steelblue" : true, + "tan" : true, + "teal" : true, + "thistle" : true, + "tomato" : true, + "turquoise" : true, + "violet" : true, + "wheat" : true, + "white" : true, + "whitesmoke" : true, + "yellow" : true, + "yellowgreen" : true, + + "activeborder" : true, + "activecaption" : true, + "appworkspace" : true, + "background" : true, + "buttonface" : true, + "buttonhighlight" : true, + "buttonshadow" : true, + "buttontext" : true, + "captiontext" : true, + "graytext" : true, + "highlight" : true, + "highlighttext" : true, + "inactiveborder" : true, + "inactivecaption" : true, + "inactivecaptiontext" : true, + "infobackground" : true, + "infotext" : true, + "menu" : true, + "menutext" : true, + "scrollbar" : true, + "threeddarkshadow" : true, + "threedface" : true, + "threedhighlight" : true, + "threedlightshadow" : true, + "threedshadow" : true, + "window" : true, + "windowframe" : true, + "windowtext" : true }, cssBorderStyle, + cssBreak, cssLengthData = { '%': true, @@ -459,6 +587,18 @@ JSLINT = function () { 'px': true }, + cssMedia, + cssOverflow, + + devel = { + alert : false, + confirm : false, + console : false, + Debug : false, + opera : false, + prompt : false + }, + escapes = { '\b': '\\b', '\t': '\\t', @@ -471,6 +611,12 @@ JSLINT = function () { }, funct, // The current function + + functionicity = [ + 'closure', 'exception', 'global', 'label', + 'outer', 'unused', 'var' + ], + functions, // All of the functions global, // The global scope @@ -481,6 +627,9 @@ JSLINT = function () { address: {}, applet: {}, area: {empty: true, parent: ' map '}, + article: {}, + aside: {}, + audio: {}, b: {}, base: {empty: true, parent: ' head '}, bdo: {}, @@ -496,8 +645,12 @@ JSLINT = function () { code: {}, col: {empty: true, parent: ' table colgroup '}, colgroup: {parent: ' table '}, + command: {parent: ' menu '}, + datalist: {}, dd: {parent: ' dl '}, del: {}, + details: {}, + dialog: {}, dfn: {}, dir: {}, div: {}, @@ -506,7 +659,9 @@ JSLINT = function () { em: {}, embed: {}, fieldset: {}, + figure: {}, font: {}, + footer: {}, form: {}, frame: {empty: true, parent: ' frameset '}, frameset: {parent: ' html frameset '}, @@ -517,36 +672,51 @@ JSLINT = function () { h5: {}, h6: {}, head: {parent: ' html '}, - html: {parent: '*'}, + header: {}, + hgroup: {}, hr: {empty: true}, + 'hta:application': + {empty: true, parent: ' head '}, + html: {parent: '*'}, i: {}, iframe: {}, img: {empty: true}, input: {empty: true}, ins: {}, kbd: {}, + keygen: {}, label: {}, - legend: {parent: ' fieldset '}, + legend: {parent: ' details fieldset figure '}, li: {parent: ' dir menu ol ul '}, link: {empty: true, parent: ' head '}, map: {}, + mark: {}, menu: {}, meta: {empty: true, parent: ' head noframes noscript '}, + meter: {}, + nav: {}, noframes: {parent: ' html body '}, noscript: {parent: ' body head noframes '}, object: {}, ol: {}, optgroup: {parent: ' select '}, option: {parent: ' optgroup select '}, + output: {}, p: {}, param: {empty: true, parent: ' applet object '}, pre: {}, + progress: {}, q: {}, + rp: {}, + rt: {}, + ruby: {}, samp: {}, script: {empty: true, parent: ' body div frame head iframe p pre span '}, + section: {}, select: {}, small: {}, span: {}, + source: {}, strong: {}, style: {parent: ' head ', empty: true}, sub: {}, @@ -558,70 +728,67 @@ JSLINT = function () { tfoot: {parent: ' table '}, th: {parent: ' tr '}, thead: {parent: ' table '}, + time: {}, title: {parent: ' head '}, tr: {parent: ' table tbody thead tfoot '}, tt: {}, u: {}, ul: {}, - 'var': {} + 'var': {}, + video: {} }, ids, // HTML ids implied, // Implied globals inblock, - indent, jsonmode, + labelled = { + 'do': true, + 'for': true, + 'switch': true, + 'while': true + }, lines, lookahead, member, membersOnly, nexttoken, - noreach, option, + postscript = { + '(end)': true, + '(error)': true, + '': true, + '}': true, + '"': true, + '\'': true, + 'case': true, + 'default': true + }, predefined, // Global variables defined by option prereg, prevtoken, - pseudorule = { - 'first-child': true, - link : true, - visited : true, - hover : true, - active : true, - focus : true, - lang : true, - 'first-letter' : true, - 'first-line' : true, - before : true, - after : true - }, - rhino = { - defineClass : true, - deserialize : true, - gc : true, - help : true, - load : true, - loadClass : true, - print : true, - quit : true, - readFile : true, - readUrl : true, - runCommand : true, - seal : true, - serialize : true, - spawn : true, - sync : true, - toint32 : true, - version : true + defineClass : false, + deserialize : false, + gc : false, + help : false, + load : false, + loadClass : false, + print : false, + quit : false, + readFile : false, + readUrl : false, + runCommand : false, + seal : false, + serialize : false, + spawn : false, + sync : false, + toint32 : false, + version : false }, scope, // The current scope - - sidebar = { - System : true - }, - src, stack, @@ -629,32 +796,33 @@ JSLINT = function () { // ECMAScript standard. standard = { - Array : true, - Boolean : true, - Date : true, - decodeURI : true, - decodeURIComponent : true, - encodeURI : true, - encodeURIComponent : true, - Error : true, - 'eval' : true, - EvalError : true, - Function : true, - isFinite : true, - isNaN : true, - JSON : true, - Math : true, - Number : true, - Object : true, - parseInt : true, - parseFloat : true, - RangeError : true, - ReferenceError : true, - RegExp : true, - String : true, - SyntaxError : true, - TypeError : true, - URIError : true + Array : false, + Boolean : false, + Date : false, + decodeURI : false, + decodeURIComponent : false, + encodeURI : false, + encodeURIComponent : false, + Error : false, + 'eval' : false, + EvalError : false, + Function : false, + hasOwnProperty : false, + isFinite : false, + isNaN : false, + JSON : false, + Math : false, + Number : false, + Object : false, + parseInt : false, + parseFloat : false, + RangeError : false, + ReferenceError : false, + RegExp : false, + String : false, + SyntaxError : false, + TypeError : false, + URIError : false }, standard_member = { @@ -663,15 +831,16 @@ JSLINT = function () { LN10 : true, LOG2E : true, LOG10E : true, - PI : true, - SQRT1_2 : true, - SQRT2 : true, MAX_VALUE : true, MIN_VALUE : true, NEGATIVE_INFINITY : true, - POSITIVE_INFINITY : true + PI : true, + POSITIVE_INFINITY : true, + SQRT1_2 : true, + SQRT2 : true }, + strict_mode, syntax = {}, tab, token, @@ -699,6 +868,7 @@ JSLINT = function () { escape : true, FadeAnimation : true, filesystem : true, + Flash : true, focusWidget : true, form : true, FormField : true, @@ -710,6 +880,7 @@ JSLINT = function () { iTunes : true, konfabulatorVersion : true, log : true, + md5 : true, MenuItem : true, MoveAnimation : true, openURL : true, @@ -721,6 +892,7 @@ JSLINT = function () { print : true, prompt : true, random : true, + Rectangle : true, reloadWidget : true, ResizeAnimation : true, resolvePath : true, @@ -735,6 +907,7 @@ JSLINT = function () { showWidgetPreferences : true, sleep : true, speak : true, + Style : true, suppressUpdates : true, system : true, tellWidget : true, @@ -744,6 +917,7 @@ JSLINT = function () { unescape : true, updateNow : true, URL : true, + Web : true, widget : true, Window : true, XMLDOM : true, @@ -753,6 +927,16 @@ JSLINT = function () { yahooLogout : true }, + windows = { + ActiveXObject: false, + CScript : false, + Debug : false, + Enumerator : false, + System : false, + VBArray : false, + WScript : false + }, + // xmode is used to adapt to the exceptions in html parsing. // It can have these states: // false .js script file @@ -766,14 +950,19 @@ JSLINT = function () { xmode, xquote, +// Regular expressions. Some of these are stupidly long. + // unsafe comment or string - ax = /@cc|<\/?|script|\]*s\]|<\s*!|</i, -// unsafe character + ax = /@cc|<\/?|script|\]\s*\]|<\s*!|</i, +// unsafe characters that are silently deleted by one or more browsers cx = /[\u0000-\u001f\u007f-\u009f\u00ad\u0600-\u0604\u070f\u17b4\u17b5\u200c-\u200f\u2028-\u202f\u2060-\u206f\ufeff\ufff0-\uffff]/, // token - tx = /^\s*([(){}\[.,:;'"~\?\]#@]|==?=?|\/(\*(global|extern|jslint|member|members)?|=|\/)?|\*[\/=]?|\+[+=]?|-[\-=]?|%=?|&[&=]?|\|[|=]?|>>?>?=?|<([\/=]|\!(\[|--)?|<=?)?|\^=?|\!=?=?|[a-zA-Z_$][a-zA-Z0-9_$]*|[0-9]+([xX][0-9a-fA-F]+|\.[0-9]*)?([eE][+\-]?[0-9]+)?)/, + tx = /^\s*([(){}\[.,:;'"~\?\]#@]|==?=?|\/(\*(jslint|members?|global)?|=|\/)?|\*[\/=]?|\+(?:=|\++)?|-(?:=|-+)?|%=?|&[&=]?|\|[|=]?|>>?>?=?|<([\/=!]|\!(\[|--)?|<=?)?|\^=?|\!=?=?|[a-zA-Z_$][a-zA-Z0-9_$]*|[0-9]+([xX][0-9a-fA-F]+|\.[0-9]*)?([eE][+\-]?[0-9]+)?)/, // html token - hx = /^\s*(['"=>\/]|<[\/!]?|[a-zA-Z][a-zA-Z0-9_\-]*|--)/, + hx = /^\s*(['"=>\/]|<(?:\/|\!(?:--)?)?|[a-zA-Z][a-zA-Z0-9_\-:]*|[0-9]+|--)/, +// characters in strings that need escapement + nx = /[\u0000-\u001f&<"\/\\\u007f-\u009f\u00ad\u0600-\u0604\u070f\u17b4\u17b5\u200c-\u200f\u2028-\u202f\u2060-\u206f\ufeff\ufff0-\uffff]/, + nxg = /[\u0000-\u001f&<"\/\\\u007f-\u009f\u00ad\u0600-\u0604\u070f\u17b4\u17b5\u200c-\u200f\u2028-\u202f\u2060-\u206f\ufeff\ufff0-\uffff]/g, // outer html token ox = /[>&]|<[\/!]?|--/, // star slash @@ -785,8 +974,12 @@ JSLINT = function () { // url badness ux = /&|\+|\u00AD|\.\.|\/\*|%[^;]|base64|url|expression|data|mailto/i, // style - sx = /^\s*([{:#*%.=,>+\[\]@()"';*]|[a-zA-Z0-9_][a-zA-Z0-9_\-]*|<\/|\/\*)/, - ssx = /^\s*([@#!"'};:\-\/%.=,+\[\]()*_]|[a-zA-Z][a-zA-Z0-9._\-]*|\d+(?:\.\d+)?|<\/)/, + sx = /^\s*([{:#%.=,>+\[\]@()"';]|\*=?|\$=|\|=|\^=|~=|[a-zA-Z_][a-zA-Z0-9_\-]*|[0-9]+|<\/|\/\*)/, + ssx = /^\s*([@#!"'};:\-%.=,+\[\]()*_]|[a-zA-Z][a-zA-Z0-9._\-]*|\/\*?|\d+(?:\.\d+)?|<\/)/, +// attributes characters + qx = /[^a-zA-Z0-9+\-_\/ ]/, +// query characters for ids + dx = /[\[\]\/\\"'*<>.&:(){}+=#]/, rx = { outer: hx, @@ -795,7 +988,24 @@ JSLINT = function () { styleproperty: ssx }; - function F() {} + + function F() {} // Used by Object.create + + function is_own(object, name) { + +// The object.hasOwnProperty method fails when the property under consideration +// is named 'hasOwnProperty'. So we have to use this more convoluted form. + + return Object.prototype.hasOwnProperty.call(object, name); + } + +// Provide critical ES5 functions to ES3. + + if (typeof Array.isArray !== 'function') { + Array.isArray = function (o) { + return Object.prototype.toString.apply(o) === '[object Array]'; + }; + } if (typeof Object.create !== 'function') { Object.create = function (o) { @@ -803,41 +1013,54 @@ JSLINT = function () { return new F(); }; } - Object.prototype.union = function (o) { - var n; - for (n in o) { - if (o.hasOwnProperty(n)) { - this[n] = o[n]; - } - } - }; - String.prototype.entityify = function () { - return this. - replace(/&/g, '&'). - replace(//g, '>'); - }; + if (typeof Object.keys !== 'function') { + Object.keys = function (o) { + var a = [], k; + for (k in o) { + if (is_own(o, k)) { + a.push(k); + } + } + return a; + }; + } - String.prototype.isAlpha = function () { - return (this >= 'a' && this <= 'z\uffff') || - (this >= 'A' && this <= 'Z\uffff'); - }; +// Non standard methods + if (typeof String.prototype.entityify !== 'function') { + String.prototype.entityify = function () { + return this + .replace(/&/g, '&') + .replace(//g, '>'); + }; + } - String.prototype.isDigit = function () { - return (this >= '0' && this <= '9'); - }; + if (typeof String.prototype.isAlpha !== 'function') { + String.prototype.isAlpha = function () { + return (this >= 'a' && this <= 'z\uffff') || + (this >= 'A' && this <= 'Z\uffff'); + }; + } + if (typeof String.prototype.isDigit !== 'function') { + String.prototype.isDigit = function () { + return (this >= '0' && this <= '9'); + }; + } - String.prototype.supplant = function (o) { - return this.replace(/\{([^{}]*)\}/g, function (a, b) { - var r = o[b]; - return typeof r === 'string' || typeof r === 'number' ? r : a; - }); - }; + if (typeof String.prototype.supplant !== 'function') { + String.prototype.supplant = function (o) { + return this.replace(/\{([^{}]*)\}/g, function (a, b) { + var r = o[b]; + return typeof r === 'string' || typeof r === 'number' ? r : a; + }); + }; + } - String.prototype.name = function () { + if (typeof String.prototype.name !== 'function') { + String.prototype.name = function () { // If the string looks like an identifier, then we can return it as is. // If the string contains no control characters, no quote characters, and no @@ -845,39 +1068,48 @@ JSLINT = function () { // Otherwise we must also replace the offending characters with safe // sequences. + if (ix.test(this)) { + return this; + } + if (nx.test(this)) { + return '"' + this.replace(nxg, function (a) { + var c = escapes[a]; + if (c) { + return c; + } + return '\\u' + ('0000' + a.charCodeAt().toString(16)).slice(-4); + }) + '"'; + } + return '"' + this + '"'; + }; + } + - if (ix.test(this)) { - return this; - } - if (/[&<"\/\\\x00-\x1f]/.test(this)) { - return '"' + this.replace(/[&<"\/\\\x00-\x1f]/g, function (a) { - var c = escapes[a]; - if (c) { - return c; - } - c = a.charCodeAt(); - return '\\u00' + - Math.floor(c / 16).toString(16) + - (c % 16).toString(16); - }) + '"'; + function combine(t, o) { + var n; + for (n in o) { + if (is_own(o, n)) { + t[n] = o[n]; + } } - return '"' + this + '"'; - }; - + } function assume() { if (!option.safe) { if (option.rhino) { - predefined.union(rhino); + combine(predefined, rhino); } - if (option.browser || option.sidebar) { - predefined.union(browser); + if (option.devel) { + combine(predefined, devel); } - if (option.sidebar) { - predefined.union(sidebar); + if (option.browser) { + combine(predefined, browser); + } + if (option.windows) { + combine(predefined, windows); } if (option.widget) { - predefined.union(widget); + combine(predefined, widget); } } } @@ -906,8 +1138,8 @@ JSLINT = function () { w = { id: '(error)', raw: m, - evidence: lines[l] || '', - line: l + 1, // most line numbering schemes start at 1, not 0 + evidence: lines[l - 1] || '', + line: l, character: ch, a: a, b: b, @@ -920,7 +1152,7 @@ JSLINT = function () { quit('Stopping. ', l, ch); } warnings += 1; - if (warnings === 50) { + if (warnings >= option.maxerr) { quit("Too many errors.", l, ch); } return w; @@ -947,25 +1179,33 @@ JSLINT = function () { -// lexical analysis +// lexical analysis and token construction - var lex = function lex() { + var lex = (function lex() { var character, from, line, s; // Private lex methods function nextLine() { var at; - line += 1; if (line >= lines.length) { return false; } - character = 0; - s = lines[line].replace(/\t/g, tab); + character = 1; + s = lines[line]; + line += 1; + at = s.search(/ \t/); + if (at >= 0) { + warningAt("Mixed spaces and tabs.", line, at + 1); + } + s = s.replace(/\t/g, tab); at = s.search(cx); if (at >= 0) { warningAt("Unsafe character.", line, at); } + if (option.maxlen && option.maxlen < s.length) { + warningAt("Line too long.", line, s.length); + } return true; } @@ -973,17 +1213,11 @@ JSLINT = function () { function it(type, value) { var i, t; - if (type === '(color)') { + if (type === '(color)' || type === '(range)') { t = {type: type}; } else if (type === '(punctuator)' || - (type === '(identifier)' && syntax.hasOwnProperty(value))) { - t = syntax[value]; - -// Mozilla bug workaround. - - if (!t.id) { - t = syntax[type]; - } + (type === '(identifier)' && is_own(syntax, value))) { + t = syntax[value] || syntax['(error)']; } else { t = syntax[type]; } @@ -995,20 +1229,26 @@ JSLINT = function () { } if (type === '(identifier)') { t.identifier = true; - if (option.nomen && value.charAt(0) === '_') { - warningAt("Unexpected '_' in '{a}'.", line, from, value); + if (value === '__iterator__' || value === '__proto__') { + errorAt("Reserved name '{a}'.", + line, from, value); + } else if (option.nomen && + (value.charAt(0) === '_' || + value.charAt(value.length - 1) === '_')) { + warningAt("Unexpected {a} in '{b}'.", line, from, + "dangling '_'", value); } } - t.value = value; + if (value !== undefined) { + t.value = value; + } t.line = line; - t.character = character; + t.thru = character; t.from = from; i = t.id; - if (i !== '(endline)') { - prereg = i && - (('(,=:[!&|?{};'.indexOf(i.charAt(i.length - 1)) >= 0) || - i === 'return'); - } + prereg = i && + (('(,=:[!&|?{};'.indexOf(i.charAt(i.length - 1)) >= 0) || + i === 'return'); return t; } @@ -1017,16 +1257,16 @@ JSLINT = function () { return { init: function (source) { if (typeof source === 'string') { - lines = source. - replace(/\r\n/g, '\n'). - replace(/\r/g, '\n'). - split('\n'); + lines = source + .replace(/\r\n/g, '\n') + .replace(/\r/g, '\n') + .split('\n'); } else { lines = source; } - line = -1; + line = 0; nextLine(); - from = 0; + from = 1; }, range: function (begin, end) { @@ -1050,13 +1290,11 @@ JSLINT = function () { return it('(range)', value); case xquote: case '\\': - case '\'': - case '"': warningAt("Unexpected '{a}'.", line, character, c); + break; } value += c; } - }, // token -- this is called by advance to get the next token. @@ -1071,8 +1309,8 @@ JSLINT = function () { r1 = r[1]; c = r1.charAt(0); s = s.substr(l); + from = character + l - r1.length; character += l; - from = character - r1.length; return r1; } } @@ -1092,7 +1330,7 @@ JSLINT = function () { function esc(n) { var i = parseInt(s.substr(j + 1, n), 16); j += n; - if (i >= 32 && i <= 127 && + if (i >= 32 && i <= 126 && i !== 34 && i !== 92 && i !== 39) { warningAt("Unnecessary escapement.", line, character); } @@ -1154,10 +1392,14 @@ JSLINT = function () { character + j); break; case '\\': - case '\'': case '"': case '/': break; + case '\'': + if (jsonmode) { + warningAt("Avoid \\'.", line, character); + } + break; case 'b': c = '\b'; break; @@ -1177,6 +1419,9 @@ JSLINT = function () { esc(4); break; case 'v': + if (jsonmode) { + warningAt("Avoid \\v.", line, character); + } c = '\v'; break; case 'x': @@ -1197,8 +1442,10 @@ JSLINT = function () { } for (;;) { - if (!s) { - return it(nextLine() ? '(endline)' : '(end)', ''); + while (!s) { + if (!nextLine()) { + return it('(end)'); + } } while (xmode === 'outer') { i = s.search(ox); @@ -1216,15 +1463,15 @@ JSLINT = function () { } t = match(rx[xmode] || tx); if (!t) { - if (xmode === 'html') { - return it('(error)', s.charAt(0)); - } else { - t = ''; - c = ''; - while (s && s < '!') { - s = s.substr(1); - } - if (s) { + t = ''; + c = ''; + while (s && s < '!') { + s = s.substr(1); + } + if (s) { + if (xmode === 'html') { + return it('(error)', s.charAt(0)); + } else { errorAt("Unexpected '{a}'.", line, character, s.substr(0, 1)); } @@ -1244,7 +1491,9 @@ JSLINT = function () { warningAt("Bad number '{a}'.", line, character, t); } - if (xmode !== 'styleproperty' && s.substr(0, 1).isAlpha()) { + if (xmode !== 'style' && + xmode !== 'styleproperty' && + s.substr(0, 1).isAlpha()) { warningAt("Missing space after '{a}'.", line, character, t); } @@ -1262,8 +1511,7 @@ JSLINT = function () { } if (t.substr(t.length - 1) === '.') { warningAt( - "A trailing decimal point can be confused with a dot '{a}'.", - line, character, t); +"A trailing decimal point can be confused with a dot '{a}'.", line, character, t); } return it('(number)', t); } @@ -1307,7 +1555,8 @@ JSLINT = function () { errorAt("Unclosed comment.", line, character); } else { if (option.safe && ax.test(s)) { - warningAt("ADsafe comment violation.", line, character); + warningAt("ADsafe comment violation.", + line, character); } } } @@ -1319,19 +1568,18 @@ JSLINT = function () { token.comment = true; break; - // /*global /*extern /*members /*jslint */ + // /*members /*jslint /*global - case '/*global': - case '/*extern': case '/*members': case '/*member': case '/*jslint': + case '/*global': case '*/': return { value: t, type: 'special', line: line, - character: character, + thru: character, from: from }; @@ -1339,6 +1587,10 @@ JSLINT = function () { break; // / case '/': + if (token.id === '/=') { + errorAt( +"A regular expression literal can be confused with '/='.", line, from); + } if (prereg) { depth = 0; captures = 0; @@ -1349,11 +1601,13 @@ JSLINT = function () { l += 1; switch (c) { case '': - errorAt("Unclosed regular expression.", line, from); + errorAt("Unclosed regular expression.", + line, from); return; case '/': if (depth > 0) { - warningAt("Unescaped '{a}'.", line, from + l, '/'); + warningAt("Unescaped '{a}'.", + line, from + l, '/'); } c = s.substr(0, l - 1); q = { @@ -1367,13 +1621,20 @@ JSLINT = function () { } character += l; s = s.substr(l); + q = s.charAt(0); + if (q === '/' || q === '*') { + errorAt("Confusing regular expression.", + line, from); + } return it('(regexp)', c); case '\\': c = s.charAt(l); if (c < ' ') { - warningAt("Unexpected control character in regular expression.", line, from + l); + warningAt( +"Unexpected control character in regular expression.", line, from + l); } else if (c === '<') { - warningAt("Unexpected escaped character '{a}' in regular expression.", line, from + l, c); + warningAt( +"Unexpected escaped character '{a}' in regular expression.", line, from + l, c); } l += 1; break; @@ -1389,15 +1650,20 @@ JSLINT = function () { l += 1; break; default: - warningAt("Expected '{a}' and instead saw '{b}'.", line, from + l, ':', s.charAt(l)); + warningAt( +"Expected '{a}' and instead saw '{b}'.", line, from + l, ':', s.charAt(l)); } } else { captures += 1; } break; + case '|': + b = false; + break; case ')': if (depth === 0) { - warningAt("Unescaped '{a}'.", line, from + l, ')'); + warningAt("Unescaped '{a}'.", + line, from + l, ')'); } else { depth -= 1; } @@ -1409,55 +1675,76 @@ JSLINT = function () { q += 1; } if (q > 1) { - warningAt("Spaces are hard to count. Use {{a}}.", line, from + l, q); + warningAt( +"Spaces are hard to count. Use {{a}}.", line, from + l, q); } break; case '[': - if (s.charAt(l) === '^') { + c = s.charAt(l); + if (c === '^') { l += 1; + if (option.regexp) { + warningAt("Insecure '{a}'.", + line, from + l, c); + } else if (s.charAt(l) === ']') { + errorAt("Unescaped '{a}'.", + line, from + l, '^'); + } } q = false; - klass: do { + if (c === ']') { + warningAt("Empty class.", line, + from + l - 1); + q = true; + } +klass: do { c = s.charAt(l); l += 1; switch (c) { case '[': case '^': - warningAt("Unescaped '{a}'.", line, from + l, c); + warningAt("Unescaped '{a}'.", + line, from + l, c); q = true; break; case '-': if (q) { q = false; } else { - warningAt("Unescaped '{a}'.", line, from + l, '-'); + warningAt("Unescaped '{a}'.", + line, from + l, '-'); q = true; } break; case ']': if (!q) { - warningAt("Unescaped '{a}'.", line, from + l - 1, '-'); + warningAt("Unescaped '{a}'.", + line, from + l - 1, '-'); } break klass; case '\\': c = s.charAt(l); if (c < ' ') { - warningAt("Unexpected control character in regular expression.", line, from + l); + warningAt( +"Unexpected control character in regular expression.", line, from + l); } else if (c === '<') { - warningAt("Unexpected escaped character '{a}' in regular expression.", line, from + l, c); + warningAt( +"Unexpected escaped character '{a}' in regular expression.", line, from + l, c); } l += 1; q = true; break; case '/': - warningAt("Unescaped '{a}'.", line, from + l - 1, '/'); + warningAt("Unescaped '{a}'.", + line, from + l - 1, '/'); q = true; break; case '<': if (xmode === 'script') { c = s.charAt(l); if (c === '!' || c === '/') { - warningAt("HTML confusion in regular expression '<{a}'.", line, from + l, c); + warningAt( +"HTML confusion in regular expression '<{a}'.", line, from + l, c); } } q = true; @@ -1469,7 +1756,8 @@ JSLINT = function () { break; case '.': if (option.regexp) { - warningAt("Unexpected '{a}'.", line, from + l, c); + warningAt("Insecure '{a}'.", line, + from + l, c); } break; case ']': @@ -1478,15 +1766,18 @@ JSLINT = function () { case '}': case '+': case '*': - warningAt("Unescaped '{a}'.", line, from + l, c); + warningAt("Unescaped '{a}'.", line, + from + l, c); break; case '<': if (xmode === 'script') { c = s.charAt(l); if (c === '!' || c === '/') { - warningAt("HTML confusion in regular expression '<{a}'.", line, from + l, c); + warningAt( +"HTML confusion in regular expression '<{a}'.", line, from + l, c); } } + break; } if (b) { switch (s.charAt(l)) { @@ -1502,7 +1793,8 @@ JSLINT = function () { l += 1; c = s.charAt(l); if (c < '0' || c > '9') { - warningAt("Expected a number and instead saw '{a}'.", line, from + l, c); + warningAt( +"Expected a number and instead saw '{a}'.", line, from + l, c); } l += 1; low = +c; @@ -1533,7 +1825,8 @@ JSLINT = function () { } } if (s.charAt(l) !== '}') { - warningAt("Expected '{a}' and instead saw '{b}'.", line, from + l, '}', c); + warningAt( +"Expected '{a}' and instead saw '{b}'.", line, from + l, '}', c); } else { l += 1; } @@ -1541,8 +1834,10 @@ JSLINT = function () { l += 1; } if (low > high) { - warningAt("'{a}' should not be greater than '{b}'.", line, from + l, low, high); + warningAt( +"'{a}' should not be greater than '{b}'.", line, from + l, low, high); } + break; } } } @@ -1555,6 +1850,35 @@ JSLINT = function () { // punctuator + case '.", line, character); + } + character += 3; + s = s.slice(i + 3); + break; case '#': if (xmode === 'html' || xmode === 'styleproperty') { for (;;) { @@ -1601,47 +1925,35 @@ JSLINT = function () { } } }; - }(); + }()); function addlabel(t, type) { - var i, j; - if (t === 'hasOwnProperty') { - error("'hasOwnProperty' is a really bad name."); - } - if (option.safe && funct['(global)']) { + if (option.safe && funct['(global)'] && + typeof predefined[t] !== 'boolean') { warning('ADsafe global: ' + t + '.', token); + } else if (t === 'hasOwnProperty') { + warning("'hasOwnProperty' is a really bad name."); } // Define t in the current function in the current scope. - if (funct.hasOwnProperty(t)) { + if (is_own(funct, t) && !funct['(global)']) { warning(funct[t] === true ? "'{a}' was used before it was defined." : "'{a}' is already defined.", nexttoken, t); } funct[t] = type; - if (type === 'label') { - scope[t] = funct; - } else if (funct['(global)']) { + if (funct['(global)']) { global[t] = funct; - if (implied.hasOwnProperty(t)) { + if (is_own(implied, t)) { warning("'{a}' was used before it was defined.", nexttoken, t); - /* - for (i = 0; i < JSLINT.errors.length; i++) { - for (j = 0; j < implied[t].length; j++) { - if (JSLINT.errors[i] === implied[t][j]) { - delete JSLINT.errors[i]; - } - } - } - */ delete implied[t]; } } else { - funct['(scope)'][t] = funct; + scope[t] = funct; } } @@ -1652,13 +1964,6 @@ JSLINT = function () { case '*/': error("Unbegun comment."); break; - case '/*global': - case '/*extern': - if (option.safe) { - warning("ADsafe restriction."); - } - obj = predefined; - break; case '/*members': case '/*member': o = '/*members'; @@ -1673,44 +1978,78 @@ JSLINT = function () { } obj = option; filter = boolOptions; - } - for (;;) { - t = lex.token(); - if (t.id === ',') { - t = lex.token(); + break; + case '/*global': + if (option.safe) { + warning("ADsafe restriction."); } - while (t.id === '(endline)') { + obj = predefined; + break; + default: + error("What?"); + } + t = lex.token(); +loop: for (;;) { + for (;;) { + if (t.type === 'special' && t.value === '*/') { + break loop; + } + if (t.id !== ',') { + break; + } t = lex.token(); } - if (t.type === 'special' && t.value === '*/') { - break; - } if (t.type !== '(string)' && t.type !== '(identifier)' && o !== '/*members') { error("Bad option.", t); } - if (filter) { - if (filter[t.value] !== true) { - error("Bad option.", t); - } + v = lex.token(); + if (v.id === ':') { v = lex.token(); - if (v.id !== ':') { + if (obj === membersOnly) { error("Expected '{a}' and instead saw '{b}'.", - t, ':', t.value); + t, '*/', ':'); } - v = lex.token(); - if (v.value === 'true') { - b = true; + if (t.value === 'indent' && o === '/*jslint') { + b = +v.value; + if (typeof b !== 'number' || !isFinite(b) || b <= 0 || + Math.floor(b) !== b) { + error("Expected a small integer and instead saw '{a}'.", + v, v.value); + } + obj.white = true; + obj.indent = b; + } else if (t.value === 'maxerr' && o === '/*jslint') { + b = +v.value; + if (typeof b !== 'number' || !isFinite(b) || b <= 0 || + Math.floor(b) !== b) { + error("Expected a small integer and instead saw '{a}'.", + v, v.value); + } + obj.maxerr = b; + } else if (t.value === 'maxlen' && o === '/*jslint') { + b = +v.value; + if (typeof b !== 'number' || !isFinite(b) || b <= 0 || + Math.floor(b) !== b) { + error("Expected a small integer and instead saw '{a}'.", + v, v.value); + } + obj.maxlen = b; + } else if (v.value === 'true') { + obj[t.value] = true; } else if (v.value === 'false') { - b = false; + obj[t.value] = false; } else { - error("Expected '{a}' and instead saw '{b}'.", - t, 'true', t.value); + error("Bad option value.", v); } + t = lex.token(); } else { - b = true; + if (o === '/*jslint') { + error("Missing option value.", t); + } + obj[t.value] = false; + t = v; } - obj[t.value] = b; } if (filter) { assume(); @@ -1742,7 +2081,6 @@ JSLINT = function () { // Produce the next token. It looks for programming errors. function advance(id, t) { - var l; switch (token.id) { case '(number)': if (nexttoken.id === '.') { @@ -1770,8 +2108,9 @@ JSLINT = function () { if (nexttoken.id === '(end)') { warning("Unmatched '{a}'.", t, t.id); } else { - warning("Expected '{a}' to match '{b}' from line {c} and instead saw '{d}'.", - nexttoken, id, t.id, t.line + 1, nexttoken.value); + warning( +"Expected '{a}' to match '{b}' from line {c} and instead saw '{d}'.", + nexttoken, id, t.id, t.line, nexttoken.value); } } else if (nexttoken.type !== '(identifier)' || nexttoken.value !== id) { @@ -1783,50 +2122,110 @@ JSLINT = function () { token = nexttoken; for (;;) { nexttoken = lookahead.shift() || lex.token(); - if (nexttoken.id === '(end)' || nexttoken.id === '(error)') { - return; + if (nexttoken.type !== 'special') { + break; } - if (nexttoken.type === 'special') { - doOption(); - } else { - if (nexttoken.id !== '(endline)') { - break; - } - l = !xmode && !option.laxbreak && - (token.type === '(string)' || token.type === '(number)' || - token.type === '(identifier)' || badbreak[token.id]); + doOption(); + } + } + +// Functions for conformance of style. + + function one_space_only(left, right) { + left = left || token; + right = right || nexttoken; + if (right.id !== '(end)' && (left.line !== right.line || + (option.white && left.thru + 1 !== right.from))) { + warning("Expected exactly one space between '{a}' and '{b}'.", + right, left.value, right.value); + } + } + + function one_space(left, right) { + left = left || token; + right = right || nexttoken; + if (right.id !== '(end)' && option.white && + (token.line !== right.line || + token.thru + 1 !== right.from)) { + warning("Expected exactly one space between '{a}' and '{b}'.", + right, token.value, right.value); + } + } + + function no_space(left, right) { + left = left || token; + right = right || nexttoken; + if ((option.white || xmode === 'styleproperty' || xmode === 'style') && + left.thru !== right.from && left.line === right.line) { + warning("Unexpected space between '{a}' and '{b}'.", right, + left.value, right.value); + } + } + + function no_space_only(left, right) { + left = left || token; + right = right || nexttoken; + if (right.id !== '(end)' && (left.line !== right.line || + (option.white && left.thru !== right.from))) { + warning("Unexpected space between '{a}' and '{b}'.", + right, left.value, right.value); + } + } + + function spaces(left, right) { + if (option.white) { + left = left || token; + right = right || nexttoken; + if (left.thru === right.from && left.line === right.line) { + warning("Missing space between '{a}' and '{b}'.", + right, left.value, right.value); } } - if (l) { - switch (nexttoken.id) { - case '{': - case '}': - case ']': - case '.': - break; - case ')': - switch (token.id) { - case ')': - case '}': - case ']': - break; - default: - warning("Line breaking error '{a}'.", token, ')'); - } - break; - default: - warning("Line breaking error '{a}'.", - token, token.value); + } + + function comma() { + no_space_only(); + advance(','); + spaces(); + } + + + function semicolon() { + no_space_only(); + advance(';'); + switch (nexttoken.id) { + case ';': + case '"': + case '\'': + case ')': + break; + default: + spaces(); + } + } + + function use_strict() { + if (nexttoken.value === 'use strict') { + if (strict_mode) { + warning("Unnecessary \"use strict\"."); } + advance(); + semicolon(); + strict_mode = true; + option.newcap = true; + option.undef = true; + return true; + } else { + return false; } } // This is the heart of JSLINT, the Pratt parser. In addition to parsing, it -// is looking for ad hoc lint patterns. We add to Pratt's model .fud, which is -// like nud except that it is only used on the first token of a statement. -// Having .fud makes it much easier to define JavaScript. I retained Pratt's -// nomenclature. +// is looking for ad hoc lint patterns. We add .fud to Pratt's model, which is +// like .nud except that it is only used on the first token of a statement. +// Having .fud makes it much easier to define statement-oriented languages like +// JavaScript. I retained Pratt's nomenclature. // .nud Null denotation // .fud First null denotation @@ -1834,15 +2233,19 @@ JSLINT = function () { // lbp Left binding power // rbp Right binding power -// They are key to the parsing method called Top Down Operator Precedence. +// They are elements of the parsing method called Top Down Operator Precedence. + + function expression(rbp, initial) { + +// rbp is the right binding power. +// initial indicates that this is the first expression of a statement. - function parse(rbp, initial) { - var left, o; + var left; if (nexttoken.id === '(end)') { error("Unexpected early end of program.", token); } advance(); - if (option.safe && predefined[token.value] === true && + if (option.safe && typeof predefined[token.value] === 'boolean' && (nexttoken.id !== '(' && nexttoken.id !== '.')) { warning('ADsafe violation.', token); } @@ -1854,7 +2257,6 @@ JSLINT = function () { left = token.fud(); } else { if (token.nud) { - o = token.exps; left = token.nud(); } else { if (nexttoken.type === '(number)' && token.id === '.') { @@ -1869,7 +2271,6 @@ JSLINT = function () { } } while (rbp < nexttoken.lbp) { - o = nexttoken.exps; advance(); if (token.led) { left = token.led(left); @@ -1878,75 +2279,13 @@ JSLINT = function () { token, token.id); } } - if (initial && !o) { - warning( -"Expected an assignment or function call and instead saw an expression.", - token); - } - } - if (!option.evil && left && left.value === 'eval') { - warning("eval is evil.", left); } return left; } -// Functions for conformance of style. - - function adjacent(left, right) { - left = left || token; - right = right || nexttoken; - if (option.white || xmode === 'styleproperty' || xmode === 'style') { - if (left.character !== right.from && left.line === right.line) { - warning("Unexpected space after '{a}'.", - nexttoken, left.value); - } - } - } - - - function nospace(left, right) { - left = left || token; - right = right || nexttoken; - if (option.white && !left.comment) { - if (left.line === right.line) { - adjacent(left, right); - } - } - } - - - function nonadjacent(left, right) { - left = left || token; - right = right || nexttoken; - if (option.white) { - if (left.character === right.from) { - warning("Missing space after '{a}'.", - nexttoken, left.value); - } - } - } - - function indentation(bias) { - var i; - if (option.white && nexttoken.id !== '(end)') { - i = indent + (bias || 0); - if (nexttoken.from !== i) { - warning("Expected '{a}' to have an indentation of {b} instead of {c}.", - nexttoken, nexttoken.value, i, nexttoken.from); - } - } - } - - function nolinebreak(t) { - if (t.line !== nexttoken.line) { - warning("Line breaking error '{a}'.", t, t.id); - } - } - - -// Parasitic constructors for making the symbols that will be inherited by -// tokens. +// Functional constructors for making the symbols that will be inherited by +// tokens. function symbol(s, p) { var x = syntax[s]; @@ -1966,6 +2305,15 @@ JSLINT = function () { } + function ultimate(s) { + var x = symbol(s, 0); + x.from = 0; + x.thru = 0; + s.value = s; + return x; + } + + function stmt(s, f) { var x = delim(s); x.identifier = x.reserved = true; @@ -1973,11 +2321,9 @@ JSLINT = function () { return x; } - - function blockstmt(s, f) { + function disruptstmt(s, f) { var x = stmt(s, f); - x.block = true; - return x; + x.disrupt = true; } @@ -1994,11 +2340,21 @@ JSLINT = function () { var x = symbol(s, 150); reserveName(x); x.nud = (typeof f === 'function') ? f : function () { - if (option.plusplus && (this.id === '++' || this.id === '--')) { - warning("Unexpected use of '{a}'.", this, this.id); + if (s === 'typeof') { + one_space(); + } else { + no_space_only(); + } + this.first = expression(150); + this.arity = 'prefix'; + if (this.id === '++' || this.id === '--') { + if (option.plusplus) { + warning("Unexpected use of '{a}'.", this, this.id); + } else if ((!this.first.identifier || this.first.reserved) && + this.first.id !== '.' && this.first.id !== '[') { + warning("Bad operand.", this); + } } - this.right = parse(150); - this.arity = 'unary'; return this; }; return x; @@ -2022,85 +2378,93 @@ JSLINT = function () { function reservevar(s, v) { return reserve(s, function () { - if (this.id === 'this') { - if (option.safe) { - warning("ADsafe violation.", this); - } + if (typeof v === 'function') { + v(this); } return this; }); } - function infix(s, f, p) { + function infix(s, p, f, w) { var x = symbol(s, p); reserveName(x); - x.led = (typeof f === 'function') ? f : function (left) { - nonadjacent(prevtoken, token); - nonadjacent(token, nexttoken); - this.left = left; - this.right = parse(p); - return this; - }; - return x; - } - - - function relation(s, f) { - var x = symbol(s, 100); x.led = function (left) { - nonadjacent(prevtoken, token); - nonadjacent(token, nexttoken); - var right = parse(100); - if ((left && left.id === 'NaN') || (right && right.id === 'NaN')) { - warning("Use the isNaN function to compare with NaN.", this); - } else if (f) { - f.apply(this, [left, right]); - } - this.left = left; - this.right = right; - return this; + this.arity = 'infix'; + if (!w) { + spaces(prevtoken, token); + spaces(); + } + if (typeof f === 'function') { + return f(left, this); + } else { + this.first = left; + this.second = expression(p); + return this; + } }; return x; } - function isPoorRelation(node) { - return (node.type === '(number)' && !+node.value) || - (node.type === '(string)' && !node.value) || - node.type === 'true' || - node.type === 'false' || - node.type === 'undefined' || - node.type === 'null'; + function relation(s, eqeq) { + var x = infix(s, 100, function (left, that) { + var right = expression(100); + if (eqeq) { + warning("Expected '{a}' and instead saw '{b}'.", + that, eqeq, that.id); + } else if (left.id === 'NaN' || right.id === 'NaN') { + warning("Use the isNaN function to compare with NaN.", that); + } + if (left.id === '!') { + warning("Confusing use of '{a}'.", left, '!'); + } + if (right.id === '!') { + warning("Confusing use of '{a}'.", left, '!'); + } + that.first = left; + that.second = right; + return that; + }); + return x; } - function assignop(s, f) { - symbol(s, 20).exps = true; - return infix(s, function (left) { + function assignop(s, bit) { + var x = infix(s, 20, function (left, that) { var l; - this.left = left; - nonadjacent(prevtoken, token); - nonadjacent(token, nexttoken); + if (option.bitwise && bit) { + warning("Unexpected use of '{a}'.", that, that.id); + } + that.first = left; + if (predefined[left.value] === false && + scope[left.value]['(global)'] === true) { + warning("Read only.", left); + } else if (left['function']) { + warning("'{a}' is a function.", left, left.value); + } if (option.safe) { l = left; do { - if (predefined[l.value] === true) { + if (typeof predefined[l.value] === 'boolean') { warning('ADsafe violation.', l); } - l = l.left; + l = l.first; } while (l); } if (left) { if (left.id === '.' || left.id === '[') { - if (left.left.value === 'arguments') { - warning('Bad assignment.', this); + if (!left.first || left.first.value === 'arguments') { + warning('Bad assignment.', that); } - this.right = parse(19); - return this; + that.second = expression(19); + return that; } else if (left.identifier && !left.reserved) { - this.right = parse(19); - return this; + if (funct[left.value] === 'exception') { + warning("Do not assign to the exception parameter.", left); + } + that.second = expression(19); + return that; } if (left === syntax['function']) { warning( @@ -2108,58 +2472,37 @@ JSLINT = function () { token); } } - error("Bad assignment.", this); - }, 20); - } - - function bitwise(s, f, p) { - var x = symbol(s, p); - reserveName(x); - x.led = (typeof f === 'function') ? f : function (left) { - if (option.bitwise) { - warning("Unexpected use of '{a}'.", this, this.id); - } - nonadjacent(prevtoken, token); - nonadjacent(token, nexttoken); - this.left = left; - this.right = parse(p); - return this; - }; + error("Bad assignment.", that); + }); + x.assign = true; return x; } - function bitwiseassignop(s) { - symbol(s, 20).exps = true; - return infix(s, function (left) { + + function bitwise(s, p) { + return infix(s, p, function (left, that) { if (option.bitwise) { - warning("Unexpected use of '{a}'.", this, this.id); - } - nonadjacent(prevtoken, token); - nonadjacent(token, nexttoken); - if (left) { - if (left.id === '.' || left.id === '[' || - (left.identifier && !left.reserved)) { - parse(19); - return left; - } - if (left === syntax['function']) { - warning( -"Expected an identifier in an assignment, and instead saw a function invocation.", - token); - } + warning("Unexpected use of '{a}'.", that, that.id); } - error("Bad assignment.", this); - }, 20); + that.first = left; + that.second = expression(p); + return that; + }); } function suffix(s, f) { var x = symbol(s, 150); x.led = function (left) { + no_space_only(prevtoken, token); if (option.plusplus) { warning("Unexpected use of '{a}'.", this, this.id); + } else if ((!left.identifier || left.reserved) && + left.id !== '.' && left.id !== '[') { + warning("Bad operand.", this); } - this.left = left; + this.first = left; + this.arity = 'suffix'; return this; }; return x; @@ -2167,12 +2510,14 @@ JSLINT = function () { function optionalidentifier() { - if (nexttoken.reserved) { - warning("Expected an identifier and instead saw '{a}' (a reserved word).", - nexttoken, nexttoken.id); - } if (nexttoken.identifier) { advance(); + if (option.safe && banned[token.value]) { + warning("ADsafe violation: '{a}'.", token, token.value); + } else if (token.reserved && !option.es5) { + warning("Expected an identifier and instead saw '{a}' (a reserved word).", + token, token.id); + } return token.value; } } @@ -2191,32 +2536,13 @@ JSLINT = function () { } } - function reachable(s) { - var i = 0, t; - if (nexttoken.id !== ';' || noreach) { - return; - } - for (;;) { - t = peek(i); - if (t.reach) { - return; - } - if (t.id !== '(endline)') { - if (t.id === 'function') { - warning( -"Inner functions should be listed at the top of the outer function.", t); - break; - } - warning("Unreachable '{a}' after '{b}'.", t, t.value, s); - break; - } - i += 1; - } - } - function statement(noindent) { - var i = indent, r, s = scope, t = nexttoken; + +// Usually a statement starts a line. Exceptions include the var statement in the +// initialization part of a for statement, and an if after an else. + + var r, s = scope, t = nexttoken; // We don't like the empty statement. @@ -2233,8 +2559,8 @@ JSLINT = function () { advance(':'); scope = Object.create(s); addlabel(t.value, 'label'); - if (!nexttoken.labelled) { - warning("Label '{a}' on {b} statement.", + if (labelled[nexttoken.id] !== true) { + warning("Label '{a}' on '{b}' statement.", nexttoken, t.value, nexttoken.value); } if (jx.test(t.value + ':')) { @@ -2247,48 +2573,45 @@ JSLINT = function () { // Parse the statement. - if (!noindent) { - indentation(); - } - r = parse(0, true); + r = expression(0, true); // Look for the final semicolon. - if (!t.block) { + if (r.arity === 'statement') { + if (r.id !== 'switch' && (!r.block || r.id === 'do')) { + semicolon(); + } else { + spaces(); + } + } else { + if (r.id === '(' && r.first.id === 'new') { + warning("Do not use 'new' for side effects."); + } else if (!r.assign && r.id !== 'delete' && r.id !== '++' && + r.id !== '--' && r.id !== '(') { + warning( +"Expected an assignment or function call and instead saw an expression.", + token); + } if (nexttoken.id !== ';') { warningAt("Missing semicolon.", token.line, token.from + token.value.length); } else { - adjacent(token, nexttoken); - advance(';'); - nonadjacent(token, nexttoken); + semicolon(); } } - -// Restore the indentation. - - indent = i; scope = s; return r; } function statements(begin) { - var a = []; - if (begin) { - if (option.strict && nexttoken.type !== '(string)') { - warning('Missing "use strict" statement.', - nexttoken); - } - if (nexttoken.type === '(string)' && - nexttoken.value === 'use strict') { - advance(); - advance(';'); - } - } + var a = [], d, f, p, s; if (option.adsafe) { switch (begin) { case 'script': + +// JSLint is also the static analizer for ADsafe. See www.ADsafe.org. + if (!adsafe_may) { if (nexttoken.value !== 'ADSAFE' || peek(0).id !== '.' || @@ -2313,7 +2636,7 @@ JSLINT = function () { } advance('(string)'); advance(')'); - advance(';'); + semicolon(); adsafe_may = true; } break; @@ -2324,72 +2647,93 @@ JSLINT = function () { advance('lib'); advance('('); advance('(string)'); - advance(','); - parse(0); + comma(); + f = expression(0); + if (f.id !== 'function') { + error('The second argument to lib must be a function.', f); + } + p = f.funct['(params)']; + p = p && p.join(', '); + if (p && p !== 'lib') { + error("Expected '{a}' and instead saw '{b}'.", + f, '(lib)', '(' + p + ')'); + } advance(')'); - advance(';'); + semicolon(); return a; } else { error("ADsafe lib violation."); } + break; } } - while (!nexttoken.reach && nexttoken.id !== '(end)') { + +// A disrupt statement may not be followed by any other statement. +// If the last statement is disrupt, then the sequence is disrupt. + + while (postscript[nexttoken.id] !== true) { if (nexttoken.id === ';') { warning("Unnecessary semicolon."); advance(';'); } else { - a.push(statement()); + if (d) { + warning("Unreachable '{a}' after '{b}'.", nexttoken, + nexttoken.value, d.value); + d = null; + } + s = statement(); + a.push(s); + if (s.disrupt) { + d = s; + a.disrupt = true; + } } } return a; } - function block(f) { - var a, b = inblock, s = scope, t; - inblock = f; - if (f) { - scope = Object.create(scope); - } - nonadjacent(token, nexttoken); + function block(ordinary) { + +// A block is a sequence of statements wrapped in braces. +// ordinary is false for function bodies and try blocks. +// ordinary is true for if statements, while, etc. + + var a, + b = inblock, + m = strict_mode, + s = scope, + t; + inblock = ordinary; + scope = Object.create(scope); + spaces(); t = nexttoken; if (nexttoken.id === '{') { advance('{'); - if (nexttoken.id !== '}' || token.line !== nexttoken.line) { - indent += option.indent; - if (!f && nexttoken.from === indent + option.indent) { - indent += option.indent; - } - a = statements(); - indent -= option.indent; - indentation(); + if (!ordinary && !use_strict() && !m && option.strict && + funct['(context)']['(global)']) { + warning("Missing \"use strict\" statement."); } + a = statements(); + strict_mode = m; advance('}', t); } else { - warning("Expected '{a}' and instead saw '{b}'.", + error("Expected '{a}' and instead saw '{b}'.", nexttoken, '{', nexttoken.value); - noreach = true; - a = [statement()]; - noreach = false; } funct['(verb)'] = null; scope = s; inblock = b; + if (ordinary && a.length === 0) { + warning("Empty block."); + } return a; } -// An identity function, used by string and number tokens. - - function idValue() { - return this; - } - - function countMember(m) { - if (membersOnly && membersOnly[m] !== true) { - warning("Unexpected /*member '{a}'.", nexttoken, m); + if (membersOnly && typeof membersOnly[m] !== 'boolean') { + warning("Unexpected /*member '{a}'.", token, m); } if (typeof member[m] === 'number') { member[m] += 1; @@ -2398,2223 +2742,2609 @@ JSLINT = function () { } } + function note_implied(token) { - var name = token.value, - line = token.line + 1, - a = implied[name], - error = { - reason : "Implied global '"+name+"'", - line : line , - character : token.character, - evidence : lines[line-1] || '' - }; + var name = token.value, line = token.line, a = implied[name]; + if (typeof a === 'function') { + a = false; + } if (!a) { - a = [error]; + a = [line]; implied[name] = a; - } else { - a.push(error); + } else if (a[a.length - 1] !== line) { + a.push(line); } - JSLINT.errors.push(error); } -// CSS parsing. +// Build the syntax table by declaring the syntactic elements of the language. - function cssName() { - if (nexttoken.identifier) { - advance(); - return true; - } - } + type('(number)', function () { + this.arity = 'number'; + return this; + }); + type('(string)', function () { + this.arity = 'string'; + return this; + }); - function cssNumber() { - if (nexttoken.id === '-') { - advance('-'); - advance('(number)'); - } - if (nexttoken.type === '(number)') { - advance(); - return true; - } - } + syntax['(identifier)'] = { + type: '(identifier)', + lbp: 0, + identifier: true, + nud: function () { + var v = this.value, + s = scope[v], + f; + if (typeof s === 'function') { - function cssString() { - if (nexttoken.type === '(string)') { - advance(); - return true; - } - } +// Protection against accidental inheritance. - function cssColor() { - var i, number; - if (nexttoken.identifier) { - if (nexttoken.value === 'rgb') { - advance(); - advance('('); - for (i = 0; i < 3; i += 1) { - number = nexttoken.value; - if (nexttoken.type !== '(number)' || number < 0) { - warning("Expected a positive number and instead saw '{a}'", - nexttoken, number); - advance(); - } else { - advance(); - if (nexttoken.id === '%') { - advance('%'); - if (number > 100) { - warning("Expected a percentage and instead saw '{a}'", - token, number); - } - } else { - if (number > 255) { - warning("Expected a small number and instead saw '{a}'", - token, number); - } - } - } - } - advance(')'); - return true; - } else if (cssColorData[nexttoken.value] === true) { - advance(); - return true; + s = undefined; + } else if (typeof s === 'boolean') { + f = funct; + funct = functions[0]; + addlabel(v, 'var'); + s = funct; + funct = f; } - } else if (nexttoken.type === '(color)') { - advance(); - return true; - } - return false; - } - function cssLength() { - if (nexttoken.id === '-') { - advance('-'); - adjacent(); - } - if (nexttoken.type === '(number)') { - advance(); - if (nexttoken.type !== '(string)' && - cssLengthData[nexttoken.value] === true) { - adjacent(); - advance(); - } else if (+token.value !== 0) { - warning("Expected a linear unit and instead saw '{a}'.", - nexttoken, nexttoken.value); - } - return true; - } - return false; - } +// The name is in scope and defined in the current function. - function cssLineHeight() { - if (nexttoken.id === '-') { - advance('-'); - adjacent(); - } - if (nexttoken.type === '(number)') { - advance(); - if (nexttoken.type !== '(string)' && - cssLengthData[nexttoken.value] === true) { - adjacent(); - advance(); - } - return true; - } - return false; - } + if (funct === s) { - function cssWidth() { - if (nexttoken.identifier) { - switch (nexttoken.value) { - case 'thin': - case 'medium': - case 'thick': - advance(); - return true; - } - } else { - return cssLength(); - } - } +// Change 'unused' to 'var', and reject labels. - function cssMargin() { - if (nexttoken.identifier) { - if (nexttoken.value === 'auto') { - advance(); - return true; - } - } else { - return cssLength(); - } - } - - function cssAttr() { - if (nexttoken.identifier && nexttoken.value === 'attr') { - advance(); - advance('('); - if (!nexttoken.identifier) { - warning("Expected a name and instead saw '{a}'.", - nexttoken, nexttoken.value); - } - advance(); - advance(')'); - return true; - } - return false; - } + switch (funct[v]) { + case 'unused': + funct[v] = 'var'; + break; + case 'unction': + funct[v] = 'function'; + this['function'] = true; + break; + case 'function': + this['function'] = true; + break; + case 'label': + warning("'{a}' is a statement label.", token, v); + break; + } - function cssCommaList() { - while (nexttoken.id !== ';') { - if (!cssName() && !cssString()) { - warning("Expected a name and instead saw '{a}'.", - nexttoken, nexttoken.value); - } - if (nexttoken.id !== ',') { - return true; - } - advance(','); - } - } +// The name is not defined in the function. If we are in the global scope, +// then we have an undefined variable. - function cssCounter() { - if (nexttoken.identifier && nexttoken.value === 'counter') { - advance(); - advance('('); - if (!nexttoken.identifier) { - } - advance(); - if (nexttoken.id === ',') { - advance(','); - if (nexttoken.type !== '(string)') { - warning("Expected a string and instead saw '{a}'.", - nexttoken, nexttoken.value); - } - advance(); - } - advance(')'); - return true; - } - if (nexttoken.identifier && nexttoken.value === 'counters') { - advance(); - advance('('); - if (!nexttoken.identifier) { - warning("Expected a name and instead saw '{a}'.", - nexttoken, nexttoken.value); - } - advance(); - if (nexttoken.id === ',') { - advance(','); - if (nexttoken.type !== '(string)') { - warning("Expected a string and instead saw '{a}'.", - nexttoken, nexttoken.value); - } - advance(); - } - if (nexttoken.id === ',') { - advance(','); - if (nexttoken.type !== '(string)') { - warning("Expected a string and instead saw '{a}'.", - nexttoken, nexttoken.value); + } else if (funct['(global)']) { + if (option.undef && typeof predefined[v] !== 'boolean') { + warning("'{a}' is not defined.", token, v); } - advance(); - } - advance(')'); - return true; - } - return false; - } + note_implied(token); +// If the name is already defined in the current +// function, but not as outer, then there is a scope error. - function cssShape() { - var i; - if (nexttoken.identifier && nexttoken.value === 'rect') { - advance(); - advance('('); - for (i = 0; i < 4; i += 1) { - if (!cssLength()) { - warning("Expected a number and instead saw '{a}'.", - nexttoken, nexttoken.value); + } else { + switch (funct[v]) { + case 'closure': + case 'function': + case 'var': + case 'unused': + warning("'{a}' used out of scope.", token, v); + break; + case 'label': + warning("'{a}' is a statement label.", token, v); break; + case 'outer': + case 'global': + break; + default: + +// If the name is defined in an outer function, make an outer entry, and if +// it was unused, make it var. + + if (s === true) { + funct[v] = true; + } else if (s === null) { + warning("'{a}' is not allowed.", token, v); + note_implied(token); + } else if (typeof s !== 'object') { + if (option.undef) { + warning("'{a}' is not defined.", token, v); + } else { + funct[v] = true; + } + note_implied(token); + } else { + switch (s[v]) { + case 'function': + case 'unction': + this['function'] = true; + s[v] = 'closure'; + funct[v] = s['(global)'] ? 'global' : 'outer'; + break; + case 'var': + case 'unused': + s[v] = 'closure'; + funct[v] = s['(global)'] ? 'global' : 'outer'; + break; + case 'closure': + case 'parameter': + funct[v] = s['(global)'] ? 'global' : 'outer'; + break; + case 'label': + warning("'{a}' is a statement label.", token, v); + break; + } + } } } - advance(')'); - return true; + return this; + }, + led: function () { + error("Expected an operator and instead saw '{a}'.", + nexttoken, nexttoken.value); } - return false; - } + }; - function cssUrl() { - var url; - if (nexttoken.identifier && nexttoken.value === 'url') { - nexttoken = lex.range('(', ')'); - url = nexttoken.value; - advance(); - if (option.safe && ux.test(url)) { - error("ADsafe URL violation."); - } - urls.push(url); - return true; + type('(regexp)', function () { + return this; + }); + + +// ECMAScript parser + + ultimate('(begin)'); + ultimate('(end)'); + ultimate('(error)'); + delim(''); + delim(''); + delim('}'); + delim(')'); + delim(']'); + delim('"'); + delim("'"); + delim(';'); + delim(':'); + delim(','); + delim('#'); + delim('@'); + reserve('else'); + reserve('case'); + reserve('catch'); + reserve('default'); + reserve('finally'); + reservevar('arguments', function (x) { + if (strict_mode && funct['(global)']) { + warning("Strict violation.", x); + } else if (option.safe) { + warning("ADsafe violation.", x); } - return false; - } + }); + reservevar('eval', function (x) { + if (option.safe) { + warning("ADsafe violation.", x); + } + }); + reservevar('false'); + reservevar('Infinity'); + reservevar('NaN'); + reservevar('null'); + reservevar('this', function (x) { + if (strict_mode && ((funct['(statement)'] && //// correct this test. + funct['(name)'].charAt(0) > 'Z') || funct['(global)'])) { + warning("Strict violation.", x); + } else if (option.safe) { + warning("ADsafe violation.", x); + } + }); + reservevar('true'); + reservevar('undefined'); + assignop('='); + assignop('+='); + assignop('-='); + assignop('*='); + assignop('/=').nud = function () { + error("A regular expression literal can be confused with '/='."); + }; + assignop('%='); + assignop('&=', true); + assignop('|=', true); + assignop('^=', true); + assignop('<<=', true); + assignop('>>=', true); + assignop('>>>=', true); + infix('?', 30, function (left, that) { + that.first = left; + that.second = expression(10); + spaces(); + advance(':'); + spaces(); + that.third = expression(10); + return that; + }); - cssAny = [cssUrl, function () { - for (;;) { - if (nexttoken.identifier) { - switch (nexttoken.value.toLowerCase()) { - case 'url': - cssUrl(); - break; - case 'expression': - warning("Unexpected expression '{a}'.", - nexttoken, nexttoken.value); - advance(); - break; - default: - advance(); - } - } else { - if (nexttoken.id === ';' || nexttoken.id === '!' || - nexttoken.id === '(end)' || nexttoken.id === '}') { - return true; - } - advance(); + infix('||', 40); + infix('&&', 50); + bitwise('|', 70); + bitwise('^', 80); + bitwise('&', 90); + relation('==', '==='); + relation('==='); + relation('!=', '!=='); + relation('!=='); + relation('<'); + relation('>'); + relation('<='); + relation('>='); + bitwise('<<', 120); + bitwise('>>', 120); + bitwise('>>>', 120); + infix('in', 120); + infix('instanceof', 120); + infix('+', 130, function (left, that) { + var right = expression(130); + if (left && right && left.id === '(string)' && right.id === '(string)') { + left.value += right.value; + left.thru = right.thru; + if (jx.test(left.value)) { + warning("JavaScript URL.", left); } + return left; } - }]; + that.first = left; + that.second = right; + return that; + }); + prefix('+', 'num'); + prefix('+++', function () { + warning("Confusing pluses."); + this.first = expression(150); + this.arity = 'prefix'; + return this; + }); + infix('+++', 130, function (left) { + warning("Confusing pluses."); + this.first = left; + this.second = expression(130); + return this; + }); + infix('-', 130); + prefix('-'); + prefix('---', function () { + warning("Confusing minuses."); + this.first = expression(150); + this.arity = 'prefix'; + return this; + }); + infix('---', 130, function (left) { + warning("Confusing minuses."); + this.first = left; + this.second = expression(130); + return this; + }); + infix('*', 140); + infix('/', 140); + infix('%', 140); - cssBorderStyle = [ - 'none', 'hidden', 'dotted', 'dashed', 'solid', 'double', 'ridge', - 'inset', 'outset' - ]; + suffix('++'); + prefix('++'); - cssAttributeData = { - background: [ - true, 'background-attachment', 'background-color', - 'background-image', 'background-position', 'background-repeat' - ], - 'background-attachment': ['scroll', 'fixed'], - 'background-color': ['transparent', cssColor], - 'background-image': ['none', cssUrl], - 'background-position': [ - 2, [cssLength, 'top', 'bottom', 'left', 'right', 'center'] - ], - 'background-repeat': [ - 'repeat', 'repeat-x', 'repeat-y', 'no-repeat' - ], - 'border': [true, 'border-color', 'border-style', 'border-width'], - 'border-bottom': [true, 'border-bottom-color', 'border-bottom-style', 'border-bottom-width'], - 'border-bottom-color': cssColor, - 'border-bottom-style': cssBorderStyle, - 'border-bottom-width': cssWidth, - 'border-collapse': ['collapse', 'separate'], - 'border-color': ['transparent', 4, cssColor], - 'border-left': [ - true, 'border-left-color', 'border-left-style', 'border-left-width' - ], - 'border-left-color': cssColor, - 'border-left-style': cssBorderStyle, - 'border-left-width': cssWidth, - 'border-right': [ - true, 'border-right-color', 'border-right-style', 'border-right-width' - ], - 'border-right-color': cssColor, - 'border-right-style': cssBorderStyle, - 'border-right-width': cssWidth, - 'border-spacing': [2, cssLength], - 'border-style': [4, cssBorderStyle], - 'border-top': [ - true, 'border-top-color', 'border-top-style', 'border-top-width' - ], - 'border-top-color': cssColor, - 'border-top-style': cssBorderStyle, - 'border-top-width': cssWidth, - 'border-width': [4, cssWidth], - bottom: [cssLength, 'auto'], - 'caption-side' : ['bottom', 'left', 'right', 'top'], - clear: ['both', 'left', 'none', 'right'], - clip: [cssShape, 'auto'], - color: cssColor, - content: [ - 'open-quote', 'close-quote', 'no-open-quote', 'no-close-quote', - cssString, cssUrl, cssCounter, cssAttr - ], - 'counter-increment': [ - cssName, 'none' - ], - 'counter-reset': [ - cssName, 'none' - ], - cursor: [ - cssUrl, 'auto', 'crosshair', 'default', 'e-resize', 'help', 'move', - 'n-resize', 'ne-resize', 'nw-resize', 'pointer', 's-resize', - 'se-resize', 'sw-resize', 'w-resize', 'text', 'wait' - ], - direction: ['ltr', 'rtl'], - display: [ - 'block', 'compact', 'inline', 'inline-block', 'inline-table', - 'list-item', 'marker', 'none', 'run-in', 'table', 'table-caption', - 'table-column', 'table-column-group', 'table-footer-group', - 'table-header-group', 'table-row', 'table-row-group' - ], - 'empty-cells': ['show', 'hide'], - 'float': ['left', 'none', 'right'], - font: [ - 'caption', 'icon', 'menu', 'message-box', 'small-caption', 'status-bar', - true, 'font-size', 'font-style', 'font-weight', 'font-family' - ], - 'font-family': cssCommaList, - 'font-size': [ - 'xx-small', 'x-small', 'small', 'medium', 'large', 'x-large', - 'xx-large', 'larger', 'smaller', cssLength - ], - 'font-size-adjust': ['none', cssNumber], - 'font-stretch': [ - 'normal', 'wider', 'narrower', 'ultra-condensed', - 'extra-condensed', 'condensed', 'semi-condensed', - 'semi-expanded', 'expanded', 'extra-expanded' - ], - 'font-style': [ - 'normal', 'italic', 'oblique' - ], - 'font-variant': [ - 'normal', 'small-caps' - ], - 'font-weight': [ - 'normal', 'bold', 'bolder', 'lighter', cssNumber - ], - height: [cssLength, 'auto'], - left: [cssLength, 'auto'], - 'letter-spacing': ['normal', cssLength], - 'line-height': ['normal', cssLineHeight], - 'list-style': [ - true, 'list-style-image', 'list-style-position', 'list-style-type' - ], - 'list-style-image': ['none', cssUrl], - 'list-style-position': ['inside', 'outside'], - 'list-style-type': [ - 'circle', 'disc', 'square', 'decimal', 'decimal-leading-zero', - 'lower-roman', 'upper-roman', 'lower-greek', 'lower-alpha', - 'lower-latin', 'upper-alpha', 'upper-latin', 'hebrew', 'katakana', - 'hiragana-iroha', 'katakana-oroha', 'none' - ], - margin: [4, cssMargin], - 'margin-bottom': cssMargin, - 'margin-left': cssMargin, - 'margin-right': cssMargin, - 'margin-top': cssMargin, - 'marker-offset': [cssLength, 'auto'], - 'max-height': [cssLength, 'none'], - 'max-width': [cssLength, 'none'], - 'min-height': cssLength, - 'min-width': cssLength, - opacity: cssNumber, - outline: [true, 'outline-color', 'outline-style', 'outline-width'], - 'outline-color': ['invert', cssColor], - 'outline-style': [ - 'dashed', 'dotted', 'double', 'groove', 'inset', 'none', - 'outset', 'ridge', 'solid' - ], - 'outline-width': cssWidth, - overflow: ['auto', 'hidden', 'scroll', 'visible'], - padding: [4, cssLength], - 'padding-bottom': cssLength, - 'padding-left': cssLength, - 'padding-right': cssLength, - 'padding-top': cssLength, - position: ['absolute', 'fixed', 'relative', 'static'], - quotes: [8, cssString], - right: [cssLength, 'auto'], - 'table-layout': ['auto', 'fixed'], - 'text-align': ['center', 'justify', 'left', 'right'], - 'text-decoration': ['none', 'underline', 'overline', 'line-through', 'blink'], - 'text-indent': cssLength, - 'text-shadow': ['none', 4, [cssColor, cssLength]], - 'text-transform': ['capitalize', 'uppercase', 'lowercase', 'none'], - top: [cssLength, 'auto'], - 'unicode-bidi': ['normal', 'embed', 'bidi-override'], - 'vertical-align': [ - 'baseline', 'bottom', 'sub', 'super', 'top', 'text-top', 'middle', - 'text-bottom', cssLength - ], - visibility: ['visible', 'hidden', 'collapse'], - 'white-space': ['normal', 'pre', 'nowrap'], - width: [cssLength, 'auto'], - 'word-spacing': ['normal', cssLength], - 'z-index': ['auto', cssNumber] - }; + suffix('--'); + prefix('--'); + prefix('delete', function () { + one_space(); + var p = expression(0); + if (!p || (p.id !== '.' && p.id !== '[')) { + warning("Only properties should be deleted."); + } + this.first = p; + return this; + }); - function styleAttribute() { - var v; - while (nexttoken.id === '*' || nexttoken.id === '#' || nexttoken.value === '_') { - if (!option.css) { - warning("Unexpected '{a}'.", nexttoken, nexttoken.value); + + prefix('~', function () { + no_space_only(); + if (option.bitwise) { + warning("Unexpected '{a}'.", this, '~'); + } + expression(150); + return this; + }); + prefix('!', function () { + no_space_only(); + this.first = expression(150); + this.arity = 'prefix'; + if (bang[this.first.id] === true) { + warning("Confusing use of '{a}'.", this, '!'); + } + return this; + }); + prefix('typeof'); + prefix('new', function () { + one_space(); + var c = expression(160), i; + if (c.id !== 'function') { + if (c.identifier) { + switch (c.value) { + case 'Object': + warning("Use the object literal notation {}.", token); + break; + case 'Array': + if (nexttoken.id !== '(') { + warning("Use the array literal notation [].", token); + } else { + advance('('); + if (nexttoken.id === ')') { + warning("Use the array literal notation [].", token); + } + advance(')'); + } + this.first = c; + return this; + case 'Number': + case 'String': + case 'Boolean': + case 'Math': + case 'JSON': + warning("Do not use {a} as a constructor.", token, c.value); + break; + case 'Function': + if (!option.evil) { + warning("The Function constructor is eval."); + } + break; + case 'Date': + case 'RegExp': + break; + default: + if (c.id !== 'function') { + i = c.value.substr(0, 1); + if (option.newcap && (i < 'A' || i > 'Z')) { + warning( + "A constructor name should start with an uppercase letter.", + token); + } + } + } + } else { + if (c.id !== '.' && c.id !== '[' && c.id !== '(') { + warning("Bad constructor.", token); + } } - advance(); + } else { + warning("Weird construction. Delete 'new'.", this); } - if (nexttoken.id === '-') { - if (!option.css) { - warning("Unexpected '{a}'.", nexttoken, nexttoken.value); + if (nexttoken.id !== '(') { + warning("Missing '()' invoking a constructor."); + } + this.first = c; + return this; + }); + + infix('(', 160, function (left, that) { + no_space_only(prevtoken, token); + if (!left.immed && left.id === 'function') { + warning("Wrap an immediate function invocation in parentheses " + + "to assist the reader in understanding that the expression " + + "is the result of a function, and not the function itself."); + } + var p = []; + if (left) { + if (left.type === '(identifier)') { + if (left.value.match(/^[A-Z]([A-Z0-9_$]*[a-z][A-Za-z0-9_$]*)?$/)) { + if (left.value !== 'Number' && left.value !== 'String' && + left.value !== 'Boolean' && + left.value !== 'Date') { + if (left.value === 'Math') { + warning("Math is not a function.", left); + } else if (option.newcap) { + warning( +"Missing 'new' prefix when invoking a constructor.", left); + } + } + } + } else if (left.id === '.') { + if (option.safe && left.first.value === 'Math' && + left.second === 'random') { + warning("ADsafe violation.", left); + } } - advance('-'); - if (!nexttoken.identifier) { - warning("Expected a non-standard style attribute and instead saw '{a}'.", - nexttoken, nexttoken.value); + } + if (nexttoken.id !== ')') { + no_space(); + for (;;) { + p.push(expression(10)); + if (nexttoken.id !== ',') { + break; + } + comma(); } - advance(); - return cssAny; - } else { - if (!nexttoken.identifier) { - warning("Excepted a style attribute, and instead saw '{a}'.", - nexttoken, nexttoken.value); + } + no_space(); + advance(')'); + if (typeof left === 'object') { + if (left.value === 'parseInt' && p.length === 1) { + warning("Missing radix parameter.", left); + } + if (!option.evil) { + if (left.value === 'eval' || left.value === 'Function' || + left.value === 'execScript') { + warning("eval is evil.", left); + } else if (p[0] && p[0].id === '(string)' && + (left.value === 'setTimeout' || + left.value === 'setInterval')) { + warning( + "Implied eval is evil. Pass a function instead of a string.", left); + } + } + if (!left.identifier && left.id !== '.' && left.id !== '[' && + left.id !== '(' && left.id !== '&&' && left.id !== '||' && + left.id !== '?') { + warning("Bad invocation.", left); + } + } + that.first = left; + that.second = p; + return that; + }, true); + + prefix('(', function () { + no_space(); + if (nexttoken.id === 'function') { + nexttoken.immed = true; + } + var v = expression(0); + no_space(); + advance(')', this); + if (v.id === 'function') { + if (nexttoken.id === '(') { + warning( +"Move the invocation into the parens that contain the function.", nexttoken); } else { - if (cssAttributeData.hasOwnProperty(nexttoken.value)) { - v = cssAttributeData[nexttoken.value]; - } else { - v = cssAny; - if (!option.css) { - warning("Unrecognized style attribute '{a}'.", - nexttoken, nexttoken.value); + warning( +"Do not wrap function literals in parens unless they are to be immediately invoked.", + this); + } + } + return v; + }); + + infix('.', 170, function (left, that) { + no_space(prevtoken, token); + no_space(); + var m = identifier(); + if (typeof m === 'string') { + countMember(m); + } + that.first = left; + that.second = m; + if (left && left.value === 'arguments' && + (m === 'callee' || m === 'caller')) { + warning("Avoid arguments.{a}.", left, m); + } else if (!option.evil && left && left.value === 'document' && + (m === 'write' || m === 'writeln')) { + warning("document.write can be a form of eval.", left); + } else if (option.adsafe) { + if (left && left.value === 'ADSAFE') { + if (m === 'id' || m === 'lib') { + warning("ADsafe violation.", that); + } else if (m === 'go') { + if (xmode !== 'script') { + warning("ADsafe violation.", that); + } else if (adsafe_went || nexttoken.id !== '(' || + peek(0).id !== '(string)' || + peek(0).value !== adsafe_id || + peek(1).id !== ',') { + error("ADsafe violation: go.", that); } + adsafe_went = true; + adsafe_may = false; } } - advance(); - return v; } - } + if (!option.evil && (m === 'eval' || m === 'execScript')) { + warning('eval is evil.'); + } else if (option.safe) { + for (;;) { + if (banned[m] === true) { + warning("ADsafe restricted word '{a}'.", token, m); + } + if (typeof predefined[left.value] !== 'boolean' || + nexttoken.id === '(') { + break; + } + if (standard_member[m] === true) { + if (nexttoken.id === '.') { + warning("ADsafe violation.", that); + } + break; + } + if (nexttoken.id !== '.') { + warning("ADsafe violation.", that); + break; + } + advance('.'); + token.first = that; + token.second = m; + that = token; + m = identifier(); + if (typeof m === 'string') { + countMember(m); + } + } + } + return that; + }, true); - function styleValue(v) { - var i = 0, - n, - once, - match, - round, - start = 0, - vi; - switch (typeof v) { - case 'function': - return v(); - case 'string': - if (nexttoken.identifier && nexttoken.value === v) { - advance(); - return true; + infix('[', 170, function (left, that) { + no_space_only(prevtoken, token); + no_space(); + var e = expression(0), s; + if (e && e.type === '(string)') { + if (option.safe && banned[e.value] === true) { + warning("ADsafe restricted word '{a}'.", that, e.value); + } else if (!option.evil && + (e.value === 'eval' || e.value === 'execScript')) { + warning("eval is evil.", that); + } else if (option.safe && + (e.value.charAt(0) === '_' || e.value.charAt(0) === '-')) { + warning("ADsafe restricted subscript '{a}'.", that, e.value); + } + countMember(e.value); + if (!option.sub && ix.test(e.value)) { + s = syntax[e.value]; + if (!s || !s.reserved) { + warning("['{a}'] is better written in dot notation.", + e, e.value); + } + } + } else if (!e || e.type !== '(number)' || e.value < 0) { + if (option.safe) { + warning('ADsafe subscripting.'); } - return false; } - for (;;) { - if (i >= v.length) { - return false; + advance(']', that); + no_space(prevtoken, token); + that.first = left; + that.second = e; + return that; + }, true); + + prefix('[', function () { + this.first = []; + while (nexttoken.id !== '(end)') { + while (nexttoken.id === ',') { + warning("Extra comma."); + advance(','); } - vi = v[i]; - i += 1; - if (vi === true) { + if (nexttoken.id === ']') { break; - } else if (typeof vi === 'number') { - n = vi; - vi = v[i]; - i += 1; - } else { - n = 1; } - match = false; - while (n > 0) { - if (styleValue(vi)) { - match = true; - n -= 1; - } else { + this.first.push(expression(10)); + if (nexttoken.id === ',') { + comma(); + if (nexttoken.id === ']' && !option.es5) { + warning("Extra comma.", token); break; } - } - if (match) { - return true; + } else { + break; } } - start = i; - once = []; - for (;;) { - round = false; - for (i = start; i < v.length; i += 1) { - if (!once[i]) { - if (styleValue(cssAttributeData[v[i]])) { - match = true; - round = true; - once[i] = true; - break; - } + advance(']', this); + return this; + }, 170); + + + function property_name() { + var id = optionalidentifier(true); + if (!id) { + if (nexttoken.id === '(string)') { + id = nexttoken.value; + if (option.adsafe && + (id.charAt(0) === '_' || + id.charAt(id.length - 1) === '_')) { + warning("Unexpected {a} in '{b}'.", token, + "dangling '_'", id); } - } - if (!round) { - return match; + advance(); + } else if (nexttoken.id === '(number)') { + id = nexttoken.value.toString(); + advance(); } } + return id; } - function substyle() { - var v; + + function functionparams() { + var i, t = nexttoken, p = []; + advance('('); + no_space(); + if (nexttoken.id === ')') { + no_space(); + advance(')'); + return; + } for (;;) { - if (nexttoken.id === '}' || nexttoken.id === '(end)' || - xquote && nexttoken.id === xquote) { - return; - } - while (nexttoken.id === ';') { - warning("Misplaced ';'."); - advance(';'); + i = identifier(); + p.push(i); + addlabel(i, 'parameter'); + if (nexttoken.id === ',') { + comma(); + } else { + no_space(); + advance(')', t); + return p; } - v = styleAttribute(); - advance(':'); - if (nexttoken.identifier && nexttoken.value === 'inherit') { - advance(); + } + } + + + function doFunction(func, name) { + var s = scope; + scope = Object.create(s); + funct = { + '(name)' : name || '"' + anonname + '"', + '(line)' : nexttoken.line, + '(context)' : funct, + '(breakage)' : 0, + '(loopage)' : 0, + '(scope)' : scope, + '(token)' : func + }; + token.funct = funct; + functions.push(funct); + if (name) { + addlabel(name, 'function'); + } + func.name = name || ''; + func.first = funct['(params)'] = functionparams(); + func.block = block(false); + + scope = s; + funct['(last)'] = token.line; + funct = funct['(context)']; + return func; + } + + + prefix('{', function () { + var get, i, j, name, p, set, seen = {}, t; + this.arity = 'prefix'; + this.first = []; + while (nexttoken.id !== '}') { + +// JSLint recognizes the ES5 extension for get/set in object literals, +// but requires that they be used in pairs. + + if (nexttoken.value === 'get' && peek().id !== ':') { + if (!option.es5) { + warning("get/set are ES5 features."); + } + get = nexttoken; + one_space_only(); + advance('get'); + name = nexttoken; + i = property_name(); + if (!i) { + error("Missing property name."); + } + doFunction(get, ''); + if (funct['(loopage)']) { + warning("Don't make functions within a loop.", t); + } + p = get.first; + if (p) { + warning("Unexpected parameter '{a}' in get {b} function.", t, p[0], i); + } + comma(); + set = nexttoken; + spaces(); + advance('set'); + one_space_only(); + j = property_name(); + if (i !== j) { + error("Expected '{a}' and instead saw '{b}'.", token, i, j); + } + doFunction(set, ''); + p = set.first; + if (!p || p.length !== 1 || p[0] !== 'value') { + warning("Expected (value) in set {a} function.", t, i); + } + name.first = [get, set]; } else { - styleValue(v); + name = nexttoken; + i = property_name(); + if (typeof i !== 'string') { + error("Missing property name."); + } + advance(':'); + spaces(); + name.first = expression(10); } - while (nexttoken.id !== ';' && nexttoken.id !== '!' && - nexttoken.id !== '}' && nexttoken.id !== '(end)' && - nexttoken.id !== xquote) { - warning("Unexpected token '{a}'.", nexttoken, nexttoken.value); - advance(); + this.first.push(name); + if (seen[i] === true) { + warning("Duplicate member '{a}'.", nexttoken, i); } - if (nexttoken.id === '!') { - advance('!'); - adjacent(); - if (nexttoken.identifier && nexttoken.value === 'important') { - advance(); - } else { - warning("Expected '{a}' and instead saw '{b}'.", - nexttoken, 'important', nexttoken.value); + seen[i] = true; + countMember(i); + if (nexttoken.id !== ',') { + break; + } + for (;;) { + comma(); + if (nexttoken.id !== ',') { + break; } + warning("Extra comma."); } - if (nexttoken.id === '}' || nexttoken.id === xquote) { - warning("Missing '{a}'.", nexttoken, ';'); - } else { - advance(';'); + if (nexttoken.id === '}' && !option.es5) { + warning("Extra comma.", token); } } - } + advance('}', this); + return this; + }); - function stylePattern() { - var name; - if (nexttoken.id === '{') { - warning("Expected a style pattern, and instead saw '{a}'.", nexttoken, - nexttoken.id); - } else if (nexttoken.id === '@') { - advance('@'); - name = nexttoken.value; - if (nexttoken.identifier && atrule[name] === true) { - advance(); - return name; - } - warning("Expected an at-rule, and instead saw @{a}.", nexttoken, name); + stmt('{', function () { + warning("Expected to see a statement and instead saw a block."); + this.arity = 'statement'; + this.block = statements(); + this.disrupt = this.block.disrupt; + advance('}'); + return this; + }); + + + stmt('var', function () { + +// JavaScript does not have block scope. It only has function scope. So, +// declaring a variable in a block can have unexpected consequences. + +// var.first will contain an array, the array containing name tokens +// and assignment tokens. + + var assign, id, name; + + if (funct['(onevar)'] && option.onevar) { + warning("Too many var statements."); + } else if (!funct['(global)']) { + funct['(onevar)'] = true; } + this.arity = 'statement'; + this.first = []; for (;;) { - if (nexttoken.identifier) { - if (!htmltag.hasOwnProperty(nexttoken.value)) { - warning("Expected a tagName, and instead saw {a}.", - nexttoken, nexttoken.value); + spaces(); + name = nexttoken; + id = identifier(); + if (funct['(global)'] && predefined[id] === false) { + warning("Redefinition of '{a}'.", token, id); + } + addlabel(id, 'unused'); + + if (nexttoken.id === '=') { + assign = nexttoken; + assign.first = name; + spaces(); + advance('='); + spaces(); + if (nexttoken.id === 'undefined') { + warning("It is not necessary to initialize '{a}' to 'undefined'.", token, id); } - advance(); - } else { - switch (nexttoken.id) { - case '>': - case '+': - advance(); - if (!nexttoken.identifier || - !htmltag.hasOwnProperty(nexttoken.value)) { - warning("Expected a tagName, and instead saw {a}.", - nexttoken, nexttoken.value); - } - advance(); - break; - case ':': - advance(':'); - if (pseudorule[nexttoken.value] !== true) { - warning("Expected a pseudo, and instead saw :{a}.", - nexttoken, nexttoken.value); - } - advance(); - if (nexttoken.value === 'lang') { - advance('('); - if (!nexttoken.identifier) { - warning("Expected a lang code, and instead saw :{a}.", - nexttoken, nexttoken.value); - } - advance(')'); - } - break; - case '#': - advance('#'); - if (!nexttoken.identifier) { - warning("Expected an id, and instead saw #{a}.", - nexttoken, nexttoken.value); - } - advance(); - break; - case '*': - advance('*'); - break; - case '.': - advance('.'); - if (!nexttoken.identifier) { - warning("Expected a class, and instead saw #.{a}.", - nexttoken, nexttoken.value); - } - advance(); - break; - case '[': - advance('['); - if (!nexttoken.identifier) { - warning("Expected an attribute, and instead saw [{a}].", + if (peek(0).id === '=' && nexttoken.identifier) { + error("Variable {a} was not declared correctly.", nexttoken, nexttoken.value); - } - advance(); - if (nexttoken.id === '=' || nexttoken.id === '~=' || - nexttoken.id === '|=') { - advance(); - if (nexttoken.type !== '(string)') { - warning("Expected a string, and instead saw {a}.", - nexttoken, nexttoken.value); - } - advance(); - } - advance(']'); - break; - default: - error("Expected a CSS selector, and instead saw {a}.", - nexttoken, nexttoken.value); } + assign.second = expression(0); + assign.arity = 'infix'; + this.first.push(assign); + } else { + this.first.push(name); } - if (nexttoken.id === '' || nexttoken.id === '{' || - nexttoken.id === '(end)') { - return ''; - } - if (nexttoken.id === ',') { - advance(','); + if (nexttoken.id !== ',') { + break; } + comma(); } - } + return this; + }); - function styles() { - while (nexttoken.id !== '' && nexttoken.id !== '(end)') { - stylePattern(); - xmode = 'styleproperty'; - if (nexttoken.id === ';') { - advance(';'); - } else { - advance('{'); - substyle(); - xmode = 'style'; - advance('}'); - } + stmt('function', function () { + one_space(); + if (inblock) { + warning( +"Function statements should not be placed in blocks. Use a function expression or move the statement to the top of the outer function.", token); } - } - + var i = identifier(); + if (i) { + addlabel(i, 'unction'); + no_space_only(); + } + doFunction(this, i, true); + if (nexttoken.id === '(' && nexttoken.line === token.line) { + error( +"Function statements are not invocable. Wrap the whole function invocation in parens."); + } + this.arity = 'statement'; + return this; + }); -// HTML parsing. + prefix('function', function () { + one_space(); + var i = optionalidentifier(); + if (i) { + no_space_only(); + } + doFunction(this, i); + if (funct['(loopage)']) { + warning("Don't make functions within a loop."); + } + this.arity = 'function'; + return this; + }); - function doBegin(n) { - if (n !== 'html' && !option.fragment) { - if (n === 'div' && option.adsafe) { - error("ADSAFE: Use the fragment option."); - } else { - error("Expected '{a}' and instead saw '{b}'.", - token, 'html', n); + stmt('if', function () { + var t = nexttoken; + one_space(); + advance('('); + no_space(); + this.arity = 'statement'; + this.first = expression(20); + if (nexttoken.id === '=') { + warning("Expected a conditional expression and instead saw an assignment."); + advance('='); + expression(20); + } + no_space(); + advance(')', t); + one_space(); + this.block = block(true); + if (nexttoken.id === 'else') { + one_space(); + advance('else'); + one_space(); + this['else'] = nexttoken.id === 'if' || nexttoken.id === 'switch' ? + statement(true) : block(true); + if (this['else'].disrupt && this.block.disrupt) { + this.disrupt = true; } } + return this; + }); + + stmt('try', function () { + +// try.first The catch variable +// try.second The catch clause +// try.third The finally clause +// try.block The try block + + var b, e, s, t; if (option.adsafe) { - if (n === 'html') { - error("Currently, ADsafe does not operate on whole HTML documents. It operates on
' + s[i] + ' ' +
- implied[s[i]].join(' ') +
- '';
+ if (data.errors) {
+ for (i = 0; i < data.errors.length; i += 1) {
+ c = data.errors[i];
+ if (c) {
+ e = c.evidence || '';
+ o.push('Problem' + (isFinite(c.line) ? ' at line ' + + c.line + ' character ' + c.character : '') + + ': ' + c.reason.entityify() + + '
' + + (e && (e.length > 80 ? e.slice(0, 77) + '...' : + e).entityify()) + '
'); + } + } + } + + if (data.implieds) { + s = []; + for (i = 0; i < data.implieds.length; i += 1) { + s[i] = '' + data.implieds[i].name + ' ' +
+ data.implieds[i].line + '';
}
o.push('Implied global: ' + s.join(', ') + '
'); - c = true; - } - for (i = 0; i < k; i += 1) { - c = JSLINT.errors[i]; - if (c) { - e = c.evidence || ''; - o.push('Problem' + (isFinite(c.line) ? ' at line ' + (c.line + 1) + - ' character ' + (c.character + 1) : '') + - ': ' + c.reason.entityify() + - '
' + - (e && (e.length > 80 ? e.slice(0, 77) + '...' : - e).entityify()) + '
'); + } + + if (data.unused) { + s = []; + for (i = 0; i < data.unused.length; i += 1) { + s[i] = '' + data.unused[i].name + ' ' +
+ data.unused[i].line + ' ' +
+ data.unused[i]['function'] + '';
}
+ o.push('Unused variable: ' + s.join(', ') + '
'); } - o.push('JSON: bad.
'); } + o.push('JSON: good.
'); - } else { - o.push('JSON: bad.
'); - } - } else { - o.push('CSS.
'); + } else if (data.json && !err) { + o.push('JSON: good.
'); + } else if (data.globals) { + o.push('/*members ';
+ l = 10;
+ for (i = 0; i < a.length; i += 1) {
+ k = a[i];
+ n = k.name();
+ if (l + n.length > 72) {
+ o.push(m + '
');
+ m = ' ';
+ l = 1;
}
+ l += n.length + 2;
+ if (data.member[k] === 1) {
+ n = '' + n + '';
+ }
+ if (i < a.length - 1) {
+ n += ', ';
+ }
+ m += n;
}
+ o.push(m + '
*/');
}
- o.push('/*members ';
- l = 10;
- for (i = 0; i < a.length; i += 1) {
- k = a[i];
- n = k.name();
- if (l + n.length > 72) {
- o.push(m + '
');
- m = ' ';
- l = 1;
- }
- l += n.length + 2;
- if (member[k] === 1) {
- n = '' + n + '';
- }
- if (i < a.length - 1) {
- n += ', ';
- }
- m += n;
- }
- o.push(m + '
*/');
+ o.push('