Simulated "detections" with periods > observation length

[almcewen0]

Hello, I've been working with some PsrPopPy-simulated data and have found that there are pulsars being "detected" by the survey with periods that are much longer than the duration of a survey scan. It is straightforward enough to omit these sources from my results, though it would probably better for PsrPopPy to recognize that these sources would be highly unlikely to be detected. I'll attach some relevant files and code.

survey/pointing files I'm using:
gbt820_model_files.zip

code snippet:

# which surveys will be used to make the population
surveys = ['GBNCC','AODRIFT','LOFAR','PALFA3','PMSURV','PKS70'] 
# number of detections from a given survey. should match number of surveys
ndets = [670,75,300,207,842,298]
# spin period parameters
pdps = [3,1] # PSRs
pop = populate.generate(sum(ndets),  
                surveyList=surveys,
                radialDistType='lfl06',
                siDistPars=[-1.41, 0.96], # non-standard SI distribution
                duty_percent=6.,
                pDistPars=pdps,
                electronModel='lmt85',
                nostdout=True # switches off output to stdout
                )
 
# now run "dosurvey.run" on the model. Provide a list of surveys to use
surveyPopulations = dosurvey.run(pop, ['GBT820'], nostdout=True)

let me know if there is more you need.

[samb8s]

Thanks that's well spotted! Would you mind putting together a pull request with your suggested fix?

…

On Tue, 9 May 2023 at 09:50, almcewen0 ***@***.***> wrote: Hello, I've been working with some PsrPopPy-simulated data and have found that there are pulsars being "detected" by the survey with periods that are much longer than the duration of a survey scan. It is straightforward enough to omit these sources from my results, though it would probably better for PsrPopPy to recognize that these sources would be highly unlikely to be detected. I'll attach some relevant files and code. survey/pointing files I'm using: gbt820_model_files.zip <https://github.com/samb8s/PsrPopPy/files/11425223/gbt820_model_files.zip> code snippet: # which surveys will be used to make the population surveys = ['GBNCC','AODRIFT','LOFAR','PALFA3','PMSURV','PKS70'] # number of detections from a given survey. should match number of surveys ndets = [670,75,300,207,842,298] # spin period parameters pdps = [3,1] # PSRs pop = populate.generate(sum(ndets), surveyList=surveys, radialDistType='lfl06', siDistPars=[-1.41, 0.96], # non-standard SI distribution duty_percent=6., pDistPars=pdps, electronModel='lmt85', nostdout=True # switches off output to stdout ) # now run "dosurvey.run" on the model. Provide a list of surveys to use surveyPopulations = dosurvey.run(pop, ['GBT820'], nostdout=True) let me know if there is more you need. — Reply to this email directly, view it on GitHub <#17>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAA53CXFQ5A3YOV7AYLMYXDXFIANBANCNFSM6AAAAAAX26YUSU> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>