Skip to content

Add error handling when passing queries to the API #5

@samLozier

Description

@samLozier

Improperly formatted queries can produce weird results. For example:

Products.objects.sync_all(session, id=1111111111)

This looks like it should search for a product with id=1111111111 and sync it if it's found. However this query is improperly formatted, instead it will drop the query portion silently and sync ALL products that are associated with that session/shop.

The logic should be changed such that it will raise an exception due to the improper query and fail loudly rather than tying up system resources for a (potentially) very long running sync.

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or requesthelp wantedExtra attention is needed

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions