Enhancement request: contents_pillar support for pkgrepo.managed

[udf2457]

Sort of building on #55851 , so maybe you woud prefer to to broaden that original enhancement request as "Wider contents_pillar support throughout SaltStack" ? If its easy enough to refactor the codebase so that contents_pillar is available in any function where a fileserver salt:// can be used, I guess that would be the dream option !

Anyway, coming back to this specific request, looking at the docs, pkgrepo.managed has key_url and key_text but going by the docs neither have support for equivalent to contents_pillar.

[Ch3LL]

key_url and key_text are specific args to specify particular repo file settings. I'm not sure what repo file setting contents_pillar would mirror. You should be able to just use jinja to set pillar data on a particular repo file setting.

[udf2457]

Sure I maybe could use jinja (don't know, haven't tried), but the beauty of contents_pillar is that you don't need to mess around with jinja syntax, just - contents_pillar: $pillar_name and job's done. Shorter, more readable, what's not to love !

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

If this issue is closed prematurely, please leave a comment and we will gladly reopen the issue.

[udf2457]

Not stale !

[stale]

Thank you for updating this issue. It is no longer marked as stale.

[Ch3LL]

contents_pillar is used to add the entire contents from that given pillar to a file, not just a portion of the file. I dont see the advantage of adding contents_pillar to pkgrepo.managed when at that point you should just use file.managed

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

If this issue is closed prematurely, please leave a comment and we will gladly reopen the issue.

[udf2457]

not stale

[stale]

Thank you for updating this issue. It is no longer marked as stale.