SIP peer data not in pillar

[borutmrak]

If you want to manage sip.conf in salt, it needs to contain passwords, which are therefore visible to all minions. Even SIP trunk password must be visible. Can't have that...

I just extended this formula to pull this private data from pillar, should I prepare a pull request? I actually did more (generating a simple dialplan based on users/extensions/dids), but it needs cleaning up first. Moving passwords to pillar is the most important thing to do IMO.

[0xf10e]

Sounds good, +1 from me. Let's first get the most important stuff, i.e. passwords, moved into Pillar and then talk about other improvements.

Am 22. April 2015 07:15:31 MESZ, schrieb Borut Mrak notifications@github.com:

If you want to manage sip.conf in salt, it needs to contain passwords,
which are therefore visible to all minions. Even SIP trunk password
must be visible. Can't have that...

I just extended this formula to pull this private data from pillar,
should I prepare a pull request? I actually did more (generating a
simple dialplan based on users/extensions/dids), but it needs cleaning
up first. Moving passwords to pillar is the most important thing to do
IMO.

---

Reply to this email directly or view it on GitHub:
#1

[iggy]

We like self contained PRs. So yeah, send over the pillar changes (which should probably be considered a bug) first and then look at making improvements.