Skip to content

Add module-info.java #2

@zimmi

Description

@zimmi

Hi!

I'd like to use fastexcel in a modularized application, so it would be fantastic if this project could add a module-info.java file.
Since it already requires Java 9, this should be as simple as putting a file like this into the package root:

module com.github.rzymek.opczip {
    exports com.github.rzymek.opczip;
    exports com.github.rzymek.opczip.reader;
    exports com.github.rzymek.opczip.reader.ordered;
    exports com.github.rzymek.opczip.reader.skipping;
}

Open questions:

  1. Should every package be exported?
  2. Are you open for a PR doing this? :)

I see that fastexcel itself has a baseline of Java 8, but there is a straightforward way to add a module-info.java there as well: https://maven.apache.org/plugins/maven-compiler-plugin/examples/module-info.html

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions