Skip to content

Commit 701b8d7

Browse files
committed
Merge bitcoin#34609: test: remove appveyor reference in comment
8834e4e test: remove appveyor reference in comment (Max Edwards) Pull request description: Appveyor is not longer used however the test still requires to check for permissions including 666 as otherwise the tests fail on Windows Fixes: bitcoin#32576 ACKs for top commit: maflcko: lgtm ACK 8834e4e hebasto: ACK 8834e4e. Tree-SHA512: 655b44e52da5e0c6c11c79bb4f92c701c6e0e66dce8d7791ccf1d64e4561fe4d1d5f37c1317bead89c88e4d7208a278925168b419482a6be17abf93d0ebc5dfa
2 parents b6b8f8a + 8834e4e commit 701b8d7

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

test/functional/tool_wallet.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -158,7 +158,7 @@ def test_tool_wallet_info(self):
158158
#
159159
# self.log.debug('Setting wallet file permissions to 400 (read-only)')
160160
# os.chmod(self.wallet_path, stat.S_IRUSR)
161-
# assert self.wallet_permissions() in ['400', '666'] # Sanity check. 666 because Appveyor.
161+
# assert self.wallet_permissions() in ['400', '666'] # Sanity check. 666 on Windows.
162162
# shasum_before = self.wallet_shasum()
163163
timestamp_before = self.wallet_timestamp()
164164
self.log.debug('Wallet file timestamp before calling info: {}'.format(timestamp_before))
@@ -169,7 +169,7 @@ def test_tool_wallet_info(self):
169169
self.log_wallet_timestamp_comparison(timestamp_before, timestamp_after)
170170
self.log.debug('Setting wallet file permissions back to 600 (read/write)')
171171
os.chmod(self.wallet_path, stat.S_IRUSR | stat.S_IWUSR)
172-
assert self.wallet_permissions() in ['600', '666'] # Sanity check. 666 because Appveyor.
172+
assert self.wallet_permissions() in ['600', '666'] # Sanity check. 666 on Windows.
173173
#
174174
# TODO: Wallet tool info should not write to the wallet file.
175175
# The following lines should be uncommented and the tests still succeed:

0 commit comments

Comments
 (0)