Why is numeric represented by `i32`?

[maxcountryman]

As I understand, the largest numeric is 999. Furthermore, there are no negative numerics. What's the rationale for choosing i32 here? It seems like u16 would be a more appropriate fit.

[zhangjiayin]

Thank you for your question and for taking an interest in the numeric representation choices in our project.
You're correct in noting that the largest numeric value we currently handle is 999, and we do not use negative numbers. At first glance, u16 indeed seems like a more fitting choice than i32 due to its sufficient range for our current needs while also being more memory efficient.

[zhangjiayin]

But, For keeping the API consistency , it would not be changed.

[maxcountryman]

For keeping the API consistency , it would not be changed.

You might consider rethinking that since this crate is not yet v1.0: yes it's a breaking change, but that's to be expected prior to the first major release.

[LucaCappelletti94]

For keeping the API consistency , it would not be changed.

You might consider rethinking that since this crate is not yet v1.0: yes it's a breaking change, but that's to be expected prior to the first major release.

I second that - using the best suited type goes a long way to avoid bugs.