File method doesn't unpack the file

[thomaslarsen]

When using the file method (method => 'file'), then the unpackeclipse exec is not invoked as it is missing when using the file method. This results in a fatal error:

Error: Could not find dependency Exec[upackeclipse] for Exec[modeclipse] at /opt/librarian-puppet/modules/eclipse/manifests/init.pp:109

It looks like you can just reuse the unpackeclipse from the wget method, except it will need to require the eclipsefile:

exec {"upackeclipse":
    command=>$unpackcommand,
    cwd=> $eclipse::params::executefrom,
    path=> $eclipse::params::execlaunchpaths,
    creates=>$finalcreates,
    logoutput=> on_failure,
    require=>File["eclipsefile"]
}