Notify StaticReads when constant values are defined or removed

When a constant value (not a module/class) is defined or removed across
files, the StaticRead objects that track constant resolution were not
being notified. This caused cross-file constant references to remain
untyped when the defining file was loaded after the referencing file.

Author: mame

lib/typeprof/core/ast/const.rb

@@ -83,9 +83,10 @@ def define0(genv)
         @cpath.define(genv) if @cpath
         @rhs.define(genv) if @rhs
         if @static_cpath
-          mod = genv.resolve_const(@static_cpath)
-          mod.add_def(self)
-          mod
+          cdef = genv.resolve_const(@static_cpath)
+          cdef.on_const_added(genv, @static_cpath)
+          cdef.add_def(self)
+          cdef
         else
           nil
         end
@@ -102,7 +103,9 @@ def define_copy(genv)
 
       def undefine0(genv)
         if @static_cpath
-          genv.resolve_const(@static_cpath).remove_def(self)
+          cdef = genv.resolve_const(@static_cpath)
+          cdef.remove_def(self)
+          cdef.on_const_removed(genv, @static_cpath)
         end
         @rhs.undefine(genv) if @rhs
         @cpath.undefine(genv) if @cpath

lib/typeprof/core/ast/sig_decl.rb

@@ -425,9 +425,10 @@ def attrs = { cpath: }
 
       def define0(genv)
         @type.define(genv)
-        mod = genv.resolve_const(@cpath)
-        mod.add_decl(self)
-        mod
+        cdef = genv.resolve_const(@cpath)
+        cdef.on_const_added(genv, @cpath)
+        cdef.add_decl(self)
+        cdef
       end
 
       def define_copy(genv)
@@ -438,7 +439,9 @@ def define_copy(genv)
       end
 
       def undefine0(genv)
-        genv.resolve_const(@cpath).remove_decl(self)
+        cdef = genv.resolve_const(@cpath)
+        cdef.remove_decl(self)
+        cdef.on_const_removed(genv, @cpath)
         @type.undefine(genv)
       end
 

lib/typeprof/core/env/value_entity.rb

@@ -28,5 +28,19 @@ def remove_def(def_)
     def exist?
       !@decls.empty? || !@defs.empty?
     end
+
+    def on_const_added(genv, cpath)
+      unless exist?
+        parent_mod = genv.resolve_cpath(cpath[0..-2])
+        genv.add_static_eval_queue(:inner_modules_changed, [parent_mod, cpath[-1]])
+      end
+    end
+
+    def on_const_removed(genv, cpath)
+      unless exist?
+        parent_mod = genv.resolve_cpath(cpath[0..-2])
+        genv.add_static_eval_queue(:inner_modules_changed, [parent_mod, cpath[-1]])
+      end
+    end
   end
 end

scenario/const/cross_file_value.rb

@@ -0,0 +1,44 @@
+## update: test0.rb
+module Foo
+  X = 1
+end
+
+## update: test1.rb
+module Foo
+  class Bar
+    def get_x
+      X
+    end
+  end
+end
+
+## assert: test1.rb
+module Foo
+  class Bar
+    def get_x: -> Integer
+  end
+end
+
+## update: test0.rb
+module Foo
+  # X is removed
+end
+
+## assert: test1.rb
+module Foo
+  class Bar
+    def get_x: -> untyped
+  end
+end
+
+## update: test0.rb
+module Foo
+  X = "hello"
+end
+
+## assert: test1.rb
+module Foo
+  class Bar
+    def get_x: -> String
+  end
+end