Skip to content

Fix wrong Encoding resolution #258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kou merged 1 commit into from
Jul 7, 2025
+22 −1
Merged

Fix wrong Encoding resolution #258

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/rexml/encoding.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ module Encoding
# ID ---> Encoding name
attr_reader :encoding
def encoding=(encoding)
encoding = encoding.name if encoding.is_a?(Encoding)
encoding = encoding.name if encoding.is_a?(::Encoding)
if encoding.is_a?(String)
original_encoding = encoding
encoding = find_encoding(encoding)
Expand Down
21 changes: 21 additions & 0 deletions test/test_source.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
require "rexml/source"

module REXMLTests
class TestSource < Test::Unit::TestCase
def setup
@source = REXML::Source.new(+"<root/>")
end

sub_test_case("#encoding=") do
test("String") do
@source.encoding = "UTF-8"
assert_equal("UTF-8", @source.encoding)
end

test("Encoding") do
@source.encoding = Encoding::UTF_8
assert_equal("UTF-8", @source.encoding)
end
end
end
end