Ability to force controller icon style project wide

[MrEliptik]

I'd like to give the user the ability to select the glyph type they want instead of relying solely on auto detection. I don't see a way to force all textures to use a type apart from going through each ControllerIconTexture and setting force_controller_icon_style. Am I missing something?

It would be awesome to have something like ControllerIcons.set_force_controller_icon_style() and have it propagate everywhere.

[greenpixels]

Do you by chance mean exactly this?
#134

Edit: Ah apologies, I read too fast and missed that you don't want to set it per ControllerIconTexture, but for all of them at once, sorry. if I remember correctly, I had your exact use-case. I'll take a look on how I implemented it or whether I misremember.

Edit Edit: Nope, seems like I only needed to force a specific device ID. That sounds like a good proposition though, I'd wait for what @rsubtil has to say on this, maybe I'm missing something. The implementation should be rather straight forward if you follow the leads of the PR linked above - maybe you wanna give it a try? @MrEliptik

[rsubtil]

The most straightforward way to do this is to implement a custom mapper script, and override the global mapping logic to your project needs. In fact, I had that exact scenario on an old project of mine, see here for an implementation example.

I'm wary of introducing this as a new option in the addon, since it's a global change in behavior. The current tweaks the addon offers per icon are meant for only a few cases where a bit more control over the icon's behavior is desired (e.g. configuration menus and such). For more generalized needs, I've isolated the mapping process to a script and allow it to be easily extended. To me, such needs from project developers are much easier and better expressed "in code", rather than attempt to support every use-case with new addon options, that would bloat the addon's configurations and require extensive documentation to fully explain.

Let me know what do you think of this approach. If the mapper script is not enough for your needs, I'm planning to extract more functionality to it in a future v4 version to increase flexibility.

[greenpixels]

I'd argue that wanting to override the displayed glyph type in a game is a feature that steam input players would often want as steam input almost always displays controller as xbox controllers in-game - so maybe in this specific case it'd warrant an implementation for it? But I can also see how introducing global runtime configurations could bloat the addon and be an additional thing to maintain, mh ...

Maybe the mapper script really is the best way to go about this. :)

[MrEliptik]

I didn't really look that much into the mapper, so I don't know how much work is required. I totally understand not wanting to bloat the addon with all the specific needs people might have. I feel like overriding the glyph type is quite common though.

Meanwhile, I've modified the addon to add a variable in ControllerIcons and a signal that is sent when you set the override. The texture script connects to that signal and set its local force_controller_icon_style variable.

[rsubtil]

Happy new year everyone!

I've been busy for the last month, but it actually allowed me to mull over this topic. While I'm still quite 50/50 on which approach should be followed, I see how this feature is more common than I initially assumed, and that having an easy way to change it in the configuration would be easier.