From bbafe3db351dd5eebe1b9d3db73bc36969652859 Mon Sep 17 00:00:00 2001 From: Barbara Borges Ribeiro Date: Fri, 24 Feb 2017 01:12:05 +0000 Subject: [PATCH 1/2] run ensureActivatedTab() after renderMenu (renderValue method) is called. This allows for the correct tab to be selected for dynamic sidebars (closes #87, closes #71) --- inst/shinydashboard.js | 1 + 1 file changed, 1 insertion(+) diff --git a/inst/shinydashboard.js b/inst/shinydashboard.js index b41c31bd..1a8374ff 100644 --- a/inst/shinydashboard.js +++ b/inst/shinydashboard.js @@ -100,6 +100,7 @@ $(function() { Shiny.initializeInputs(el); Shiny.bindAll(el); + ensureActivatedTab(); } }); Shiny.outputBindings.register(menuOutputBinding, From 9d0b51d79c1148a01e334494a214a9bae4e8603c Mon Sep 17 00:00:00 2001 From: Barbara Borges Ribeiro Date: Fri, 24 Feb 2017 01:23:03 +0000 Subject: [PATCH 2/2] news item --- NEWS.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/NEWS.md b/NEWS.md index a71b6826..abd2f433 100644 --- a/NEWS.md +++ b/NEWS.md @@ -1,6 +1,8 @@ shinydashboard 0.5.3.9000 ========================= +* Fixed [#71](https://github.com/rstudio/shinydashboard/issues/71) and [#87](https://github.com/rstudio/shinydashboard/issues/87): detect and enforce selected tab for dynamic sidebars. ([#189](https://github.com/rstudio/shinydashboard/pull/189)) + * Fixed [#73](https://github.com/rstudio/shinydashboard/issues/73): add `collapsed` argument to `dashboardSidebar()`, which allows it to start off collapsed. ([#186](https://github.com/rstudio/shinydashboard/pull/186)) * Fixed [#62](https://github.com/rstudio/shinydashboard/issues/62): make images resize when the sidebar collapses/expands. [#185](https://github.com/rstudio/shinydashboard/pull/185)