From 3a414a35c253d01e28b00778d5bfad14c057c302 Mon Sep 17 00:00:00 2001 From: Mikael Arguedas Date: Thu, 4 Jun 2020 18:13:51 +0200 Subject: [PATCH 1/2] [test_security] enable tests for cyclonedds Signed-off-by: Mikael Arguedas --- test_security/CMakeLists.txt | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/test_security/CMakeLists.txt b/test_security/CMakeLists.txt index c078f64a..1a73e7a9 100644 --- a/test_security/CMakeLists.txt +++ b/test_security/CMakeLists.txt @@ -274,7 +274,8 @@ if(BUILD_TESTING) (rmw_implementation STREQUAL "rmw_connext_cpp" AND NOT WIN32) OR (rmw_implementation STREQUAL "rmw_connext_dynamic_cpp" AND NOT WIN32) OR rmw_implementation STREQUAL "rmw_fastrtps_cpp" OR - rmw_implementation STREQUAL "rmw_fastrtps_dynamic_cpp" + rmw_implementation STREQUAL "rmw_fastrtps_dynamic_cpp" OR + rmw_implementation STREQUAL "rmw_cyclonedds_cpp" ) custom_security_test_c(test_security_nodes_c "test/test_invalid_secure_node_creation_c.cpp") From 8876c0a2da5b6da298143ca0e3ab8ecba5093856 Mon Sep 17 00:00:00 2001 From: Mikael Arguedas Date: Sat, 1 Aug 2020 14:19:54 +0200 Subject: [PATCH 2/2] remove TODO now that all tier1 RMW support DDS-Security Signed-off-by: Mikael Arguedas --- test_security/CMakeLists.txt | 1 - 1 file changed, 1 deletion(-) diff --git a/test_security/CMakeLists.txt b/test_security/CMakeLists.txt index 1a73e7a9..b667d802 100644 --- a/test_security/CMakeLists.txt +++ b/test_security/CMakeLists.txt @@ -268,7 +268,6 @@ if(BUILD_TESTING) string(REPLACE ";" ":" TEST_PATH "${TEST_PATH}") endif() - # TODO(mikaelarguedas) only Connext and FastRTPS support DDS-Security for now # TODO(jacobperron) Disable Connext on Windows until we fix issue with CI if( (rmw_implementation STREQUAL "rmw_connext_cpp" AND NOT WIN32) OR