From 1194e733000cabd18d32d3302b1a0f9c6d76f1a0 Mon Sep 17 00:00:00 2001 From: Andrea Sorbini Date: Thu, 1 Apr 2021 16:51:12 -0700 Subject: [PATCH 1/2] Downgrade benign error messages to debug Signed-off-by: Andrea Sorbini --- rosidl_typesupport_c/src/type_support_dispatch.hpp | 7 +++++-- rosidl_typesupport_cpp/src/type_support_dispatch.hpp | 7 +++++-- 2 files changed, 10 insertions(+), 4 deletions(-) diff --git a/rosidl_typesupport_c/src/type_support_dispatch.hpp b/rosidl_typesupport_c/src/type_support_dispatch.hpp index 4c7ae3e6..a644f1af 100644 --- a/rosidl_typesupport_c/src/type_support_dispatch.hpp +++ b/rosidl_typesupport_c/src/type_support_dispatch.hpp @@ -110,9 +110,12 @@ get_typesupport_handle_function( return ts; } } - RCUTILS_SET_ERROR_MSG_WITH_FORMAT_STRING( - "Handle's typesupport identifier (%s) is not supported by this library", + + RCUTILS_LOG_DEBUG_NAMED( + "rosidl_typesupport_c", + "type support `%s` is not used by this library", handle->typesupport_identifier); + return nullptr; } diff --git a/rosidl_typesupport_cpp/src/type_support_dispatch.hpp b/rosidl_typesupport_cpp/src/type_support_dispatch.hpp index c662ffc2..d35f1ba1 100644 --- a/rosidl_typesupport_cpp/src/type_support_dispatch.hpp +++ b/rosidl_typesupport_cpp/src/type_support_dispatch.hpp @@ -108,9 +108,12 @@ get_typesupport_handle_function( return ts; } } - RCUTILS_SET_ERROR_MSG_WITH_FORMAT_STRING( - "Handle's typesupport identifier (%s) is not supported by this library", + + RCUTILS_LOG_DEBUG_NAMED( + "rosidl_typesupport_cpp", + "type support `%s` is not used by this library", handle->typesupport_identifier); + return nullptr; } From 52e58987ee862f4342ebc2eb32b9b5d05582afc3 Mon Sep 17 00:00:00 2001 From: Andrea Sorbini Date: Thu, 1 Apr 2021 17:18:26 -0700 Subject: [PATCH 2/2] Add missing logging macros header Signed-off-by: Andrea Sorbini --- rosidl_typesupport_c/src/type_support_dispatch.hpp | 1 + rosidl_typesupport_cpp/src/type_support_dispatch.hpp | 1 + 2 files changed, 2 insertions(+) diff --git a/rosidl_typesupport_c/src/type_support_dispatch.hpp b/rosidl_typesupport_c/src/type_support_dispatch.hpp index a644f1af..0633071f 100644 --- a/rosidl_typesupport_c/src/type_support_dispatch.hpp +++ b/rosidl_typesupport_c/src/type_support_dispatch.hpp @@ -26,6 +26,7 @@ #include "rcpputils/shared_library.hpp" #include "rcutils/error_handling.h" #include "rcutils/snprintf.h" +#include "rcutils/logging_macros.h" #include "rosidl_typesupport_c/identifier.h" #include "rosidl_typesupport_c/type_support_map.h" diff --git a/rosidl_typesupport_cpp/src/type_support_dispatch.hpp b/rosidl_typesupport_cpp/src/type_support_dispatch.hpp index d35f1ba1..911bb478 100644 --- a/rosidl_typesupport_cpp/src/type_support_dispatch.hpp +++ b/rosidl_typesupport_cpp/src/type_support_dispatch.hpp @@ -25,6 +25,7 @@ #include "rcpputils/shared_library.hpp" #include "rcutils/error_handling.h" #include "rcutils/snprintf.h" +#include "rcutils/logging_macros.h" #include "rosidl_typesupport_c/type_support_map.h" namespace rosidl_typesupport_cpp