tinyxml2 and eigen fail to uninstall if the registery keys are missing

[wjwwood]

See: ros2/ros2#516

I got in a situation some how where the registry keys that CMake needs were not setup and so I fixed it by uninstalling and reinstalling the chocolatey packages, but for tinyxml2 and eigen (but not asio) the uninstall failed, complaining about the keys not being found (I guess trying to remove them).

Not sure if this needs to be fixed, but opening for visibility. Feel free to close as wont fix, since you can just uninstall with -n and reinstall to workaround it.

[nuclearsandwich]

Cross-posting for visibility. I have an in verified hunch that current installs of CMake do not create the Packages directory in the registry and that without it the chocolatey install scripts may be failing silently.

Ensuring that the install scripts run successfully or not at all is probably the best way to fix this but we could also try checking for the keys before removing them in the uninstall script if we can't make installation reliable.

[nuclearsandwich]

In theory I tried to handle the creation of the parent tree with the -Force option.

choco-packages/package/asio/tools/chocolateyinstall.ps1

Lines 14 to 15 in 7dd3629

	# The force is necessary to make this create parent keys (think `mkdir -p`). It ain't great.
	New-Item $CMakeSystemRepositoryPath -ItemType directory -Force

So perhaps the issue is something else.