smach_viewer does not work in indigo

[asundaresan]

It seems xdot api has changed in Ubuntu 14.04/ Indigo and this breaks smach_viewer.py. The details are in the following question I posted on answers.ros.org.

http://answers.ros.org/question/186955/smach_viewer-does-not-work-in-indigo/

The error message when I run smach_viewer.py is as follows.

[aravind@jeeves simple_smach]$ rosrun smach_viewer smach_viewer.py
Exception in thread Thread-6:
Traceback (most recent call last):
File "/usr/lib/python2.7/threading.py", line 810, in __bootstrap_inner
self.run()
File "/usr/lib/python2.7/threading.py", line 763, in run
self.__target(_self.__args, *_self.__kwargs)
File "/opt/ros/indigo/lib/smach_viewer/smach_viewer.py", line 848, in _update_graph
self.set_dotcode(dotstr,zoom=False)
File "/opt/ros/indigo/lib/smach_viewer/smach_viewer.py", line 866, in set_dotcode
if self.widget.set_dotcode(dotcode, None):
File "/opt/ros/indigo/lib/python2.7/dist-packages/xdot/wxxdot.py", line 455, in set_dotcode
self.set_xdotcode(xdotcode)
File "/opt/ros/indigo/lib/python2.7/dist-packages/xdot/wxxdot.py", line 483, in set_xdotcode
self.graph = parser.parse()
File "/opt/ros/indigo/lib/python2.7/dist-packages/xdot/xdot.py", line 1146, in parse
DotParser.parse(self)
File "/opt/ros/indigo/lib/python2.7/dist-packages/xdot/xdot.py", line 951, in parse
self.parse_graph()
File "/opt/ros/indigo/lib/python2.7/dist-packages/xdot/xdot.py", line 960, in parse_graph
self.parse_stmt()
File "/opt/ros/indigo/lib/python2.7/dist-packages/xdot/xdot.py", line 993, in parse_stmt
self.parse_subgraph()
File "/opt/ros/indigo/lib/python2.7/dist-packages/xdot/xdot.py", line 974, in parse_subgraph
self.parse_stmt()
File "/opt/ros/indigo/lib/python2.7/dist-packages/xdot/xdot.py", line 993, in parse_stmt
self.parse_subgraph()
File "/opt/ros/indigo/lib/python2.7/dist-packages/xdot/xdot.py", line 974, in parse_subgraph
self.parse_stmt()
File "/opt/ros/indigo/lib/python2.7/dist-packages/xdot/xdot.py", line 1009, in parse_stmt
self.handle_node(id, attrs)
File "/opt/ros/indigo/lib/python2.7/dist-packages/xdot/xdot.py", line 1120, in handle_node
shapes.extend(parser.parse())
File "/opt/ros/indigo/lib/python2.7/dist-packages/xdot/xdot.py", line 608, in parse
points = self.read_polygon()
File "/opt/ros/indigo/lib/python2.7/dist-packages/xdot/xdot.py", line 503, in read_polygon
x, y = self.read_point()
File "/opt/ros/indigo/lib/python2.7/dist-packages/xdot/xdot.py", line 486, in read_point
x = self.read_number()
File "/opt/ros/indigo/lib/python2.7/dist-packages/xdot/xdot.py", line 480, in read_number
return int(self.read_code())
ValueError: invalid literal for int() with base 10: '79.92'

[jonbinney]

I just poked around a bit and it looks like smach uses a version of xdot which is from @jbohren's fork: https://github.com/jbohren/xdot . I think this is a problem with that version of xdot; so i've created an issue there: jbohren/xdot#5

[jbohren]

I'll take a look at this soon.

[pirobot]

I'm still getting this same problem under ROS Indigo and Ubuntu 14.04. Any luck figuring out a fix? Thanks!

[pirobot]

Hi @jbohren, any chance this will be fixed soon? I'm trying to get an Indigo revision of my ROS By Example book out the door and this is one of the last glitches when it comes to migrating from Hydro to Indigo. (I have a whole chapter on using SMACH).

Thanks!

[pirobot]

@jonbinney - Thanks for the xdot fix (jbohren/xdot#5). This allowed me to bring up smach_viewer.py under ROS Indigo and view the changing states. So far I haven't run into any segfaults on Ubuntu 14.04 Debian install and ROS Indigo Debian install.

[mkrogius]

I am on ubuntu 14.04 and ros indigo as well and I am seeing a number of segfaults. If you select a node with your mouse do you not get a segfault?

[pirobot]

Ah yes, I see what you mean. I had not clicked on any nodes before--I was just watching the states change which seems to work OK. However, even clicking on nodes, I get crashes only very occasionally.

[mkrogius]

Other actions, such as maximizing the window, or clicking on tree view also sometimes cause segfaults for me

[k-okada]

This has been fixed in jbohren/xdot#7, so I think it ok to close this issue

[jbohren]

Also, I'm going to make an announcement about this soon: https://github.com/jbohren/executive_smach_visualization/blob/master/rqt_smach/doc/rqt_smach.md

[muhrix]

@jbohren sorry to bother you. I was just wondering the current status of this issue.

I am trying to run smach_viewer (after changing those couple of lines of the xdot python scripts), but I am still getting recurrent seg faults (pretty much all the time actually).

Oh yeah, I'm running Indigo on 14.04.

Thanks a lot!

[furushchev]

Now we have to wait new releasing of xdot ( a dependency of this package)
jbohren/xdot#13
CC: @jbohren