Skip to content
This repository was archived by the owner on Jan 9, 2026. It is now read-only.

Handles relative image URLs and ensures dir exists #74

Merged
gantoine merged 3 commits into from
Jan 9, 2026
Merged

Handles relative image URLs and ensures dir exists #74

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e8ff476
Handles relative image URLs and ensures dir exists
ZacharyKeatings Jan 9, 2026
e72d546
Replaces manual string checking with urljoin for robustness
ZacharyKeatings Jan 9, 2026
32f87e3
run turnk fmt
gantoine Jan 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions RomM/api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -652,6 +652,7 @@ def download_rom(self) -> None:
)
if not catalogue_path:
continue
os.makedirs(catalogue_path, exist_ok=True)

filename = self._sanitize_filename(rom.fs_name_no_ext)
if rom.summary:
Expand Down
5 changes: 5 additions & 0 deletions RomM/imageutils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
from io import BytesIO
from typing import Optional
from urllib.error import HTTPError, URLError
from urllib.parse import urljoin
from urllib.request import Request, urlopen

from PIL import Image, ImageDraw
Expand Down Expand Up @@ -54,6 +55,10 @@ def add_rounded_corners(self, image: Image.Image, radius: int = 20):

def load_image_from_url(self, url: str, headers: dict) -> Image.Image | None:
try:
# Use urljoin to properly resolve relative URLs against the host
if url:
url = urljoin(f"{self.host}/", url)

req = Request(url.split("?")[0], headers=headers)
with urlopen(req, timeout=60) as response: # trunk-ignore(bandit/B310)
data = response.read()
Expand Down