From b18dfb19d310dbac291ed80114fec47e1f10ac66 Mon Sep 17 00:00:00 2001 From: David Roesel Date: Mon, 16 Jun 2025 16:45:45 +0200 Subject: [PATCH 1/3] Update controller.py --- src/elliptec/controller.py | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/src/elliptec/controller.py b/src/elliptec/controller.py index 42c2ed2..1ef6037 100644 --- a/src/elliptec/controller.py +++ b/src/elliptec/controller.py @@ -23,6 +23,7 @@ def __init__(self, write_timeout=0.5, debug=True): self.debug = debug + self.port = port # Store the port parameter as an instance variable if port == None: self.__search_and_connect(baudrate, bytesize, @@ -79,7 +80,8 @@ def __search_and_connect(self, write_timeout): port_list = serial.tools.list_ports.comports() for port in port_list: - self.__connect_to_port(port, + self.port = port + self.__connect_to_port(self.port, baudrate, bytesize, parity, @@ -88,12 +90,6 @@ def __search_and_connect(self, write_timeout) break - def __enter__(self): - return self - - def __exit__(self, exc_type, exc_val, exc_tb): - self.close() - def read_response(self): """Reads the response from the controller.""" response = self.s.read_until(b"\r\n") # Waiting until response read From 57001190af9a4112edb4706bfe7efe82352e1513 Mon Sep 17 00:00:00 2001 From: David Roesel Date: Mon, 16 Jun 2025 16:48:36 +0200 Subject: [PATCH 2/3] Linting improvements --- src/elliptec/controller.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/elliptec/controller.py b/src/elliptec/controller.py index 1ef6037..323c5a4 100644 --- a/src/elliptec/controller.py +++ b/src/elliptec/controller.py @@ -1,6 +1,5 @@ """This module contains the Controller class, which is the base class for all devices.""" -import sys import serial from .tools import parse @@ -24,7 +23,7 @@ def __init__(self, debug=True): self.debug = debug self.port = port # Store the port parameter as an instance variable - if port == None: + if port is None: self.__search_and_connect(baudrate, bytesize, parity, From 016d26ff845b22e7d54e7ef36977160d5ec1b7bd Mon Sep 17 00:00:00 2001 From: David Roesel Date: Mon, 16 Jun 2025 16:51:40 +0200 Subject: [PATCH 3/3] Linter improvements --- pyproject.toml | 2 -- 1 file changed, 2 deletions(-) diff --git a/pyproject.toml b/pyproject.toml index 9d40302..ed65e74 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -30,8 +30,6 @@ dependencies = [ [tool.ruff] # Allow lines to be as long as 119 characters. line-length = 119 -# Ignore errors of unused module imports in __init__.py -ignore-init-module-imports = true [tool.black] # Allow lines to be as long as 119 characters.