Type inconsistencies

[Dobatymo]

Endpoint /v1/media/show/all returns "hosts": null which is illegal according to

rbtv-apidoc/response/media/MediaPublic.ts

Line 26 in 91e85c2

hosts: Array<bohnePortrait>;

and "lastEpisode": {"episodes": [{"seasonId": null, "episode": null, "firstBroadcastdate": null}]} which is illegal according to

rbtv-apidoc/response/media/MediaPublic.ts

Lines 82 to 83 in 91e85c2

	seasonId: number;
	episode: number;

rbtv-apidoc/response/media/MediaPublic.ts

Line 91 in 5ef4785

firstBroadcastdate: Date;

and "lastEpisode": {"episodes": [{"tokens": [{...}]}]} misses mediaEpisodeId which is not optional according to

rbtv-apidoc/response/media/MediaPublic.ts

Line 72 in 91e85c2

mediaEpisodeId: number;

and actually many others...

[r0oto0r]

Hey @Dobatymo,

thanks for reporting. Will look into this anytime soon!

Cheers,
Ben

[r0oto0r]

Hey @Dobatymo,

I finally found some time to look into this. I've managed to fix couple of problems you've mentioned above, but there might be to many to just go and look for them throughout the entire code base. So, I will fix every issue that I'll come across moving forward, but won't explicitly search for them. In any case, if you have some more problems identified please do not hesitate and report them here. I will take care of fixing those and releasing patches from time to time.

Regarding the last issue (mediaEpisodeId is null). This is actually a bug in our API code and not a wrong type definition. It's been already identified and removed in our stage and will head live during our next release cycle.

Again, thanks for your help improving our API + documentation! Really appreciate it.

Cheers,
Ben