Skip to content

Handle bogus non unicode data on Radius:IETF Class-attributes #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ottorei wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Handle bogus non unicode data on Radius:IETF Class-attributes #26

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 14 additions & 11 deletions radiusauth/backends/radius.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,17 +149,20 @@ def _perform_radius_auth(self, client, packet):
role_class_prefix = app_class_prefix + "role="

for cl in reply['Class']:
cl = cl.decode("utf-8")
if cl.lower().find(group_class_prefix) == 0:
groups.append(cl[len(group_class_prefix):])
elif cl.lower().find(role_class_prefix) == 0:
role = cl[len(role_class_prefix):]
if role == "staff":
is_staff = True
elif role == "superuser":
is_superuser = True
else:
logging.warning("RADIUS Attribute Class contains unknown role '%s'. Only roles 'staff' and 'superuser' are allowed" % cl)
try:
cl = cl.decode("utf-8")
if cl.lower().find(group_class_prefix) == 0:
groups.append(cl[len(group_class_prefix):])
elif cl.lower().find(role_class_prefix) == 0:
role = cl[len(role_class_prefix):]
if role == "staff":
is_staff = True
elif role == "superuser":
is_superuser = True
else:
logging.warning("RADIUS Attribute Class contains unknown role '%s'. Only roles 'staff' and 'superuser' are allowed" % cl)
except UnicodeDecodeError:
pass
return groups, is_staff, is_superuser

def _radius_auth(self, server, username, password):
Expand Down