BCDB module need to use a ZDB client not a ZDB server

[zaibon]

Currently the bcdb module relies on the existence of a zdb server instance to work:

recordchain/JumpScale9RecordChain/data/bcdb/BCDBFactory.py

Lines 20 to 27 in 5f8f159

	def get(self, instance):
	s = j.servers.zdb.get(instance=instance)
	data = {}
	data["zdb_adminsecret_"] = s.config.data["adminsecret_"]
	data["zdb_port"] = str(s.config.data["port"])
	bcdb = self._child_class(instance=instance, data=data, parent=self, interactive=False)
	bcdb.server = s
	return bcdb

Then in the bcdb code, the zdb server instance is used to get a client to zdb:

recordchain/JumpScale9RecordChain/data/bcdb/BCDBTable.py

Line 35 in 5f8f159

self.db = self.bcdb.server.client_get(namespace=self.name, secret=s.config.data["adminsecret_"])

Which mean we actually don't need to pass by a zdb server instance at all. The current implementation also disallow to use a remote zdb since the zdb server instance has only a notion of port and not of address. So it is silently suppsed tha zdb is running locally.

So to fix this, I'll change bcdb module to requires a zdb client.

[despiegk]

a remote zdb should be possible

[zaibon]

@despiegk are you saying it should already be possible? Or that my issue is correct and we have to modify the code to allow remote zbd?