diff --git a/README.md b/README.md index cbbadcb..b5bf809 100644 --- a/README.md +++ b/README.md @@ -71,19 +71,19 @@ Example output: BITCOINUI REVIEW: SendFeeView.swift =============================================== -SERIOUS (1 issue) +MEDIUM (1 issue) ------------------ [UX] Line 88: Fee picker lacks a high-fee warning Fix: Add a warning when fee >= 50% of amount. Reference: Bitcoin Design Guide — Send fees https://bitcoin.design/guide/daily-spending-wallet/sending/send-fees/ -MODERATE (1 issue) +LOW (1 issue) ------------------ [A11Y] Line 42: Icon-only close button has no label Fix: Add accessibilityLabel("Close") Reference: iOS HIG — Accessibility https://developer.apple.com/design/human-interface-guidelines/accessibility =============================================== -SUMMARY: 0 critical, 1 serious, 1 moderate, 0 info +SUMMARY: 0 high, 1 medium, 1 low =============================================== ``` diff --git a/commands/bitcoinui.md b/commands/bitcoinui.md index 19e8d17..2bc52a8 100644 --- a/commands/bitcoinui.md +++ b/commands/bitcoinui.md @@ -31,35 +31,31 @@ If `$ARGUMENTS` is empty, ask: "Using the bitcoinui command for an iOS review. W ## Output Format Start directly with the `BITCOINUI REVIEW` block; do not add any preamble text before it. -Omit any severity section with 0 issues (including INFO). +Omit any severity section with 0 issues (including LOW). ``` =============================================== BITCOINUI REVIEW: [filename] =============================================== -CRITICAL (X issues) +HIGH (X issues) ------------------ [UX] Line 42: Missing warning for fee > amount Fix: Add a warning state when fee >= 50% of amount. Reference: Bitcoin Design Guide — Send fees https://bitcoin.design/guide/daily-spending-wallet/sending/send-fees/ -SERIOUS (X issues) +MEDIUM (X issues) ------------------ [A11Y] Line 18: Icon-only button has no label Fix: Add accessibilityLabel("Close") Reference: iOS HIG — Accessibility https://developer.apple.com/design/human-interface-guidelines/accessibility -MODERATE (X issues) +LOW (X issues) ------------------ ... -INFO (X issues) --------------- -... - =============================================== -SUMMARY: X critical, X serious, X moderate, X info +SUMMARY: X high, X medium, X low =============================================== ``` @@ -71,5 +67,5 @@ SUMMARY: X critical, X serious, X moderate, X info 4. Include a direct URL in each Reference line. 5. For Bitcoin-specific issues, include at least one Bitcoin Design Guide or BIP URL in the Reference line. 6. Suggest BitcoinUI components when they fit the pattern. -7. INFO is for optional polish/consistency notes; skip it if there are no meaningful suggestions. +7. LOW is for optional polish/consistency notes; skip it if there are no meaningful suggestions. 8. Do not modify code unless asked; offer to fix if appropriate. diff --git a/site/bitcoinui.md b/site/bitcoinui.md index 19e8d17..2bc52a8 100644 --- a/site/bitcoinui.md +++ b/site/bitcoinui.md @@ -31,35 +31,31 @@ If `$ARGUMENTS` is empty, ask: "Using the bitcoinui command for an iOS review. W ## Output Format Start directly with the `BITCOINUI REVIEW` block; do not add any preamble text before it. -Omit any severity section with 0 issues (including INFO). +Omit any severity section with 0 issues (including LOW). ``` =============================================== BITCOINUI REVIEW: [filename] =============================================== -CRITICAL (X issues) +HIGH (X issues) ------------------ [UX] Line 42: Missing warning for fee > amount Fix: Add a warning state when fee >= 50% of amount. Reference: Bitcoin Design Guide — Send fees https://bitcoin.design/guide/daily-spending-wallet/sending/send-fees/ -SERIOUS (X issues) +MEDIUM (X issues) ------------------ [A11Y] Line 18: Icon-only button has no label Fix: Add accessibilityLabel("Close") Reference: iOS HIG — Accessibility https://developer.apple.com/design/human-interface-guidelines/accessibility -MODERATE (X issues) +LOW (X issues) ------------------ ... -INFO (X issues) --------------- -... - =============================================== -SUMMARY: X critical, X serious, X moderate, X info +SUMMARY: X high, X medium, X low =============================================== ``` @@ -71,5 +67,5 @@ SUMMARY: X critical, X serious, X moderate, X info 4. Include a direct URL in each Reference line. 5. For Bitcoin-specific issues, include at least one Bitcoin Design Guide or BIP URL in the Reference line. 6. Suggest BitcoinUI components when they fit the pattern. -7. INFO is for optional polish/consistency notes; skip it if there are no meaningful suggestions. +7. LOW is for optional polish/consistency notes; skip it if there are no meaningful suggestions. 8. Do not modify code unless asked; offer to fix if appropriate. diff --git a/site/index.html b/site/index.html index d4bf203..3725cc1 100644 --- a/site/index.html +++ b/site/index.html @@ -64,12 +64,12 @@

OpenCode

INSTALL -> RUN BITCOINUI -> GET A DESIGN REVIEW

BITCOINUI REVIEW: SendFeeView.swift
 ===================================
-SERIOUS (1 issue)
-----------------
+MEDIUM (1 issue)
+---------------
 [UX] Line 88: Fee picker lacks a high-fee warning
 Fix: Add a warning when fee >= 50% of amount.
 Reference: Bitcoin Design Guide - Send fees https://bitcoin.design/guide/daily-spending-wallet/sending/send-fees/
-SUMMARY: 0 critical, 1 serious, 0 moderate
+SUMMARY: 0 high, 1 medium, 0 low diff --git a/site/skills/bitcoinui/SKILL.md b/site/skills/bitcoinui/SKILL.md index 35b0438..5d8d278 100644 --- a/site/skills/bitcoinui/SKILL.md +++ b/site/skills/bitcoinui/SKILL.md @@ -21,43 +21,39 @@ Review iOS SwiftUI code and screens for Bitcoin-specific UX correctness, iOS HIG 2. Apply the rubric in `references/bitcoinui-rubric.md`. 3. Report issues by severity with line numbers, a short snippet, and a concrete fix. Include a direct URL in each Reference line. 4. For Bitcoin-specific issues, include at least one Bitcoin Design Guide or BIP URL in the Reference line. -4. Suggest BitcoinUI components when they would reduce errors or improve consistency. -5. Omit any severity section with 0 issues (including INFO). -6. INFO is for optional polish/consistency notes; skip it if there are no meaningful suggestions. -7. Do not modify code unless the user asks; offer to fix if appropriate. +5. Suggest BitcoinUI components when they would reduce errors or improve consistency. +6. Omit any severity section with 0 issues (including LOW). +7. LOW is for optional polish/consistency notes; skip it if there are no meaningful suggestions. +8. Do not modify code unless the user asks; offer to fix if appropriate. ## Output Format Start directly with the `BITCOINUI REVIEW` block; do not add any preamble text before it. -Omit any severity section with 0 issues (including INFO). +Omit any severity section with 0 issues (including LOW). ``` =============================================== BITCOINUI REVIEW: [filename] =============================================== -CRITICAL (X issues) +HIGH (X issues) ------------------ [UX] Line 42: Missing warning for fee > amount Fix: Add a warning state when fee >= 50% of amount. Reference: Bitcoin Design Guide — Send fees https://bitcoin.design/guide/daily-spending-wallet/sending/send-fees/ -SERIOUS (X issues) +MEDIUM (X issues) ------------------ [A11Y] Line 18: Icon-only button has no label Fix: Add accessibilityLabel("Close") Reference: iOS HIG — Accessibility https://developer.apple.com/design/human-interface-guidelines/accessibility -MODERATE (X issues) +LOW (X issues) ------------------ ... -INFO (X issues) --------------- -... - =============================================== -SUMMARY: X critical, X serious, X moderate, X info +SUMMARY: X high, X medium, X low =============================================== ``` diff --git a/skills/bitcoinui/SKILL.md b/skills/bitcoinui/SKILL.md index 35b0438..5d8d278 100644 --- a/skills/bitcoinui/SKILL.md +++ b/skills/bitcoinui/SKILL.md @@ -21,43 +21,39 @@ Review iOS SwiftUI code and screens for Bitcoin-specific UX correctness, iOS HIG 2. Apply the rubric in `references/bitcoinui-rubric.md`. 3. Report issues by severity with line numbers, a short snippet, and a concrete fix. Include a direct URL in each Reference line. 4. For Bitcoin-specific issues, include at least one Bitcoin Design Guide or BIP URL in the Reference line. -4. Suggest BitcoinUI components when they would reduce errors or improve consistency. -5. Omit any severity section with 0 issues (including INFO). -6. INFO is for optional polish/consistency notes; skip it if there are no meaningful suggestions. -7. Do not modify code unless the user asks; offer to fix if appropriate. +5. Suggest BitcoinUI components when they would reduce errors or improve consistency. +6. Omit any severity section with 0 issues (including LOW). +7. LOW is for optional polish/consistency notes; skip it if there are no meaningful suggestions. +8. Do not modify code unless the user asks; offer to fix if appropriate. ## Output Format Start directly with the `BITCOINUI REVIEW` block; do not add any preamble text before it. -Omit any severity section with 0 issues (including INFO). +Omit any severity section with 0 issues (including LOW). ``` =============================================== BITCOINUI REVIEW: [filename] =============================================== -CRITICAL (X issues) +HIGH (X issues) ------------------ [UX] Line 42: Missing warning for fee > amount Fix: Add a warning state when fee >= 50% of amount. Reference: Bitcoin Design Guide — Send fees https://bitcoin.design/guide/daily-spending-wallet/sending/send-fees/ -SERIOUS (X issues) +MEDIUM (X issues) ------------------ [A11Y] Line 18: Icon-only button has no label Fix: Add accessibilityLabel("Close") Reference: iOS HIG — Accessibility https://developer.apple.com/design/human-interface-guidelines/accessibility -MODERATE (X issues) +LOW (X issues) ------------------ ... -INFO (X issues) --------------- -... - =============================================== -SUMMARY: X critical, X serious, X moderate, X info +SUMMARY: X high, X medium, X low =============================================== ``` diff --git a/skills/bitcoinui/references/bitcoinui-rubric.md b/skills/bitcoinui/references/bitcoinui-rubric.md index db35499..35bf978 100644 --- a/skills/bitcoinui/references/bitcoinui-rubric.md +++ b/skills/bitcoinui/references/bitcoinui-rubric.md @@ -8,10 +8,9 @@ ## Severity -- Critical: could cause loss of funds, irreversible mistakes, or misleading safety. -- Serious: likely user error, accessibility blockers, or major HIG violations. -- Moderate: clarity or consistency issues. -- Info: polish suggestions. +- High: could cause loss of funds, irreversible mistakes, or misleading safety. +- Medium: likely user error, accessibility blockers, or major HIG violations. +- Low: clarity or consistency issues and polish suggestions. ## Bitcoin-Specific Checks