Skip to content

[CodeQuality] Skip indirect parent is PHPUnit\Framework\TestCase on NoSetupWithParentCallOverrideRector #618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
samsonasik wants to merge 7 commits into from
Closed

[CodeQuality] Skip indirect parent is PHPUnit\Framework\TestCase on NoSetupWithParentCallOverrideRector #618

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
c448f72
[CodeQuality] Skip indirect parent is PHPUnit\Framework\TestCase on N…
samsonasik Jan 27, 2026
a9324ed
eol
samsonasik Jan 27, 2026
067679b
fix: add TestsNodeAnalyzer::isDirectlyExtendsTestCase()
samsonasik Jan 27, 2026
bcd0ffa
[rector] Rector fixes
actions-user Jan 27, 2026
a5bf1ab
[rector] Rector fixes
actions-user Jan 27, 2026
1adc50b
fix phpstan
samsonasik Jan 27, 2026
15ae62b
[rector] Rector fixes
actions-user Jan 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions ...sMethod/NoSetupWithParentCallOverrideRector/Fixture/skip_indirect_parent_testcase.php.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
<?php

namespace Rector\PHPUnit\Tests\CodeQuality\Rector\ClassMethod\NoSetupWithParentCallOverrideRector\Fixture;

use Rector\PHPUnit\Tests\CodeQuality\Rector\ClassMethod\NoSetupWithParentCallOverrideRector\Source\SomeFunctionalTestCase;

final class SkipIndirectParentTestCase extends SomeFunctionalTestCase
{
#[\Override]
protected function setUp(): void
{
parent::setUp();

$some = 'value';
}
}
13 changes: 13 additions & 0 deletions .../Rector/ClassMethod/NoSetupWithParentCallOverrideRector/Source/SomeFunctionalTestCase.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
<?php

namespace Rector\PHPUnit\Tests\CodeQuality\Rector\ClassMethod\NoSetupWithParentCallOverrideRector\Source;

abstract Class SomeFunctionalTestCase extends \PHPUnit\Framework\TestCase
{
protected function setUp(): void
{
parent::setUp();

init_db();
}
}
2 changes: 1 addition & 1 deletion rules/CodeQuality/Rector/ClassMethod/NoSetupWithParentCallOverrideRector.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ public function getNodeTypes(): array
*/
public function refactor(Node $node): ?Node
{
if (! $this->testsNodeAnalyzer->isInTestClass($node)) {
if (! $this->testsNodeAnalyzer->isDirectlyExtendsTestCase($node)) {
return null;
}

Expand Down
15 changes: 15 additions & 0 deletions src/NodeAnalyzer/TestsNodeAnalyzer.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,21 @@ public function isInTestClass(Node $node): bool
return false;
}

public function isDirectlyExtendsTestCase(ClassMethod $classMethod): bool
{
$classReflection = $this->reflectionResolver->resolveClassReflection($classMethod);
if (! $classReflection instanceof ClassReflection) {
return false;
}

$parents = $classReflection->getParents();
if ($parents === []) {
return false;
}

return in_array($parents[0]->getName(), PHPUnitClassName::TEST_CLASSES, true);
}

public function isTestClassMethod(ClassMethod $classMethod): bool
{
if (! $classMethod->isPublic()) {
Expand Down