all chrome.tabs.sendMessage errors ignored

[dvisztempacct]

In trying to fix a bug in reason-tools, I eventually found a page whitelist here:

reason-tools/src/extension/content/convert/detect.re

Line 57 in 07bf3b7

let getWhitelist = () => [];

So I whitelisted the local test HTML file I had created and then, because I had stopped checking the background window console, spent a long time scratching my head and double-checking assumptions. Finally, I guessed there might be a permissions issue, and sure enough, there was.

Can't whitelist local files: "Cannot access contents of page"

I realize that this whitelist is not an end-user feature, but it would be nice if this error didn't get swallowed nearly silently into the background window console.

So I took a look at where errors were being handled:

reason-tools/src/extension/common/message.re

Line 10 in 07bf3b7

let sendTab = (id, type_, message) => Chrome.Tabs.sendMessage(id, {type_, message}, noop);

noop certainly won't be handling any errors!

Any plans on improving this?

Thanks!