Explicitly link to static libraries

Author: SimplyDanny

.github/workflows/windows-release-build.yml

@@ -53,8 +53,11 @@ jobs:
             -Xswiftc -static-stdlib `
             -Xswiftc -sdk `
             -Xswiftc $sdk `
-            -Xcc -DCURL_STATICLIB `
-            -Xcc -DLIBXML_STATIC
+            -Xlinker /NODEFAULTLIB:curl -Xlinker libcurl.lib `
+            -Xlinker /NODEFAULTLIB:xml2 -Xlinker libxml2s.lib `
+            -Xlinker zlibstatic.lib `
+            -Xlinker brotlidec.lib `
+            -Xlinker brotlicommon.lib
       - name: Prepare artifacts directory
         shell: pwsh
         run: |

Package.swift

@@ -26,19 +26,6 @@ swiftLintPluginDependencies = [.target(name: "SwiftLintBinary")]
 swiftLintPluginDependencies = [.target(name: "swiftlint")]
 #endif
 
-// Linker flags for static Windows builds.
-let windowsStaticLinkerFlags: [LinkerSetting] =
-    if ProcessInfo.processInfo.environment["SWIFTLINT_STATIC_WINDOWS_BUILD"] == nil {
-        []
-    } else {
-        [
-            .linkedLibrary("libcurl.lib"),
-            .linkedLibrary("zlibstatic.lib"),
-            .linkedLibrary("brotlicommon.lib"),
-            .linkedLibrary("brotlidec.lib"),
-        ]
-    }
-
 let package = Package(
     name: "SwiftLint",
     platforms: [.macOS(.v13)],
@@ -67,8 +54,7 @@ let package = Package(
                 "SwiftLintFramework",
                 "SwiftyTextTable",
             ],
-            swiftSettings: swiftFeatures + strictConcurrency,
-            linkerSettings: windowsStaticLinkerFlags
+            swiftSettings: swiftFeatures + strictConcurrency
         ),
         .executableTarget(
             name: "swiftlint-dev",